[PATCH 2/3] scsi: ufs: ufs-qcom: Add DELAY_BEFORE_LPM quirk for Micron and Skhynix

Manish Pandey posted 3 patches 1 year, 5 months ago
[PATCH 2/3] scsi: ufs: ufs-qcom: Add DELAY_BEFORE_LPM quirk for Micron and Skhynix
Posted by Manish Pandey 1 year, 5 months ago
Micron and Skhynix UFS device needs DELAY_BEFORE_LPM quirk to have a
delay before VCC is powered off. So add Micron and SKHYNIX vendors ID
and this quirk for both devices in QCOM platforms.

Signed-off-by: Manish Pandey <quic_mapa@quicinc.com>
---
 drivers/ufs/host/ufs-qcom.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 290558843ca5..6d2622e79d3f 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -836,6 +836,12 @@ static int ufs_qcom_apply_dev_quirks(struct ufs_hba *hba)
 
 static struct ufs_dev_quirk ufs_qcom_dev_fixups[] = {
 	/* add UFS device specific quirks */
+	{ .wmanufacturerid = UFS_VENDOR_MICRON,
+	  .model = UFS_ANY_MODEL,
+	  .quirk = UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM },
+	{ .wmanufacturerid = UFS_VENDOR_SKHYNIX,
+	  .model = UFS_ANY_MODEL,
+	  .quirk = UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM },
 	{}
 };
 
-- 
2.17.1
Re: [PATCH 2/3] scsi: ufs: ufs-qcom: Add DELAY_BEFORE_LPM quirk for Micron and Skhynix
Posted by Bart Van Assche 1 year, 5 months ago
On 8/20/24 5:37 AM, Manish Pandey wrote:
>   static struct ufs_dev_quirk ufs_qcom_dev_fixups[] = {
>   	/* add UFS device specific quirks */
> +	{ .wmanufacturerid = UFS_VENDOR_MICRON,
> +	  .model = UFS_ANY_MODEL,
> +	  .quirk = UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM },
> +	{ .wmanufacturerid = UFS_VENDOR_SKHYNIX,
> +	  .model = UFS_ANY_MODEL,
> +	  .quirk = UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM },
>   	{}
>   };

What makes these quirks specific for Qualcomm controllers? Are these
quirks perhaps required for all UFSHCI controllers?

Thanks,

Bart.