ARM: dts: broadcom: bcm2166x-common: Increase apps bus size to fit BCM21664 GIC

[PATCH] ARM: dts: broadcom: bcm2166x-common: Increase apps bus size to fit BCM21664 GIC

Posted by Artur Weber 1 year, 5 months ago

The BCM21664 GIC sits at a higher address than the apps bus currently
allows. This is because the apps bus was inherited from the BCM23550
DTSI, where the GIC sits at an earlier address in memory, and the DTSI
wasn't updated to match.

Increase the size of the apps bus to allow the BCM21664 GIC to work.

Fixes: a5d0d4a7bab5 ("ARM: dts: bcm-mobile: Split out nodes used by both BCM21664 and BCM23550")
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
---
 arch/arm/boot/dts/broadcom/bcm2166x-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/broadcom/bcm2166x-common.dtsi b/arch/arm/boot/dts/broadcom/bcm2166x-common.dtsi
index 049e18b61ccd..87180b7fd695 100644
--- a/arch/arm/boot/dts/broadcom/bcm2166x-common.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm2166x-common.dtsi
@@ -135,7 +135,7 @@ bsc4: i2c@1c000 {
 	/* Apps bus */
 	apps: apps-bus@3e300000 {
 		compatible = "simple-bus";
-		ranges = <0 0x3e300000 0x01b77000>;
+		ranges = <0 0x3e300000 0x01c02000>;
 		#address-cells = <1>;
 		#size-cells = <1>;
 

---
base-commit: 44ccb92bc64a6f92666e69c7c30e5713758641e2
change-id: 20240820-bcm2166x-apps-bus-fix-0edcfbae8dcb

Best regards,
-- 
Artur Weber <aweber.kernel@gmail.com>

Re: [PATCH] ARM: dts: broadcom: bcm2166x-common: Increase apps bus size to fit BCM21664 GIC

Posted by Florian Fainelli 1 year, 5 months ago

From: Florian Fainelli <f.fainelli@gmail.com>

On Tue, 20 Aug 2024 16:38:14 +0200, Artur Weber <aweber.kernel@gmail.com> wrote:
> The BCM21664 GIC sits at a higher address than the apps bus currently
> allows. This is because the apps bus was inherited from the BCM23550
> DTSI, where the GIC sits at an earlier address in memory, and the DTSI
> wasn't updated to match.
> 
> Increase the size of the apps bus to allow the BCM21664 GIC to work.
> 
> Fixes: a5d0d4a7bab5 ("ARM: dts: bcm-mobile: Split out nodes used by both BCM21664 and BCM23550")
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian

Re: [PATCH] ARM: dts: broadcom: bcm2166x-common: Increase apps bus size to fit BCM21664 GIC

Posted by Florian Fainelli 1 year, 5 months ago

On 8/20/24 11:49, Florian Fainelli wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
> 
> On Tue, 20 Aug 2024 16:38:14 +0200, Artur Weber <aweber.kernel@gmail.com> wrote:
>> The BCM21664 GIC sits at a higher address than the apps bus currently
>> allows. This is because the apps bus was inherited from the BCM23550
>> DTSI, where the GIC sits at an earlier address in memory, and the DTSI
>> wasn't updated to match.
>>
>> Increase the size of the apps bus to allow the BCM21664 GIC to work.
>>
>> Fixes: a5d0d4a7bab5 ("ARM: dts: bcm-mobile: Split out nodes used by both BCM21664 and BCM23550")
>> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
>> ---
> 
> Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!

Since this was only a problem in linux-next, I just squashed your fixup 
within the original commit. Thanks!
-- 
Florian