drivers: fix some module autoloading

[PATCH -next 8/9] dmaengine: at_hdmac: fix module autoloading

Posted by Yuntao Liu 1 year, 5 months ago

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
based on the alias from platform_device_id table.

Signed-off-by: Yuntao Liu <liuyuntao12@huawei.com>
---
 drivers/dma/at_hdmac.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index 40052d1bd0b5..614c60b16ee5 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -1904,6 +1904,7 @@ static const struct platform_device_id atdma_devtypes[] = {
 		/* sentinel */
 	}
 };
+MODULE_DEVICE_TABLE(platform, atdma_devtypes);
 
 static inline const struct at_dma_platform_data * __init at_dma_get_driver_data(
 						struct platform_device *pdev)
-- 
2.34.1

Re: [PATCH -next 8/9] dmaengine: at_hdmac: fix module autoloading

Posted by Arnd Bergmann 1 year, 5 months ago

On Mon, Aug 19, 2024, at 13:38, Yuntao Liu wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from platform_device_id table.
>
> Signed-off-by: Yuntao Liu <liuyuntao12@huawei.com>

This table is again unused because at91 uses DT based
probing. Please just remove the table and the #ifdef/of_match_ptr()
around the of_device_id table.

     Arnd