drivers: fix some module autoloading

[PATCH -next 3/9] misc: atmel-ssc: fix module autoloading

Posted by Yuntao Liu 1 year, 5 months ago

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
based on the alias from platform_device_id table.

Signed-off-by: Yuntao Liu <liuyuntao12@huawei.com>
---
 drivers/misc/atmel-ssc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
index 6eac0f335915..e7a87183bfbb 100644
--- a/drivers/misc/atmel-ssc.c
+++ b/drivers/misc/atmel-ssc.c
@@ -110,6 +110,7 @@ static const struct platform_device_id atmel_ssc_devtypes[] = {
 		/* sentinel */
 	}
 };
+MODULE_DEVICE_TABLE(platform, atmel_ssc_devtypes);
 
 #ifdef CONFIG_OF
 static const struct of_device_id atmel_ssc_dt_ids[] = {
-- 
2.34.1

Re: [PATCH -next 3/9] misc: atmel-ssc: fix module autoloading

Posted by Arnd Bergmann 1 year, 5 months ago

On Mon, Aug 19, 2024, at 13:38, Yuntao Liu wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from platform_device_id table.
>
> Signed-off-by: Yuntao Liu <liuyuntao12@huawei.com>
> ---
>  drivers/misc/atmel-ssc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index 6eac0f335915..e7a87183bfbb 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -110,6 +110,7 @@ static const struct platform_device_id 
> atmel_ssc_devtypes[] = {
>  		/* sentinel */
>  	}
>  };
> +MODULE_DEVICE_TABLE(platform, atmel_ssc_devtypes);

I think this driver is autoloaded by the drivers using it,
so this entry is not needed. there is also an of_device_id
table that will load the driver based on the DT information. 

     Arnd