arm-cci: Fix refcount leak in cci_probe

[PATCH] arm-cci: Fix refcount leak in cci_probe

Posted by Ma Ke 1 year, 5 months ago

Add the missing of_node_put() to release the refcount incremented
by of_find_matching_node().

Cc: stable@vger.kernel.org
Fixes: f6b9e83ce05e ("arm-cci: Rearrange code for splitting PMU vs driver code")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
---
 drivers/bus/arm-cci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index b8184a903583..6be7b05b5ff1 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -548,6 +548,7 @@ static int cci_probe(void)
 	}
 	if (ret || !cci_ctrl_base) {
 		WARN(1, "unable to ioremap CCI ctrl\n");
+		of_node_put(np);
 		return -ENXIO;
 	}
 
-- 
2.25.1

Re: [PATCH] arm-cci: Fix refcount leak in cci_probe

Posted by Suzuki K Poulose 1 year, 5 months ago

On 19/08/2024 10:04, Ma Ke wrote:
> Add the missing of_node_put() to release the refcount incremented
> by of_find_matching_node().
> 
> Cc: stable@vger.kernel.org
> Fixes: f6b9e83ce05e ("arm-cci: Rearrange code for splitting PMU vs driver code")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
> ---
>   drivers/bus/arm-cci.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> index b8184a903583..6be7b05b5ff1 100644
> --- a/drivers/bus/arm-cci.c
> +++ b/drivers/bus/arm-cci.c
> @@ -548,6 +548,7 @@ static int cci_probe(void)
>   	}
>   	if (ret || !cci_ctrl_base) {
>   		WARN(1, "unable to ioremap CCI ctrl\n");
> +		of_node_put(np);
>   		return -ENXIO;
>   	}
>   

Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>