[PATCH 02/14] Input: samsung-keypad - do not set input device's parent explicitly

Dmitry Torokhov posted 14 patches 1 year, 5 months ago
[PATCH 02/14] Input: samsung-keypad - do not set input device's parent explicitly
Posted by Dmitry Torokhov 1 year, 5 months ago
The driver uses devm_input_allocate_device() to allocate instances of
input device, which sets the parent appropriately. Remove extraneous
assignment.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/keyboard/samsung-keypad.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c
index a5fac7de8b5d..46c0d0c900f6 100644
--- a/drivers/input/keyboard/samsung-keypad.c
+++ b/drivers/input/keyboard/samsung-keypad.c
@@ -383,7 +383,6 @@ static int samsung_keypad_probe(struct platform_device *pdev)
 
 	input_dev->name = pdev->name;
 	input_dev->id.bustype = BUS_HOST;
-	input_dev->dev.parent = &pdev->dev;
 
 	input_dev->open = samsung_keypad_open;
 	input_dev->close = samsung_keypad_close;
-- 
2.46.0.184.g6999bdac58-goog
Re: [PATCH 02/14] Input: samsung-keypad - do not set input device's parent explicitly
Posted by Krzysztof Kozlowski 1 year, 5 months ago
On Sun, Aug 18, 2024 at 09:57:59PM -0700, Dmitry Torokhov wrote:
> The driver uses devm_input_allocate_device() to allocate instances of
> input device, which sets the parent appropriately. Remove extraneous
> assignment.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof