dt-bindings: iio: st,stm32-adc: add top-level constraints

[PATCH] dt-bindings: iio: st,stm32-adc: add top-level constraints

Posted by Krzysztof Kozlowski 1 year, 5 months ago

Properties with variable number of items per each device are expected to
have widest constraints in top-level "properties:" block and further
customized (narrowed) in "if:then:".  Add missing top-level constraints
for clock-names.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
index ec34c48d4878..ef9dcc365eab 100644
--- a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
@@ -54,7 +54,9 @@ properties:
           It's not present on stm32f4.
           It's required on stm32h7 and stm32mp1.
 
-  clock-names: true
+  clock-names:
+    minItems: 1
+    maxItems: 2
 
   st,max-clk-rate-hz:
     description:
-- 
2.43.0

Re: [PATCH] dt-bindings: iio: st,stm32-adc: add top-level constraints

Posted by Conor Dooley 1 year, 5 months ago

On Sun, Aug 18, 2024 at 07:29:51PM +0200, Krzysztof Kozlowski wrote:
> Properties with variable number of items per each device are expected to
> have widest constraints in top-level "properties:" block and further
> customized (narrowed) in "if:then:".  Add missing top-level constraints
> for clock-names.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Acked-by: Conor Dooley <conor.dooley@microchip.com>

>  Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
> index ec34c48d4878..ef9dcc365eab 100644
> --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
> @@ -54,7 +54,9 @@ properties:
>            It's not present on stm32f4.
>            It's required on stm32h7 and stm32mp1.
>  
> -  clock-names: true
> +  clock-names:
> +    minItems: 1
> +    maxItems: 2
>  
>    st,max-clk-rate-hz:
>      description:
> -- 
> 2.43.0
>

Re: [PATCH] dt-bindings: iio: st,stm32-adc: add top-level constraints

Posted by Jonathan Cameron 1 year, 5 months ago

On Mon, 19 Aug 2024 18:13:22 +0100
Conor Dooley <conor@kernel.org> wrote:

> On Sun, Aug 18, 2024 at 07:29:51PM +0200, Krzysztof Kozlowski wrote:
> > Properties with variable number of items per each device are expected to
> > have widest constraints in top-level "properties:" block and further
> > customized (narrowed) in "if:then:".  Add missing top-level constraints
> > for clock-names.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---  
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Applied,

Thanks,

Jonathan

> 
> >  Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
> > index ec34c48d4878..ef9dcc365eab 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
> > @@ -54,7 +54,9 @@ properties:
> >            It's not present on stm32f4.
> >            It's required on stm32h7 and stm32mp1.
> >  
> > -  clock-names: true
> > +  clock-names:
> > +    minItems: 1
> > +    maxItems: 2
> >  
> >    st,max-clk-rate-hz:
> >      description:
> > -- 
> > 2.43.0
> >

Re: [PATCH] dt-bindings: iio: st,stm32-adc: add top-level constraints

Posted by Fabrice Gasnier 1 year, 5 months ago

On 8/18/24 19:29, Krzysztof Kozlowski wrote:
> Properties with variable number of items per each device are expected to
> have widest constraints in top-level "properties:" block and further
> customized (narrowed) in "if:then:".  Add missing top-level constraints
> for clock-names.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
> index ec34c48d4878..ef9dcc365eab 100644
> --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml
> @@ -54,7 +54,9 @@ properties:
>            It's not present on stm32f4.
>            It's required on stm32h7 and stm32mp1.
>  
> -  clock-names: true
> +  clock-names:
> +    minItems: 1
> +    maxItems: 2
>  
>    st,max-clk-rate-hz:
>      description:

Hi Krzysztof,

You can add my:
Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>

Best Regards,
Thanks,
Fabrice