[PATCH -next] mptcp: Remove unused declaration mptcp_sockopt_sync()

Yue Haibing posted 1 patch 1 year, 5 months ago
There is a newer version of this series
net/mptcp/protocol.h | 1 -
1 file changed, 1 deletion(-)
[PATCH -next] mptcp: Remove unused declaration mptcp_sockopt_sync()
Posted by Yue Haibing 1 year, 5 months ago
Commit a1ab24e5fc4a ("mptcp: consolidate sockopt synchronization")
removed the implementation but leave declaration.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 net/mptcp/protocol.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
index 60c6b073d65f..08387140a646 100644
--- a/net/mptcp/protocol.h
+++ b/net/mptcp/protocol.h
@@ -1154,7 +1154,6 @@ static inline void mptcp_pm_close_subflow(struct mptcp_sock *msk)
 	spin_unlock_bh(&msk->pm.lock);
 }
 
-void mptcp_sockopt_sync(struct mptcp_sock *msk, struct sock *ssk);
 void mptcp_sockopt_sync_locked(struct mptcp_sock *msk, struct sock *ssk);
 
 static inline struct mptcp_ext *mptcp_get_ext(const struct sk_buff *skb)
-- 
2.34.1
Re: [PATCH -next] mptcp: Remove unused declaration mptcp_sockopt_sync()
Posted by Simon Horman 1 year, 5 months ago
On Fri, Aug 16, 2024 at 06:04:04PM +0800, Yue Haibing wrote:
> Commit a1ab24e5fc4a ("mptcp: consolidate sockopt synchronization")
> removed the implementation but leave declaration.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Reviewed-by: Simon Horman <horms@kernel.org>
Re: [PATCH -next] mptcp: Remove unused declaration mptcp_sockopt_sync()
Posted by Matthieu Baerts 1 year, 5 months ago
Hi Yue Haibing,

On 16/08/2024 12:04, Yue Haibing wrote:
> Commit a1ab24e5fc4a ("mptcp: consolidate sockopt synchronization")
> removed the implementation but leave declaration.

Good catch, it looks good to me:

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

@Netdev maintainers: it can be applied in net-next, or in -net if you
prefer.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.