arm64: tegra: add wp-gpio to P2957 board

[PATCH 0/2] arm64: tegra: add wp-gpio to P2957 board

Posted by Diogo Ivo 1 year, 5 months ago

Define the wp-gpio for the P2597 board.

For this, patch 1 fixes the assignment of the vmmc supply's gpio that
was incorrectly assigned to the wp-gpio of the external slot.

Patch 2 adds the definition of the wp-gpio.

Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
---
Diogo Ivo (2):
      arm64: tegra: Fix gpio for P2597 vmmc regulator
      arm64: tegra: Add wp-gpio for P2597's external card slot

 arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
---
base-commit: 1fb918967b56df3262ee984175816f0acb310501
change-id: 20240815-tx1_sdmmc-311e4802c843

Best regards,
-- 
Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>

Re: [PATCH 0/2] arm64: tegra: add wp-gpio to P2957 board

Posted by Thierry Reding 1 year, 5 months ago

From: Thierry Reding <treding@nvidia.com>


On Thu, 15 Aug 2024 16:50:38 +0100, Diogo Ivo wrote:
> Define the wp-gpio for the P2597 board.
> 
> For this, patch 1 fixes the assignment of the vmmc supply's gpio that
> was incorrectly assigned to the wp-gpio of the external slot.
> 
> Patch 2 adds the definition of the wp-gpio.
> 
> [...]

Applied, thanks!

[1/2] arm64: tegra: Fix gpio for P2597 vmmc regulator
      commit: 46a26db82748a9434fae662738ff80e350b179ee
[2/2] arm64: tegra: Add wp-gpio for P2597's external card slot
      commit: ebe899563a83c9bb578248eb4a4d56414275d9fa

Best regards,
-- 
Thierry Reding <treding@nvidia.com>

Re: [PATCH 0/2] arm64: tegra: add wp-gpio to P2957 board

Posted by Diogo Ivo 1 year, 5 months ago

Hi Thierry,

On Thu, Aug 29, 2024 at 05:31:23PM GMT, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> 
> On Thu, 15 Aug 2024 16:50:38 +0100, Diogo Ivo wrote:
> > Define the wp-gpio for the P2597 board.
> > 
> > For this, patch 1 fixes the assignment of the vmmc supply's gpio that
> > was incorrectly assigned to the wp-gpio of the external slot.
> > 
> > Patch 2 adds the definition of the wp-gpio.
> > 
> > [...]
> 
> Applied, thanks!

Thanks for picking up the patches! In my testing around SD/MMC I found that
currently UHS-I cards are broken on the P2597. When trying to use one
the system shows somewhat erratic behaviour where it sometimes hangs and
some other times it simply fails to read from the SD card. I have
tracked the point at which this happens to be around
tegra_sdhci_pad_autocalib() when switching to SDR104 mode, where there
is the possibility of using specific offsets for this mode. Currently
there are no values specified in tegra210.dtsi, so the 1.8V values are
being used. However, when I tried specifying them as

	nvidia,pad-autocal-pull-up-offset-sdr104 = <0>;
	nvidia,pad-autocal-pull-down-offset-sdr104 = <0>;

in the DT things started working fine. I did not send a patch with these
values since I could not find what they should be on the X1 TRM, are
there any recommended values for these parameters so that we can have
this fixed?

Diogo

Re: [PATCH 0/2] arm64: tegra: add wp-gpio to P2957 board

Posted by Thierry Reding 1 year, 4 months ago

On Fri, Aug 30, 2024 at 11:20:45AM GMT, Diogo Ivo wrote:
> Hi Thierry,
> 
> On Thu, Aug 29, 2024 at 05:31:23PM GMT, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > 
> > On Thu, 15 Aug 2024 16:50:38 +0100, Diogo Ivo wrote:
> > > Define the wp-gpio for the P2597 board.
> > > 
> > > For this, patch 1 fixes the assignment of the vmmc supply's gpio that
> > > was incorrectly assigned to the wp-gpio of the external slot.
> > > 
> > > Patch 2 adds the definition of the wp-gpio.
> > > 
> > > [...]
> > 
> > Applied, thanks!
> 
> Thanks for picking up the patches! In my testing around SD/MMC I found that
> currently UHS-I cards are broken on the P2597. When trying to use one
> the system shows somewhat erratic behaviour where it sometimes hangs and
> some other times it simply fails to read from the SD card. I have
> tracked the point at which this happens to be around
> tegra_sdhci_pad_autocalib() when switching to SDR104 mode, where there
> is the possibility of using specific offsets for this mode. Currently
> there are no values specified in tegra210.dtsi, so the 1.8V values are
> being used. However, when I tried specifying them as
> 
> 	nvidia,pad-autocal-pull-up-offset-sdr104 = <0>;
> 	nvidia,pad-autocal-pull-down-offset-sdr104 = <0>;
> 
> in the DT things started working fine. I did not send a patch with these
> values since I could not find what they should be on the X1 TRM, are
> there any recommended values for these parameters so that we can have
> this fixed?

Sorry for the late reply. Looking at the Tegra X1 TRM, section 32.7
"Programming Guidelines" (starting on page 2473), I see there are a
few subsections called "Run Auto-Calibration", which list recommended
values for the auto-calibration pull-down/-up offsets, depending on the
signaling mode (3.3V vs. 1.8V).

They are:

          3.3V    1.8V
          PD  PU  PD  PU
  SDMMC1  125  0  123 123
  SDMMC2  n/a n/a  5   5
  SDMMC3  125  0  123 123
  SDMMC4  n/a n/a  5   5

Now these aren't the ones you've been using, but it is what we have in
the Tegra210 DTSI file. Interestingly the TRM doesn't make those
specific to the mode (such as SDR104 and HS400 like the DT bindings
suggest they should be).

Also interestingly, on Tegra234 the recommended values in the TRM for
these fields is 0 (like you're using), irrespective of mode.

It's not entirely clear to me why we need these offsets during auto-
calibration, so 0 makes as much sense as any other value. The
documentation isn't very clear on what these values do, either. So I'd
be inclined to accept a patch such as yours based purely on the fact
that it makes things work.

Thierry

Re: [PATCH 0/2] arm64: tegra: add wp-gpio to P2957 board

Posted by Diogo Ivo 1 year, 4 months ago

Hi Thierry,

Gentle ping on this topic.

Thanks,
Diogo

Re: [PATCH 0/2] arm64: tegra: add wp-gpio to P2957 board

Posted by Tomasz Maciej Nowak 1 year, 5 months ago

W dniu 15.08.2024 o 17:50, Diogo Ivo pisze:
> Define the wp-gpio for the P2597 board.
> 
> For this, patch 1 fixes the assignment of the vmmc supply's gpio that
> was incorrectly assigned to the wp-gpio of the external slot.
> 
> Patch 2 adds the definition of the wp-gpio.
> 
> Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
> ---
> Diogo Ivo (2):
>       arm64: tegra: Fix gpio for P2597 vmmc regulator
>       arm64: tegra: Add wp-gpio for P2597's external card slot

Hi,
for both patches
Tested-by: Tomasz Maciej Nowak <tmn505@gmail.com>

PS
I case You wish to save some digging for other features I enabled BT+WiFi, PWM-FAN
and power sensors in this tree: https://github.com/tmn505/linux/tree/jetson-tx1
For passing MAC addresses for BT+WiFi from cboot provided dtb check this U-Boot
tree: https://github.com/tmn505/u-boot/tree/jetson-tx1

> 
>  arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> ---
> base-commit: 1fb918967b56df3262ee984175816f0acb310501
> change-id: 20240815-tx1_sdmmc-311e4802c843
> 
> Best regards,

Regards

-- 
TMN

Re: [PATCH 0/2] arm64: tegra: add wp-gpio to P2957 board

Posted by Diogo Ivo 1 year, 5 months ago

On Tue, Aug 20, 2024 at 06:32:44PM GMT, Tomasz Maciej Nowak wrote:
> 
> W dniu 15.08.2024 o 17:50, Diogo Ivo pisze:
> > Define the wp-gpio for the P2597 board.
> > 
> > For this, patch 1 fixes the assignment of the vmmc supply's gpio that
> > was incorrectly assigned to the wp-gpio of the external slot.
> > 
> > Patch 2 adds the definition of the wp-gpio.
> > 
> > Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
> > ---
> > Diogo Ivo (2):
> >       arm64: tegra: Fix gpio for P2597 vmmc regulator
> >       arm64: tegra: Add wp-gpio for P2597's external card slot
> 
> Hi,
> for both patches
> Tested-by: Tomasz Maciej Nowak <tmn505@gmail.com>
> 
> PS
> I case You wish to save some digging for other features I enabled BT+WiFi, PWM-FAN
> and power sensors in this tree: https://github.com/tmn505/linux/tree/jetson-tx1
> For passing MAC addresses for BT+WiFi from cboot provided dtb check this U-Boot
> tree: https://github.com/tmn505/u-boot/tree/jetson-tx1

Thanks for testing! Are you planning on sending your patches upstream?
It would be nice to have those features enabled, and I can add my
Tested-by once I test them.

Diogo

Re: [PATCH 0/2] arm64: tegra: add wp-gpio to P2957 board

Posted by Tomasz Maciej Nowak 1 year, 5 months ago

W dniu 21.08.2024 o 12:34, Diogo Ivo pisze:
> On Tue, Aug 20, 2024 at 06:32:44PM GMT, Tomasz Maciej Nowak wrote:
>>
>> W dniu 15.08.2024 o 17:50, Diogo Ivo pisze:
>>> Define the wp-gpio for the P2597 board.
>>>
>>> For this, patch 1 fixes the assignment of the vmmc supply's gpio that
>>> was incorrectly assigned to the wp-gpio of the external slot.
>>>
>>> Patch 2 adds the definition of the wp-gpio.
>>>
>>> Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
>>> ---
>>> Diogo Ivo (2):
>>>       arm64: tegra: Fix gpio for P2597 vmmc regulator
>>>       arm64: tegra: Add wp-gpio for P2597's external card slot
>>
>> Hi,
>> for both patches
>> Tested-by: Tomasz Maciej Nowak <tmn505@gmail.com>
>>
>> PS
>> I case You wish to save some digging for other features I enabled BT+WiFi, PWM-FAN
>> and power sensors in this tree: https://github.com/tmn505/linux/tree/jetson-tx1
>> For passing MAC addresses for BT+WiFi from cboot provided dtb check this U-Boot
>> tree: https://github.com/tmn505/u-boot/tree/jetson-tx1
> 
> Thanks for testing! Are you planning on sending your patches upstream?
> It would be nice to have those features enabled, and I can add my
> Tested-by once I test them.

As Nicolas also requested it I sent the patches except the PWM-FAN ones, since
this will probably need enhancement of tegra pwm driver to handle inverted signal.
Also the GPU enable is left out, as pointed by Nicolas bootloader overwrites the
status of it to "okay".

> 
> Diogo

Regards
-- 
TMN