Checkpatch.pl reports some ERRORS related
to coding style (spacing and indentation).
So clean up : checkpatch.pl --fix-inplace
Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
---
Split the bloated patch into small patches on topics
based on comments:
https://lore.kernel.org/linux-arm-kernel/89f51615-0dee-4ab0-ab72-e3c057fee1e7@tuxon.dev/
---
arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts | 2 +-
arch/arm/boot/dts/microchip/at91-sama5d27_som1_ek.dts | 8 ++++----
arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts | 8 ++++----
arch/arm/boot/dts/microchip/at91sam9263ek.dts | 2 +-
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts b/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts
index 04cb7bee937d..1279dfb38300 100644
--- a/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts
+++ b/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts
@@ -7,7 +7,7 @@
* HCE Engineering
*
* Derived from at91sam9g35ek.dts by:
- * Copyright (C) 2012 Atmel,
+ * Copyright (C) 2012 Atmel,
* 2012 Nicolas Ferre <nicolas.ferre@atmel.com>
*/
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/microchip/at91-sama5d27_som1_ek.dts
index f3ffb8f01d8a..eab7efe2d5a3 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d27_som1_ek.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d27_som1_ek.dts
@@ -258,10 +258,10 @@ pinctrl_i2c1_default: i2c1_default {
};
pinctrl_i2c1_gpio: i2c1_gpio {
- pinmux = <PIN_PD4__GPIO>,
- <PIN_PD5__GPIO>;
- bias-disable;
- };
+ pinmux = <PIN_PD4__GPIO>,
+ <PIN_PD5__GPIO>;
+ bias-disable;
+ };
pinctrl_isc_base: isc_base {
diff --git a/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts b/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts
index 999adeca6f33..54f5672285e4 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts
@@ -407,10 +407,10 @@ pinctrl_i2c1_default: i2c1_default {
};
pinctrl_i2c1_gpio: i2c1_gpio {
- pinmux = <PIN_PD19__GPIO>,
- <PIN_PD20__GPIO>;
- bias-disable;
- };
+ pinmux = <PIN_PD19__GPIO>,
+ <PIN_PD20__GPIO>;
+ bias-disable;
+ };
pinctrl_key_gpio_default: key_gpio_default {
pinmux = <PIN_PD0__GPIO>;
diff --git a/arch/arm/boot/dts/microchip/at91sam9263ek.dts b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
index ce8baff6a9f4..d872d9652194 100644
--- a/arch/arm/boot/dts/microchip/at91sam9263ek.dts
+++ b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
@@ -86,7 +86,7 @@ pinctrl@fffff200 {
mmc0 {
pinctrl_board_mmc0: mmc0-board {
atmel,pins =
- <AT91_PIOE 18 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH /* PE18 gpio CD pin pull up and deglitch */
+ <AT91_PIOE 18 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH /* PE18 gpio CD pin pull up and deglitch */
AT91_PIOE 19 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP>; /* PE19 gpio WP pin pull up */
};
};
--
2.34.1On 14/08/2024 14:26, Andrei Simion wrote: > Checkpatch.pl reports some ERRORS related > to coding style (spacing and indentation). > So clean up : checkpatch.pl --fix-inplace Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 Please be specific what are you changing. > > Signed-off-by: Andrei Simion <andrei.simion@microchip.com> > --- > Split the bloated patch into small patches on topics > based on comments: > https://lore.kernel.org/linux-arm-kernel/89f51615-0dee-4ab0-ab72-e3c057fee1e7@tuxon.dev/ > --- > arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts | 2 +- > arch/arm/boot/dts/microchip/at91-sama5d27_som1_ek.dts | 8 ++++---- > arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts | 8 ++++---- > arch/arm/boot/dts/microchip/at91sam9263ek.dts | 2 +- > 4 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts b/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts > index 04cb7bee937d..1279dfb38300 100644 > --- a/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts > +++ b/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts > @@ -7,7 +7,7 @@ > * HCE Engineering > * > * Derived from at91sam9g35ek.dts by: > - * Copyright (C) 2012 Atmel, > + * Copyright (C) 2012 Atmel, Not sure what you are fixing here, but unnecessary tab was here before and still exists... > * 2012 Nicolas Ferre <nicolas.ferre@atmel.com> > */ > Best regards, Krzysztof
On 14.08.2024 16:20, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 14/08/2024 14:26, Andrei Simion wrote: >> Checkpatch.pl reports some ERRORS related >> to coding style (spacing and indentation). >> So clean up : checkpatch.pl --fix-inplace > > Please wrap commit message according to Linux coding style / submission > process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > checkpatch.pl has no lower limit for the number of characters. If you want 75 cols. OK for me. > Please be specific what are you changing. > It was a bigger/bloated patch and I split it into smaller ones based on what ARM/Microchip (AT91) Maintainer said. > >> >> Signed-off-by: Andrei Simion <andrei.simion@microchip.com> >> --- >> Split the bloated patch into small patches on topics >> based on comments: >> https://lore.kernel.org/linux-arm-kernel/89f51615-0dee-4ab0-ab72-e3c057fee1e7@tuxon.dev/ >> --- >> arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts | 2 +- >> arch/arm/boot/dts/microchip/at91-sama5d27_som1_ek.dts | 8 ++++---- >> arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts | 8 ++++---- >> arch/arm/boot/dts/microchip/at91sam9263ek.dts | 2 +- >> 4 files changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts b/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts >> index 04cb7bee937d..1279dfb38300 100644 >> --- a/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts >> +++ b/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts >> @@ -7,7 +7,7 @@ >> * HCE Engineering >> * >> * Derived from at91sam9g35ek.dts by: >> - * Copyright (C) 2012 Atmel, >> + * Copyright (C) 2012 Atmel, > > Not sure what you are fixing here, but unnecessary tab was here before > and still exists... > WARNING: please, no space before tabs #10: FILE: arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts:10: + * ^ICopyright (C) 2012 Atmel,$ after this patch : this warning disappears. >> * 2012 Nicolas Ferre <nicolas.ferre@atmel.com> >> */ >> > > Best regards, > Krzysztof > BR, Andrei Simion
On 14/08/2024 15:32, Andrei.Simion@microchip.com wrote: > On 14.08.2024 16:20, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 14/08/2024 14:26, Andrei Simion wrote: >>> Checkpatch.pl reports some ERRORS related >>> to coding style (spacing and indentation). >>> So clean up : checkpatch.pl --fix-inplace >> >> Please wrap commit message according to Linux coding style / submission >> process (neither too early nor over the limit): >> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 >> > > checkpatch.pl has no lower limit for the number of characters. > If you want 75 cols. OK for me. That has nothing to do with checkpatch but with readability. Please read submitting patches document. > > >> Please be specific what are you changing. >> > > It was a bigger/bloated patch and I split it into smaller > ones based on what ARM/Microchip (AT91) Maintainer said. I meant, what the commit is doing. > >> >>> >>> Signed-off-by: Andrei Simion <andrei.simion@microchip.com> >>> --- >>> Split the bloated patch into small patches on topics >>> based on comments: >>> https://lore.kernel.org/linux-arm-kernel/89f51615-0dee-4ab0-ab72-e3c057fee1e7@tuxon.dev/ >>> --- >>> arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts | 2 +- >>> arch/arm/boot/dts/microchip/at91-sama5d27_som1_ek.dts | 8 ++++---- >>> arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts | 8 ++++---- >>> arch/arm/boot/dts/microchip/at91sam9263ek.dts | 2 +- >>> 4 files changed, 10 insertions(+), 10 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts b/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts >>> index 04cb7bee937d..1279dfb38300 100644 >>> --- a/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts >>> +++ b/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts >>> @@ -7,7 +7,7 @@ >>> * HCE Engineering >>> * >>> * Derived from at91sam9g35ek.dts by: >>> - * Copyright (C) 2012 Atmel, >>> + * Copyright (C) 2012 Atmel, >> >> Not sure what you are fixing here, but unnecessary tab was here before >> and still exists... >> > > WARNING: please, no space before tabs > #10: FILE: arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts:10: > + * ^ICopyright (C) 2012 Atmel,$ > > after this patch : this warning disappears. Yeah, but code is not correct, is it? Do not run checkpatch --inplace and commit the changes. Who gave you such idea? Instead fix the actual issue in a correct way. Best regards, Krzysztof
On 14.08.2024 16:57, Krzysztof Kozlowski wrote: >> WARNING: please, no space before tabs >> #10: FILE: arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts:10: >> + * ^ICopyright (C) 2012 Atmel,$ >> >> after this patch : this warning disappears. > Yeah, but code is not correct, is it? > > Do not run checkpatch --inplace and commit the changes. Who gave you > such idea? > No one gave me this idea. > Instead fix the actual issue in a correct way. > > OK. I understand. > > Best regards, > Krzysztof Best Regards, Andrei Simion
© 2016 - 2026 Red Hat, Inc.