ALSA: hda: tas2563: mark const variables as __maybe_unused

[PATCH v1] ALSA: hda: tas2563: mark const variables as __maybe_unused

Posted by Shenghao Ding 1 year, 5 months ago

From: Baojun Xu <baojun.xu@ti.com>

An earlier patch changed the DECLARE_TLV_DB_SCALE declaration, but
now there are additional static const variables that cause
the same build warnings:

In file included from sound/pci/hda/tas2781_hda_i2c.c:23:
include/sound/tas2563-tlv.h:21:28: error: 'tas2563_dvc_table' defined but not used [-Werror=unused-const-variable=]
   21 | static const unsigned char tas2563_dvc_table[][4] = {
      |                            ^~~~~~~~~~~~~~~~~                                 ^~~~~~~~~~~~~~~

Mark it as unused as well.

Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>

---
v1:
---
 include/sound/tas2563-tlv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/sound/tas2563-tlv.h b/include/sound/tas2563-tlv.h
index faa3e194f73b..bb269b21f460 100644
--- a/include/sound/tas2563-tlv.h
+++ b/include/sound/tas2563-tlv.h
@@ -18,7 +18,7 @@
 static const __maybe_unused DECLARE_TLV_DB_SCALE(tas2563_dvc_tlv, -12150, 50, 1);
 
 /* pow(10, db/20) * pow(2,30) */
-static const unsigned char tas2563_dvc_table[][4] = {
+static const __maybe_unused unsigned char tas2563_dvc_table[][4] = {
 	{ 0X00, 0X00, 0X00, 0X00 }, /* -121.5db */
 	{ 0X00, 0X00, 0X03, 0XBC }, /* -121.0db */
 	{ 0X00, 0X00, 0X03, 0XF5 }, /* -120.5db */
-- 
2.43.0

Re: [PATCH v1] ALSA: hda: tas2563: mark const variables as __maybe_unused

Posted by Takashi Iwai 1 year, 5 months ago

On Wed, 14 Aug 2024 14:20:42 +0200,
Shenghao Ding wrote:
> 
> From: Baojun Xu <baojun.xu@ti.com>
> 
> An earlier patch changed the DECLARE_TLV_DB_SCALE declaration, but
> now there are additional static const variables that cause
> the same build warnings:
> 
> In file included from sound/pci/hda/tas2781_hda_i2c.c:23:
> include/sound/tas2563-tlv.h:21:28: error: 'tas2563_dvc_table' defined but not used [-Werror=unused-const-variable=]
>    21 | static const unsigned char tas2563_dvc_table[][4] = {
>       |                            ^~~~~~~~~~~~~~~~~                                 ^~~~~~~~~~~~~~~
> 
> Mark it as unused as well.
> 
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>

This isn't found in my tree, maybe found only in Mark's tree?

In anyway, you should put Fixes tag.


Takashi

> 
> ---
> v1:
> ---
>  include/sound/tas2563-tlv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/sound/tas2563-tlv.h b/include/sound/tas2563-tlv.h
> index faa3e194f73b..bb269b21f460 100644
> --- a/include/sound/tas2563-tlv.h
> +++ b/include/sound/tas2563-tlv.h
> @@ -18,7 +18,7 @@
>  static const __maybe_unused DECLARE_TLV_DB_SCALE(tas2563_dvc_tlv, -12150, 50, 1);
>  
>  /* pow(10, db/20) * pow(2,30) */
> -static const unsigned char tas2563_dvc_table[][4] = {
> +static const __maybe_unused unsigned char tas2563_dvc_table[][4] = {
>  	{ 0X00, 0X00, 0X00, 0X00 }, /* -121.5db */
>  	{ 0X00, 0X00, 0X03, 0XBC }, /* -121.0db */
>  	{ 0X00, 0X00, 0X03, 0XF5 }, /* -120.5db */
> -- 
> 2.43.0
>