[PATCH] cdc-acm: Add DISABLE_ECHO quirk for GE HealthCare UI Controller

Ian Ray posted 1 patch 1 year, 5 months ago
drivers/usb/class/cdc-acm.c | 3 +++
1 file changed, 3 insertions(+)
[PATCH] cdc-acm: Add DISABLE_ECHO quirk for GE HealthCare UI Controller
Posted by Ian Ray 1 year, 5 months ago
USB_DEVICE(0x1901, 0x0006) may send data before cdc_acm is ready, which
may be misinterpreted in the default N_TTY line discipline.

Signed-off-by: Ian Ray <ian.ray@gehealthcare.com>
---
 drivers/usb/class/cdc-acm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 0e7439dba8fe..0c1b69d944ca 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1761,6 +1761,9 @@ static const struct usb_device_id acm_ids[] = {
 	{ USB_DEVICE(0x11ca, 0x0201), /* VeriFone Mx870 Gadget Serial */
 	.driver_info = SINGLE_RX_URB,
 	},
+	{ USB_DEVICE(0x1901, 0x0006), /* GE Healthcare Patient Monitor UI Controller */
+	.driver_info = DISABLE_ECHO, /* DISABLE ECHO in termios flag */
+	},
 	{ USB_DEVICE(0x1965, 0x0018), /* Uniden UBC125XLT */
 	.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
 	},
-- 
2.39.2
Re: [PATCH] cdc-acm: Add DISABLE_ECHO quirk for GE HealthCare UI Controller
Posted by Oliver Neukum 1 year, 5 months ago

On 14.08.24 09:29, Ian Ray wrote:
> USB_DEVICE(0x1901, 0x0006) may send data before cdc_acm is ready, which
> may be misinterpreted in the default N_TTY line discipline.
> 
> Signed-off-by: Ian Ray <ian.ray@gehealthcare.com>
Acked-by: Oliver Neuku <oneukum@suse.com>