lockdown: Make lockdown_lsmid static

[PATCH -next] lockdown: Make lockdown_lsmid static

Posted by Yue Haibing 1 year, 5 months ago

Fix sparse warning:

security/lockdown/lockdown.c:79:21: warning:
 symbol 'lockdown_lsmid' was not declared. Should it be static?

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 security/lockdown/lockdown.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/lockdown/lockdown.c b/security/lockdown/lockdown.c
index cd84d8ea1dfb..f2bdbd55aa2b 100644
--- a/security/lockdown/lockdown.c
+++ b/security/lockdown/lockdown.c
@@ -76,7 +76,7 @@ static struct security_hook_list lockdown_hooks[] __ro_after_init = {
 	LSM_HOOK_INIT(locked_down, lockdown_is_locked_down),
 };
 
-const struct lsm_id lockdown_lsmid = {
+static const struct lsm_id lockdown_lsmid = {
 	.name = "lockdown",
 	.id = LSM_ID_LOCKDOWN,
 };
-- 
2.34.1

Re: [PATCH] lockdown: Make lockdown_lsmid static

Posted by Paul Moore 1 year, 5 months ago

On Aug 13, 2024 Yue Haibing <yuehaibing@huawei.com> wrote:
> 
> Fix sparse warning:
> 
> security/lockdown/lockdown.c:79:21: warning:
>  symbol 'lockdown_lsmid' was not declared. Should it be static?
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> Reviewed-by: Kees Cook <kees@kernel.org>
> ---
>  security/lockdown/lockdown.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Merged into lsm/dev, thanks!

--
paul-moore.com

Re: [PATCH -next] lockdown: Make lockdown_lsmid static

Posted by Kees Cook 1 year, 5 months ago

On Wed, Aug 14, 2024 at 11:30:04AM +0800, Yue Haibing wrote:
> Fix sparse warning:
> 
> security/lockdown/lockdown.c:79:21: warning:
>  symbol 'lockdown_lsmid' was not declared. Should it be static?
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Reviewed-by: Kees Cook <kees@kernel.org>

-- 
Kees Cook