usb: bdc: fix module autoloading

[PATCH -next] usb: bdc: fix module autoloading

Posted by Liao Chen 1 year, 5 months ago

Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
based on the alias from of_device_id table.

Signed-off-by: Liao Chen <liaochen4@huawei.com>
---
 drivers/usb/gadget/udc/bdc/bdc_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
index 35a652807fca..5149e2b7f050 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_core.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
@@ -639,6 +639,7 @@ static const struct of_device_id bdc_of_match[] = {
 	{ .compatible = "brcm,bdc" },
 	{ /* sentinel */ }
 };
+MODULE_DEVICE_TABLE(of, bdc_of_match);
 
 static struct platform_driver bdc_driver = {
 	.driver		= {
-- 
2.34.1

Re: [PATCH -next] usb: bdc: fix module autoloading

Posted by Florian Fainelli 1 year, 5 months ago


On 8/13/2024 8:04 PM, 'Liao Chen' via BCM-KERNEL-FEEDBACK-LIST,PDL wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table.
> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>

Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>


Thanks!
-- 
Florian

Re: [PATCH -next] usb: bdc: fix module autoloading

Posted by Greg KH 1 year, 5 months ago

On Wed, Aug 14, 2024 at 03:04:43AM +0000, Liao Chen wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table.
> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>
> ---
>  drivers/usb/gadget/udc/bdc/bdc_core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
> index 35a652807fca..5149e2b7f050 100644
> --- a/drivers/usb/gadget/udc/bdc/bdc_core.c
> +++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
> @@ -639,6 +639,7 @@ static const struct of_device_id bdc_of_match[] = {
>  	{ .compatible = "brcm,bdc" },
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, bdc_of_match);
>  
>  static struct platform_driver bdc_driver = {
>  	.driver		= {
> -- 
> 2.34.1
> 
> 

What commit id does this fix?

Re: [PATCH -next] usb: bdc: fix module autoloading

Posted by liaochen (A) 1 year, 5 months ago

On 2024/8/14 12:36, Greg KH wrote:
> On Wed, Aug 14, 2024 at 03:04:43AM +0000, Liao Chen wrote:
>> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
>> based on the alias from of_device_id table.
>>
>> Signed-off-by: Liao Chen <liaochen4@huawei.com>
>> ---
>>   drivers/usb/gadget/udc/bdc/bdc_core.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
>> index 35a652807fca..5149e2b7f050 100644
>> --- a/drivers/usb/gadget/udc/bdc/bdc_core.c
>> +++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
>> @@ -639,6 +639,7 @@ static const struct of_device_id bdc_of_match[] = {
>>   	{ .compatible = "brcm,bdc" },
>>   	{ /* sentinel */ }
>>   };
>> +MODULE_DEVICE_TABLE(of, bdc_of_match);
>>   
>>   static struct platform_driver bdc_driver = {
>>   	.driver		= {
>> -- 
>> 2.34.1
>>
>>
> 
> What commit id does this fix?
Hi, this patch fixes commit 8ac1685bf911f70aea6de67b3db5674c3ea112f1 
("usb: bdc: hook a quick Device Tree compatible string"), which allows 
bdc device probing.

Thanks,
Chen