power: sequencing: request the WLAN enable GPIO as-is

[PATCH] power: sequencing: request the WLAN enable GPIO as-is

Posted by Bartosz Golaszewski 1 year, 5 months ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

If the WCN module is powered up before linux boots and the ath11k driver
probes at the same time as the power sequencing driver, we may end up
driving the wlan-enable GPIO low in the latter, breaking the start-up of
the WLAN module. Request the wlan-enable GPIO as-is so that if the WLAN
module is already starting/started, we leave it alone.

Fixes: 2f1630f437df ("power: pwrseq: add a driver for the PMU module on the QCom WCN chipsets")
Reported-by: Stephan Gerhold <stephan.gerhold@linaro.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/power/sequencing/pwrseq-qcom-wcn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/sequencing/pwrseq-qcom-wcn.c b/drivers/power/sequencing/pwrseq-qcom-wcn.c
index 42dacfda745e..d786cbf1b2cd 100644
--- a/drivers/power/sequencing/pwrseq-qcom-wcn.c
+++ b/drivers/power/sequencing/pwrseq-qcom-wcn.c
@@ -283,7 +283,7 @@ static int pwrseq_qcom_wcn_probe(struct platform_device *pdev)
 				     "Failed to get the Bluetooth enable GPIO\n");
 
 	ctx->wlan_gpio = devm_gpiod_get_optional(dev, "wlan-enable",
-						 GPIOD_OUT_LOW);
+						 GPIOD_ASIS);
 	if (IS_ERR(ctx->wlan_gpio))
 		return dev_err_probe(dev, PTR_ERR(ctx->wlan_gpio),
 				     "Failed to get the WLAN enable GPIO\n");
-- 
2.43.0

Re: [PATCH] power: sequencing: request the WLAN enable GPIO as-is

Posted by Bartosz Golaszewski 1 year, 5 months ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Tue, 13 Aug 2024 21:07:50 +0200, Bartosz Golaszewski wrote:
> If the WCN module is powered up before linux boots and the ath11k driver
> probes at the same time as the power sequencing driver, we may end up
> driving the wlan-enable GPIO low in the latter, breaking the start-up of
> the WLAN module. Request the wlan-enable GPIO as-is so that if the WLAN
> module is already starting/started, we leave it alone.
> 
> 
> [...]

Applied, thanks!

[1/1] power: sequencing: request the WLAN enable GPIO as-is
      https://git.kernel.org/brgl/linux/c/a9aaf1ff88a8cb99a1335c9eb76de637f0cf8c10

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>