[v1] dt-bindings: bluetooth: bring the HW description closer to reality for wcn6855

[PATCH] dt-bindings: bluetooth: bring the HW description closer to reality for wcn6855

Posted by Bartosz Golaszewski 1 year, 5 months ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Describe the inputs from the PMU that the Bluetooth module on wcn6855
consumes and drop the ones from the host.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Note: This breaks the current contract but the only two users of wcn6855
upstream - sc8280xp based boards - will be updated in DTS patches sent
separately.

 .../bindings/net/bluetooth/qualcomm-bluetooth.yaml     | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
index 68c5ed111417..64a5c5004862 100644
--- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
@@ -172,14 +172,14 @@ allOf:
               - qcom,wcn6855-bt
     then:
       required:
-        - enable-gpios
-        - swctrl-gpios
-        - vddio-supply
-        - vddbtcxmx-supply
         - vddrfacmn-supply
+        - vddaon-supply
+        - vddwlcx-supply
+        - vddwlmx-supply
+        - vddbtcmx-supply
         - vddrfa0p8-supply
         - vddrfa1p2-supply
-        - vddrfa1p7-supply
+        - vddrfa1p8-supply
   - if:
       properties:
         compatible:
-- 
2.43.0

Re: [PATCH] dt-bindings: bluetooth: bring the HW description closer to reality for wcn6855

Posted by Rob Herring 1 year, 5 months ago

On Tue, Aug 13, 2024 at 09:01:31PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Describe the inputs from the PMU that the Bluetooth module on wcn6855
> consumes and drop the ones from the host.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> Note: This breaks the current contract but the only two users of wcn6855
> upstream - sc8280xp based boards - will be updated in DTS patches sent
> separately.

This needs to be in the commit msg.

Otherwise,

Acked-by: Rob Herring (Arm) <robh@kernel.org>

> 
>  .../bindings/net/bluetooth/qualcomm-bluetooth.yaml     | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> index 68c5ed111417..64a5c5004862 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> @@ -172,14 +172,14 @@ allOf:
>                - qcom,wcn6855-bt
>      then:
>        required:
> -        - enable-gpios
> -        - swctrl-gpios
> -        - vddio-supply
> -        - vddbtcxmx-supply
>          - vddrfacmn-supply
> +        - vddaon-supply
> +        - vddwlcx-supply
> +        - vddwlmx-supply
> +        - vddbtcmx-supply
>          - vddrfa0p8-supply
>          - vddrfa1p2-supply
> -        - vddrfa1p7-supply
> +        - vddrfa1p8-supply
>    - if:
>        properties:
>          compatible:
> -- 
> 2.43.0
>