speakup: genmap: remove redundant post-increment

[PATCH] speakup: genmap: remove redundant post-increment

Posted by bajing 1 year, 5 months ago

In the while loop, the variable lc is unused and is reinitialized later, so this redundant operation should be removed.

Signed-off-by: bajing <bajing@cmss.chinamobile.com>
---
 drivers/accessibility/speakup/genmap.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
index 0125000e00d9..836276327bdd 100644
--- a/drivers/accessibility/speakup/genmap.c
+++ b/drivers/accessibility/speakup/genmap.c
@@ -72,7 +72,6 @@ main(int argc, char *argv[])
 
 	open_input(NULL, argv[1]);
 	while (fgets(buffer, sizeof(buffer), infile)) {
-		lc++;
 		value = shift_state = 0;
 
 		cp = strtok(buffer, delims);
-- 
2.33.0

Re: [PATCH] speakup: genmap: remove redundant post-increment

Posted by Samuel Thibault 1 year, 5 months ago

bajing, le mar. 13 août 2024 11:17:53 +0800, a ecrit:
> In the while loop, the variable lc is unused and is reinitialized later, so this redundant operation should be removed.
> 
> Signed-off-by: bajing <bajing@cmss.chinamobile.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  drivers/accessibility/speakup/genmap.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> index 0125000e00d9..836276327bdd 100644
> --- a/drivers/accessibility/speakup/genmap.c
> +++ b/drivers/accessibility/speakup/genmap.c
> @@ -72,7 +72,6 @@ main(int argc, char *argv[])
>  
>  	open_input(NULL, argv[1]);
>  	while (fgets(buffer, sizeof(buffer), infile)) {
> -		lc++;
>  		value = shift_state = 0;
>  
>  		cp = strtok(buffer, delims);
> -- 
> 2.33.0