serial: 8250_platform: refactor and clean up a bit

[PATCH v1 0/7] serial: 8250_platform: refactor and clean up a bit

Posted by Andy Shevchenko 1 year, 5 months ago

Recent patch against this driver has been added without my review.
It was technically my fault, however I was on long vacation.
So, instead of blaming anyone, this small series to tidy up the things
as I think would look and be maintainable better.

Andy Shevchenko (7):
  serial: 8250_platform: Remove duplicate mapping
  serial: 8250_platform: Don't shadow error from
    serial8250_register_8250_port()
  serial: 8250_platform: Use same check for ACPI in the whole driver
  serial: 8250_platform: Tidy up ACPI ID table
  serial: 8250_platform: Switch to use platform_get_mem_or_io()
  serial: 8250_platform: Refactor serial8250_probe()
  serial: 8250_platform: Unify comment style

 drivers/tty/serial/8250/8250_platform.c | 107 +++++++++++++-----------
 1 file changed, 58 insertions(+), 49 deletions(-)

-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: [PATCH v1 0/7] serial: 8250_platform: refactor and clean up a bit

Posted by Sunil V L 1 year, 5 months ago

On Mon, Aug 12, 2024 at 06:47:02PM +0300, Andy Shevchenko wrote:
> Recent patch against this driver has been added without my review.
> It was technically my fault, however I was on long vacation.
> So, instead of blaming anyone, this small series to tidy up the things
> as I think would look and be maintainable better.
> 
> Andy Shevchenko (7):
>   serial: 8250_platform: Remove duplicate mapping
>   serial: 8250_platform: Don't shadow error from
>     serial8250_register_8250_port()
>   serial: 8250_platform: Use same check for ACPI in the whole driver
>   serial: 8250_platform: Tidy up ACPI ID table
>   serial: 8250_platform: Switch to use platform_get_mem_or_io()
>   serial: 8250_platform: Refactor serial8250_probe()
>   serial: 8250_platform: Unify comment style
> 
>  drivers/tty/serial/8250/8250_platform.c | 107 +++++++++++++-----------
>  1 file changed, 58 insertions(+), 49 deletions(-)
> 
Nice!. Thank you very much!.

For the series:

Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Tested-by: Sunil V L <sunilvl@ventanamicro.com>

Thanks!
Sunil