arm64: dts: qcom: sc8180x: Enable the power key

[PATCH] arm64: dts: qcom: sc8180x: Enable the power key

Posted by Bjorn Andersson 1 year, 10 months ago

From: Bjorn Andersson <quic_bjorande@quicinc.com>

No input events are generated from the pressing of the power key on
either Primus or Flex 5G, because the device node isn't enabled.

Give the power key node a label and enable this for the two devices.

Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 4 ++++
 arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi         | 2 +-
 arch/arm64/boot/dts/qcom/sc8180x-primus.dts         | 4 ++++
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
index 575a1a5ae20f..62de4774c556 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
+++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
@@ -484,6 +484,10 @@ &pcie3_phy {
 	status = "okay";
 };
 
+&pmc8180_pwrkey {
+	status = "okay";
+};
+
 &pmc8180c_lpg {
 	status = "okay";
 };
diff --git a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
index b6f8d1558c0d..451c9b984f1f 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
@@ -75,7 +75,7 @@ pmc8180_0: pmic@0 {
 		pon: pon@800 {
 			compatible = "qcom,pm8916-pon";
 			reg = <0x0800>;
-			pwrkey {
+			pmc8180_pwrkey: pwrkey {
 				compatible = "qcom,pm8941-pwrkey";
 				interrupts = <0x0 0x8 0x0 IRQ_TYPE_EDGE_BOTH>;
 				debounce = <15625>;
diff --git a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
index 9447c1e4577b..79b4d293ea1e 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
+++ b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
@@ -578,6 +578,10 @@ &pcie1_phy {
 	status = "okay";
 };
 
+&pmc8180_pwrkey {
+	status = "okay";
+};
+
 &pmc8180c_lpg {
 	status = "okay";
 };

---
base-commit: 9e6869691724b12e1f43655eeedc35fade38120c
change-id: 20240812-sc8180x-pwrkey-enable-9fe58187583e

Best regards,
-- 
Bjorn Andersson <quic_bjorande@quicinc.com>

Re: [PATCH] arm64: dts: qcom: sc8180x: Enable the power key

Posted by Bjorn Andersson 1 year, 10 months ago

On Mon, 12 Aug 2024 20:34:19 -0700, Bjorn Andersson wrote:
> No input events are generated from the pressing of the power key on
> either Primus or Flex 5G, because the device node isn't enabled.
> 
> Give the power key node a label and enable this for the two devices.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sc8180x: Enable the power key
      commit: 3706bcfbdb8aecdb506b80e45e2e5851044f1f28

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] arm64: dts: qcom: sc8180x: Enable the power key

Posted by Steev Klimaszewski 1 year, 10 months ago

On Mon, Aug 12, 2024 at 10:30 PM Bjorn Andersson <andersson@kernel.org> wrote:
>
> From: Bjorn Andersson <quic_bjorande@quicinc.com>
>
> No input events are generated from the pressing of the power key on
> either Primus or Flex 5G, because the device node isn't enabled.
>
> Give the power key node a label and enable this for the two devices.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 4 ++++
>  arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi         | 2 +-
>  arch/arm64/boot/dts/qcom/sc8180x-primus.dts         | 4 ++++
>  3 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> index 575a1a5ae20f..62de4774c556 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> @@ -484,6 +484,10 @@ &pcie3_phy {
>         status = "okay";
>  };
>
> +&pmc8180_pwrkey {
> +       status = "okay";
> +};
> +
>  &pmc8180c_lpg {
>         status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
> index b6f8d1558c0d..451c9b984f1f 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
> @@ -75,7 +75,7 @@ pmc8180_0: pmic@0 {
>                 pon: pon@800 {
>                         compatible = "qcom,pm8916-pon";
>                         reg = <0x0800>;
> -                       pwrkey {
> +                       pmc8180_pwrkey: pwrkey {
>                                 compatible = "qcom,pm8941-pwrkey";
>                                 interrupts = <0x0 0x8 0x0 IRQ_TYPE_EDGE_BOTH>;
>                                 debounce = <15625>;
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
> index 9447c1e4577b..79b4d293ea1e 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
> @@ -578,6 +578,10 @@ &pcie1_phy {
>         status = "okay";
>  };
>
> +&pmc8180_pwrkey {
> +       status = "okay";
> +};
> +
>  &pmc8180c_lpg {
>         status = "okay";
>  };
>
> ---
> base-commit: 9e6869691724b12e1f43655eeedc35fade38120c
> change-id: 20240812-sc8180x-pwrkey-enable-9fe58187583e
>
> Best regards,
> --
> Bjorn Andersson <quic_bjorande@quicinc.com>
>
>
Tested on the Lenovo Flex 5G.  When I hit the power button, it does
indeed want to turn off now.
Tested-by: Steev Klimaszewski <steev@kali.org>