[v1] kselftest/cgroup: Add missing newline in test_zswap.c

[PATCH] kselftest/cgroup: Add missing newline in test_zswap.c

Posted by Mohammed Anees 1 year, 5 months ago

Signed-off-by: Mohammed Anees <pvmohammedanees2003@gmail.com>
---
 tools/testing/selftests/cgroup/test_zswap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zswap.c
index 190096017..7c849d836 100644
--- a/tools/testing/selftests/cgroup/test_zswap.c
+++ b/tools/testing/selftests/cgroup/test_zswap.c
@@ -351,7 +351,7 @@ static int test_zswap_writeback(const char *root, bool wb)
 		goto out;
 
 	if (wb != !!zswpwb_after) {
-		ksft_print_msg("zswpwb_after is %ld while wb is %s",
+		ksft_print_msg("zswpwb_after is %ld while wb is %s\n",
 				zswpwb_after, wb ? "enabled" : "disabled");
 		goto out;
 	}
-- 
2.43.0

Re: [PATCH] kselftest/cgroup: Add missing newline in test_zswap.c

Posted by Shuah Khan 1 year, 5 months ago

On 8/11/24 08:58, Mohammed Anees wrote:

Missing change log

> Signed-off-by: Mohammed Anees <pvmohammedanees2003@gmail.com>
> ---
>   tools/testing/selftests/cgroup/test_zswap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zswap.c
> index 190096017..7c849d836 100644
> --- a/tools/testing/selftests/cgroup/test_zswap.c
> +++ b/tools/testing/selftests/cgroup/test_zswap.c
> @@ -351,7 +351,7 @@ static int test_zswap_writeback(const char *root, bool wb)
>   		goto out;
>   
>   	if (wb != !!zswpwb_after) {
> -		ksft_print_msg("zswpwb_after is %ld while wb is %s",
> +		ksft_print_msg("zswpwb_after is %ld while wb is %s\n",
>   				zswpwb_after, wb ? "enabled" : "disabled");
>   		goto out;
>   	}

The change looks good to me.

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah