crypto: marvell - Remove custom swap function in favor of built-in sort swap

[PATCH 0/2] crypto: marvell - Remove custom swap function in favor of built-in sort swap

Posted by Kuan-Wei Chiu 1 year, 6 months ago

The custom swap function used in octeontx/octeontx2 driver do not
perform any special operations and can be replaced with the built-in
swap function of sort. This change not only reduces code size but also
improves efficiency, especially in scenarios where CONFIG_RETPOLINE is
enabled, as it makes indirect function calls more expensive.

By using the built-in swap, we avoid these costly indirect function
calls, leading to better performance.

Kuan-Wei Chiu (2):
  crypto: octeontx - Remove custom swap function in favor of built-in
    sort swap
  crypto: octeontx2 - Remove custom swap functions in favor of built-in
    sort swap

 drivers/crypto/marvell/octeontx/otx_cptvf_algs.c   | 12 ++----------
 drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c | 10 +---------
 2 files changed, 3 insertions(+), 19 deletions(-)

-- 
2.34.1

Re: [PATCH 0/2] crypto: marvell - Remove custom swap function in favor of built-in sort swap

Posted by Herbert Xu 1 year, 5 months ago

On Sun, Aug 11, 2024 at 02:28:15PM +0800, Kuan-Wei Chiu wrote:
> The custom swap function used in octeontx/octeontx2 driver do not
> perform any special operations and can be replaced with the built-in
> swap function of sort. This change not only reduces code size but also
> improves efficiency, especially in scenarios where CONFIG_RETPOLINE is
> enabled, as it makes indirect function calls more expensive.
> 
> By using the built-in swap, we avoid these costly indirect function
> calls, leading to better performance.
> 
> Kuan-Wei Chiu (2):
>   crypto: octeontx - Remove custom swap function in favor of built-in
>     sort swap
>   crypto: octeontx2 - Remove custom swap functions in favor of built-in
>     sort swap
> 
>  drivers/crypto/marvell/octeontx/otx_cptvf_algs.c   | 12 ++----------
>  drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c | 10 +---------
>  2 files changed, 3 insertions(+), 19 deletions(-)
> 
> -- 
> 2.34.1

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt