giantec,gt24c04a eeproms for qnap ts433

[PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A

Posted by Heiko Stuebner 1 year, 6 months ago

The gt24c04a is just yet another 2404 compatible eeprom, and does not
follow the generic naming matching, so add a separate compatible for it.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 Documentation/devicetree/bindings/eeprom/at24.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
index e396e47b2f13c..b6239ec3512b3 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.yaml
+++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
@@ -116,6 +116,7 @@ properties:
           - const: atmel,24c02
       - items:
           - enum:
+              - giantec,gt24c04a
               - onnn,cat24c04
               - onnn,cat24c05
               - rohm,br24g04
-- 
2.39.2

Re: [PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A

Posted by Bartosz Golaszewski 1 year, 6 months ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Sat, 10 Aug 2024 23:14:37 +0200, Heiko Stuebner wrote:
> The gt24c04a is just yet another 2404 compatible eeprom, and does not
> follow the generic naming matching, so add a separate compatible for it.
> 
> 

Applied, thanks!

[1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
      commit: a825dea2cd27a30e49816f18b7bc16545d5f0f89

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A

Posted by Heiko Stübner 1 year, 5 months ago

Hi,

Am Sonntag, 11. August 2024, 21:27:13 CEST schrieb Bartosz Golaszewski:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> 
> On Sat, 10 Aug 2024 23:14:37 +0200, Heiko Stuebner wrote:
> > The gt24c04a is just yet another 2404 compatible eeprom, and does not
> > follow the generic naming matching, so add a separate compatible for it.
> > 
> > 
> 
> Applied, thanks!
> 
> [1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
>       commit: a825dea2cd27a30e49816f18b7bc16545d5f0f89

just for my understanding, where is this commit living now?

Because linux next seems to know it [0], but also says that
"Notice: this object is not reachable from any branch."


Thanks
Heiko

[0] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a825dea2cd27a30e49816f18b7bc16545d5f0f89

Re: [PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A

Posted by Bartosz Golaszewski 1 year, 5 months ago

On Thu, 15 Aug 2024 at 18:48, Heiko Stübner <heiko@sntech.de> wrote:
>
> Hi,
>
> Am Sonntag, 11. August 2024, 21:27:13 CEST schrieb Bartosz Golaszewski:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> >
> > On Sat, 10 Aug 2024 23:14:37 +0200, Heiko Stuebner wrote:
> > > The gt24c04a is just yet another 2404 compatible eeprom, and does not
> > > follow the generic naming matching, so add a separate compatible for it.
> > >
> > >
> >
> > Applied, thanks!
> >
> > [1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
> >       commit: a825dea2cd27a30e49816f18b7bc16545d5f0f89
>
> just for my understanding, where is this commit living now?
>
> Because linux next seems to know it [0], but also says that
> "Notice: this object is not reachable from any branch."
>
>
> Thanks
> Heiko
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a825dea2cd27a30e49816f18b7bc16545d5f0f89
>
>

It lives in my kernel.org tree[1]. You can get that information from
the MAINTAINERS file.

Bart

[1] https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git/log/?h=at24/for-next

Re: [PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A

Posted by Krzysztof Kozlowski 1 year, 5 months ago

On 16/08/2024 10:03, Bartosz Golaszewski wrote:
>>>
>>> Applied, thanks!
>>>
>>> [1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
>>>       commit: a825dea2cd27a30e49816f18b7bc16545d5f0f89
>>
>> just for my understanding, where is this commit living now?
>>
>> Because linux next seems to know it [0], but also says that
>> "Notice: this object is not reachable from any branch."
>>
>>
>> Thanks
>> Heiko
>>
>> [0] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a825dea2cd27a30e49816f18b7bc16545d5f0f89
>>
>>
> 
> It lives in my kernel.org tree[1]. You can get that information from
> the MAINTAINERS file.

Or use simple template - only one entry needed:
b4.thanks-commit-url-mask = https://git.kernel.org/MR_FOO/linux/c/%s

page 44 of PDF:
https://lpc.events/event/17/contributions/1498/#preview:2452

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A

Posted by Krzysztof Kozlowski 1 year, 6 months ago

On 10/08/2024 23:14, Heiko Stuebner wrote:
> The gt24c04a is just yet another 2404 compatible eeprom, and does not
> follow the generic naming matching, so add a separate compatible for it.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  Documentation/devicetree/bindings/eeprom/at24.yaml | 1 +

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof