[PATCH net-next v3 1/2] dt-bindings: net: dsa: microchip: Add KSZ8895/KSZ8864 switch support

Tristram.Ha@microchip.com posted 2 patches 1 year, 6 months ago
There is a newer version of this series
[PATCH net-next v3 1/2] dt-bindings: net: dsa: microchip: Add KSZ8895/KSZ8864 switch support
Posted by Tristram.Ha@microchip.com 1 year, 6 months ago
From: Tristram Ha <tristram.ha@microchip.com>

KSZ8895/KSZ8864 is a switch family developed before KSZ8795 and after
KSZ8863, so it shares some registers and functions in those switches.
KSZ8895 has 5 ports and so is more similar to KSZ8795.

KSZ8864 is a 4-port version of KSZ8895.  The first port is removed
while port 5 remains as a host port.

Signed-off-by: Tristram Ha <tristram.ha@microchip.com>
---
 Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
index 52acc15ebcbf..d8efb6f0c253 100644
--- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
@@ -21,6 +21,8 @@ properties:
       - microchip,ksz8765
       - microchip,ksz8794
       - microchip,ksz8795
+      - microchip,ksz8895  # 5-port version of KSZ8895 family switch
+      - microchip,ksz8864  # 4-port version of KSZ8895 family switch
       - microchip,ksz8863
       - microchip,ksz8873
       - microchip,ksz9477
-- 
2.34.1
Re: [PATCH net-next v3 1/2] dt-bindings: net: dsa: microchip: Add KSZ8895/KSZ8864 switch support
Posted by Krzysztof Kozlowski 1 year, 5 months ago
On 09/08/2024 23:21, Tristram.Ha@microchip.com wrote:
> From: Tristram Ha <tristram.ha@microchip.com>
> 
> KSZ8895/KSZ8864 is a switch family developed before KSZ8795 and after
> KSZ8863, so it shares some registers and functions in those switches.
> KSZ8895 has 5 ports and so is more similar to KSZ8795.
> 
> KSZ8864 is a 4-port version of KSZ8895.  The first port is removed
> while port 5 remains as a host port.
> 
> Signed-off-by: Tristram Ha <tristram.ha@microchip.com>
> ---
>  Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> index 52acc15ebcbf..d8efb6f0c253 100644
> --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> @@ -21,6 +21,8 @@ properties:
>        - microchip,ksz8765
>        - microchip,ksz8794
>        - microchip,ksz8795
> +      - microchip,ksz8895  # 5-port version of KSZ8895 family switch
> +      - microchip,ksz8864  # 4-port version of KSZ8895 family switch
>        - microchip,ksz8863
>        - microchip,ksz8873

Keep the entries sorted.

With sorting fixed:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Re: [PATCH net-next v3 1/2] dt-bindings: net: dsa: microchip: Add KSZ8895/KSZ8864 switch support
Posted by Krzysztof Kozlowski 1 year, 6 months ago
On 09/08/2024 23:21, Tristram.Ha@microchip.com wrote:
> From: Tristram Ha <tristram.ha@microchip.com>
> 
> KSZ8895/KSZ8864 is a switch family developed before KSZ8795 and after
> KSZ8863, so it shares some registers and functions in those switches.
> KSZ8895 has 5 ports and so is more similar to KSZ8795.
> 
> KSZ8864 is a 4-port version of KSZ8895.  The first port is removed
> while port 5 remains as a host port.
> 
> Signed-off-by: Tristram Ha <tristram.ha@microchip.com>
> ---
>  Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 2 ++
>  1 file changed, 2 insertions(+)

Considering your earlier and later submissions were not tested, was this
one? Did you test it before sending?

Best regards,
Krzysztof
RE: [PATCH net-next v3 1/2] dt-bindings: net: dsa: microchip: Add KSZ8895/KSZ8864 switch support
Posted by Tristram.Ha@microchip.com 1 year, 5 months ago
> > From: Tristram Ha <tristram.ha@microchip.com>
> >
> > KSZ8895/KSZ8864 is a switch family developed before KSZ8795 and after
> > KSZ8863, so it shares some registers and functions in those switches.
> > KSZ8895 has 5 ports and so is more similar to KSZ8795.
> >
> > KSZ8864 is a 4-port version of KSZ8895.  The first port is removed
> > while port 5 remains as a host port.
> >
> > Signed-off-by: Tristram Ha <tristram.ha@microchip.com>
> > ---
> >  Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Considering your earlier and later submissions were not tested, was this
> one? Did you test it before sending?

This one passed the dt_binding_check.