FS_IOC_GETFSSYSFSPATH ioctl expects sysfs sub-path of a filesystem, the
format can be "$FSTYP/$SYSFS_IDENTIFIER" under /sys/fs, it can helps to
standardizes exporting sysfs datas across filesystems.

This patch wires up FS_IOC_GETFSSYSFSPATH for zonefs, it will output
"zonefs/<dev>".

Signed-off-by: Liao Chen <liaochen4@huawei.com>
---
 fs/zonefs/super.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
index faf1eb87895d..e180daa39578 100644
--- a/fs/zonefs/super.c
+++ b/fs/zonefs/super.c
@@ -1262,6 +1262,7 @@ static int zonefs_fill_super(struct super_block *sb, struct fs_context *fc)
 	sb->s_maxbytes = 0;
 	sb->s_op = &zonefs_sops;
 	sb->s_time_gran	= 1;
+	super_set_sysfs_name_id(sb);
 
 	/*
 	 * The block size is set to the device zone write granularity to ensure
-- 
2.34.1

On 2024/8/9 9:36, Liao Chen wrote:
> FS_IOC_GETFSSYSFSPATH ioctl expects sysfs sub-path of a filesystem, the
> format can be "$FSTYP/$SYSFS_IDENTIFIER" under /sys/fs, it can helps to
> standardizes exporting sysfs datas across filesystems.
> 
> This patch wires up FS_IOC_GETFSSYSFSPATH for zonefs, it will output
> "zonefs/<dev>".
> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>
> ---
>   fs/zonefs/super.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
> index faf1eb87895d..e180daa39578 100644
> --- a/fs/zonefs/super.c
> +++ b/fs/zonefs/super.c
> @@ -1262,6 +1262,7 @@ static int zonefs_fill_super(struct super_block *sb, struct fs_context *fc)
>   	sb->s_maxbytes = 0;
>   	sb->s_op = &zonefs_sops;
>   	sb->s_time_gran	= 1;
> +	super_set_sysfs_name_id(sb);
>   
>   	/*
>   	 * The block size is set to the device zone write granularity to ensure
Gentle ping

Thanks,
Chen

On 8/19/24 21:22, liaochen (A) wrote:
> On 2024/8/9 9:36, Liao Chen wrote:
>> FS_IOC_GETFSSYSFSPATH ioctl expects sysfs sub-path of a filesystem, the
>> format can be "$FSTYP/$SYSFS_IDENTIFIER" under /sys/fs, it can helps to
>> standardizes exporting sysfs datas across filesystems.
>>
>> This patch wires up FS_IOC_GETFSSYSFSPATH for zonefs, it will output
>> "zonefs/<dev>".
>>
>> Signed-off-by: Liao Chen <liaochen4@huawei.com>
>> ---
>>   fs/zonefs/super.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
>> index faf1eb87895d..e180daa39578 100644
>> --- a/fs/zonefs/super.c
>> +++ b/fs/zonefs/super.c
>> @@ -1262,6 +1262,7 @@ static int zonefs_fill_super(struct super_block *sb, struct fs_context *fc)
>>   	sb->s_maxbytes = 0;
>>   	sb->s_op = &zonefs_sops;
>>   	sb->s_time_gran	= 1;
>> +	super_set_sysfs_name_id(sb);
>>   
>>   	/*
>>   	 * The block size is set to the device zone write granularity to ensure
> Gentle ping

I replied yesterday with a comment. Did you get that email ?

See:
https://lore.kernel.org/linux-fsdevel/55ca393e-e2e9-45ef-8eb0-050d79c92987@kernel.org/

> 
> Thanks,
> Chen

-- 
Damien Le Moal
Western Digital Research

On 8/9/24 10:36, Liao Chen wrote:
> FS_IOC_GETFSSYSFSPATH ioctl expects sysfs sub-path of a filesystem, the
> format can be "$FSTYP/$SYSFS_IDENTIFIER" under /sys/fs, it can helps to
> standardizes exporting sysfs datas across filesystems.
> 
> This patch wires up FS_IOC_GETFSSYSFSPATH for zonefs, it will output
> "zonefs/<dev>".
> 
> Signed-off-by: Liao Chen <liaochen4@huawei.com>
> ---
>  fs/zonefs/super.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
> index faf1eb87895d..e180daa39578 100644
> --- a/fs/zonefs/super.c
> +++ b/fs/zonefs/super.c
> @@ -1262,6 +1262,7 @@ static int zonefs_fill_super(struct super_block *sb, struct fs_context *fc)
>  	sb->s_maxbytes = 0;
>  	sb->s_op = &zonefs_sops;
>  	sb->s_time_gran	= 1;
> +	super_set_sysfs_name_id(sb);

Can you resend the patch with this call moved to the beginning of
zonefs_sysfs_register() in fs/zonefs/sysfs.c ?
Thanks.

>  
>  	/*
>  	 * The block size is set to the device zone write granularity to ensure

-- 
Damien Le Moal
Western Digital Research