Add the necessary sound card bits and some dts additions to enable sound
over DisplayPort-over-USB-C, e.g. to a connected TV or monitor.

The UCM files can be found here:
https://gitlab.com/postmarketOS/pmaports/-/tree/master/device/testing/device-fairphone-fp5/ucm

Two extra notes:

1. I don't quite understand whether the sound driver should have
   SoC-specific compatible or device-specific compatible. Some earlier
   patches by another author for a QCM6490 board and a QCS6490 board use
   device-specific compatible - but from what I can tell this is not how
   it's generally done for other sound drivers?

2. Unfortunately DisplayPort enablement itself for Fairphone 5 is not
   upstream yet. This is blocked by DSI display bringup upstream which
   is blocked by DSC 1:1:1 not being supported upstream yet and just
   working with a hacky patch. Nevertheless, DisplayPort audio was
   validated working with no additional sound-related changes so once
   DisplayPort gets enabled, sound should also just work upstream.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Luca Weiss (3):
      ASoC: dt-bindings: qcom,sm8250: Add generic QCM6490 sound card
      ASoC: qcom: sc8280xp: Add support for generic QCM6490
      arm64: dts: qcom: qcm6490-fairphone-fp5: Add DisplayPort sound support

 .../devicetree/bindings/sound/qcom,sm8250.yaml     |  1 +
 arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 37 ++++++++++++++++++++++
 sound/soc/qcom/sc8280xp.c                          |  1 +
 3 files changed, 39 insertions(+)
---
base-commit: 6cdb38a56eaf615abc60fbeec0e4ccbdf93468e3
change-id: 20240809-fp5-dp-sound-b3768f3019bd

Best regards,
-- 
Luca Weiss <luca.weiss@fairphone.com>

On 9.08.2024 10:33 AM, Luca Weiss wrote:
> Add the necessary sound card bits and some dts additions to enable sound
> over DisplayPort-over-USB-C, e.g. to a connected TV or monitor.
> 
> The UCM files can be found here:
> https://gitlab.com/postmarketOS/pmaports/-/tree/master/device/testing/device-fairphone-fp5/ucm
> 
> Two extra notes:
> 
> 1. I don't quite understand whether the sound driver should have
>    SoC-specific compatible or device-specific compatible. Some earlier
>    patches by another author for a QCM6490 board and a QCS6490 board use
>    device-specific compatible - but from what I can tell this is not how
>    it's generally done for other sound drivers?
> 
> 2. Unfortunately DisplayPort enablement itself for Fairphone 5 is not
>    upstream yet. This is blocked by DSI display bringup upstream which
>    is blocked by DSC 1:1:1 not being supported upstream yet and just
>    working with a hacky patch. Nevertheless, DisplayPort audio was
>    validated working with no additional sound-related changes so once
>    DisplayPort gets enabled, sound should also just work upstream.

You can enable DP and keep DSI disabled for the time being

Konrad

On Samstag, 10. August 2024 14:35:00 MESZ Konrad Dybcio wrote:
> On 9.08.2024 10:33 AM, Luca Weiss wrote:
> > Add the necessary sound card bits and some dts additions to enable sound
> > over DisplayPort-over-USB-C, e.g. to a connected TV or monitor.
> > 
> > The UCM files can be found here:
> > https://gitlab.com/postmarketOS/pmaports/-/tree/master/device/testing/
device-fairphone-fp5/ucm
> > 
> > Two extra notes:
> > 
> > 1. I don't quite understand whether the sound driver should have
> >    SoC-specific compatible or device-specific compatible. Some earlier
> >    patches by another author for a QCM6490 board and a QCS6490 board use
> >    device-specific compatible - but from what I can tell this is not how
> >    it's generally done for other sound drivers?
> > 
> > 2. Unfortunately DisplayPort enablement itself for Fairphone 5 is not
> >    upstream yet. This is blocked by DSI display bringup upstream which
> >    is blocked by DSC 1:1:1 not being supported upstream yet and just
> >    working with a hacky patch. Nevertheless, DisplayPort audio was
> >    validated working with no additional sound-related changes so once
> >    DisplayPort gets enabled, sound should also just work upstream.
> 
> You can enable DP and keep DSI disabled for the time being

I need to enable dispcc for DP which breaks simple-fb from my testing?

Maybe I can figure out the correct clocks and power domains to put into the 
simple-fb node? Do you think that would work and be sufficient to make both 
simple-fb and DP work?

> 
> Konrad
>

On 09/08/2024 10:33, Luca Weiss wrote:
> Add the necessary sound card bits and some dts additions to enable sound
> over DisplayPort-over-USB-C, e.g. to a connected TV or monitor.
> 
> The UCM files can be found here:
> https://gitlab.com/postmarketOS/pmaports/-/tree/master/device/testing/device-fairphone-fp5/ucm
> 
> Two extra notes:
> 
> 1. I don't quite understand whether the sound driver should have
>    SoC-specific compatible or device-specific compatible. Some earlier
>    patches by another author for a QCM6490 board and a QCS6490 board use
>    device-specific compatible - but from what I can tell this is not how
>    it's generally done for other sound drivers?

We (including me) were/are a bit inconsistent here, but last statement
was that these should be board-specific compatibles.

Last discussion I recall:
https://lore.kernel.org/all/baa6543c-5e2e-4f28-a95b-a086b32d1f2d@linaro.org/


Best regards,
Krzysztof