[PATCH 6.1 00/86] 6.1.104-rc2 review

Greg Kroah-Hartman posted 86 patches 1 year, 6 months ago
Only 0 patches received!
Makefile                                           |   4 +-
arch/arm64/boot/dts/qcom/ipq8074.dtsi              |   2 +
arch/arm64/boot/dts/qcom/msm8998.dtsi              |  36 +++---
arch/arm64/include/asm/jump_label.h                |   1 +
arch/arm64/kernel/jump_label.c                     |  11 +-
arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi |  84 +++++++++----
arch/riscv/mm/fault.c                              |  17 +--
drivers/cpufreq/qcom-cpufreq-nvmem.c               |  56 ++++-----
.../gpu/drm/i915/display/intel_dp_link_training.c  |  54 +++++++-
drivers/gpu/drm/i915/display/intel_dpll_mgr.c      |   6 +-
drivers/gpu/drm/i915/display/intel_hdcp_regs.h     |   2 +-
drivers/gpu/drm/nouveau/nouveau_prime.c            |   3 +-
drivers/gpu/drm/udl/Makefile                       |   2 +-
drivers/gpu/drm/udl/udl_connector.c                | 139 ---------------------
drivers/gpu/drm/udl/udl_connector.h                |  15 ---
drivers/gpu/drm/udl/udl_drv.h                      |  11 ++
drivers/gpu/drm/udl/udl_modeset.c                  | 135 ++++++++++++++++++++
drivers/gpu/drm/vmwgfx/vmwgfx_fence.c              |  17 ++-
drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c            |   2 +-
drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c               |  29 ++++-
drivers/hid/amd-sfh-hid/amd_sfh_client.c           |  55 ++++----
drivers/hid/wacom_wac.c                            |   3 +-
drivers/leds/led-triggers.c                        |  32 ++---
drivers/leds/trigger/ledtrig-timer.c               |   5 -
drivers/net/ethernet/intel/ice/ice_txrx.c          |   2 +-
drivers/net/ethernet/intel/ice/ice_xsk.c           |  19 +--
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c    |   6 +-
.../net/ethernet/mellanox/mlx5/core/en_ethtool.c   |   7 +-
drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c |   5 +-
drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c  |   2 +-
drivers/net/ethernet/realtek/r8169_main.c          |   8 +-
drivers/net/ethernet/xilinx/xilinx_axienet_main.c  |   2 +-
drivers/net/usb/sr9700.c                           |  11 +-
drivers/platform/chrome/cros_ec_proto.c            |   2 +
fs/btrfs/block-group.c                             |  13 +-
fs/btrfs/extent-tree.c                             |   3 +-
fs/btrfs/free-space-cache.c                        |   4 +-
fs/btrfs/space-info.c                              |   2 +-
fs/btrfs/space-info.h                              |   1 +
fs/ext4/extents.c                                  |   5 +-
fs/ext4/extents_status.c                           |  14 +--
fs/ext4/extents_status.h                           |   6 +-
fs/ext4/inode.c                                    | 115 +++++++++--------
fs/f2fs/segment.c                                  |   4 +-
fs/file.c                                          |   1 +
fs/proc/proc_sysctl.c                              |   8 +-
include/linux/leds.h                               |  30 +++--
include/linux/sysctl.h                             |   1 -
include/trace/events/btrfs.h                       |   8 ++
include/trace/events/mptcp.h                       |   2 +-
init/Kconfig                                       |   1 +
ipc/ipc_sysctl.c                                   |  36 +++++-
ipc/mq_sysctl.c                                    |  35 ++++++
kernel/irq/irqdomain.c                             |   7 +-
mm/Kconfig                                         |  11 ++
mm/page_alloc.c                                    |  19 ++-
net/bluetooth/hci_sync.c                           |  21 ++++
net/core/rtnetlink.c                               |   2 +-
net/ipv4/netfilter/iptable_nat.c                   |  18 +--
net/ipv6/ndisc.c                                   |  34 ++---
net/ipv6/netfilter/ip6table_nat.c                  |  14 ++-
net/iucv/af_iucv.c                                 |   4 +-
net/mptcp/options.c                                |   2 +-
net/mptcp/pm_netlink.c                             |  28 +++--
net/mptcp/protocol.c                               |  18 +--
net/mptcp/protocol.h                               |   1 +
net/mptcp/subflow.c                                |  17 ++-
net/netfilter/ipset/ip_set_list_set.c              |   3 +
net/sched/act_ct.c                                 |   4 +-
net/sysctl_net.c                                   |   1 -
sound/firewire/amdtp-stream.c                      |  38 +++---
sound/firewire/amdtp-stream.h                      |   1 +
sound/pci/hda/hda_controller.h                     |   2 +-
sound/pci/hda/hda_intel.c                          |  10 +-
sound/pci/hda/patch_conexant.c                     |  58 ++-------
sound/pci/hda/patch_realtek.c                      |   1 +
sound/usb/stream.c                                 |   4 +-
tools/testing/selftests/net/mptcp/mptcp_connect.c  |   8 +-
78 files changed, 813 insertions(+), 587 deletions(-)
[PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Greg Kroah-Hartman 1 year, 6 months ago
This is the start of the stable review cycle for the 6.1.104 release.
There are 86 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let me know.

Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
or in the git tree and branch at:
	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Linux 6.1.104-rc2

Alexander Maltsev <keltar.gw@gmail.com>
    netfilter: ipset: Add list flush to cancel_gc

Liu Jing <liujing@cmss.chinamobile.com>
    selftests: mptcp: always close input's FD if opened

Paolo Abeni <pabeni@redhat.com>
    mptcp: fix duplicate data handling

Matthieu Baerts (NGI0) <matttbe@kernel.org>
    mptcp: pm: only set request_bkup flag when sending MP_PRIO

Paolo Abeni <pabeni@redhat.com>
    mptcp: fix bad RCVPRUNED mib accounting

Paolo Abeni <pabeni@redhat.com>
    mptcp: fix NL PM announced address accounting

Matthieu Baerts (NGI0) <matttbe@kernel.org>
    mptcp: distinguish rcv vs sent backup flag in requests

Paolo Abeni <pabeni@redhat.com>
    mptcp: fix user-space PM announced address accounting

Heiner Kallweit <hkallweit1@gmail.com>
    r8169: don't increment tx_dropped in case of NETDEV_TX_BUSY

Ma Ke <make24@iscas.ac.cn>
    net: usb: sr9700: fix uninitialized variable use in sr_mdio_read

Nikita Zhandarovich <n.zhandarovich@fintech.ru>
    drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()

Zack Rusin <zack.rusin@broadcom.com>
    drm/vmwgfx: Fix a deadlock in dma buf fence polling

Edmund Raile <edmund.raile@protonmail.com>
    Revert "ALSA: firewire-lib: operate for period elapse event in process context"

Edmund Raile <edmund.raile@protonmail.com>
    Revert "ALSA: firewire-lib: obsolete workqueue for period update"

Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
    ALSA: hda/realtek: Add quirk for Acer Aspire E5-574G

Takashi Iwai <tiwai@suse.de>
    ALSA: usb-audio: Correct surround channels in UAC1 channel map

Matthieu Baerts (NGI0) <matttbe@kernel.org>
    mptcp: sched: check both directions for backup

Al Viro <viro@zeniv.linux.org.uk>
    protect the fetch of ->fd[fd] in do_dup2() from mispredictions

Naohiro Aota <naohiro.aota@wdc.com>
    btrfs: zoned: fix zone_unusable accounting on making block group read-write again

Tatsunosuke Tobita <tatsunosuke.tobita@wacom.com>
    HID: wacom: Modify pen IDs

Patryk Duda <patrykd@google.com>
    platform/chrome: cros_ec_proto: Lock device when updating MKBP version

Alice Ryhl <aliceryhl@google.com>
    rust: SHADOW_CALL_STACK is incompatible with Rust

Will Deacon <will@kernel.org>
    arm64: jump_label: Ensure patched jump_labels are visible to all CPUs

Zhe Qiao <qiaozhe@iscas.ac.cn>
    riscv/mm: Add handling for VM_FAULT_SIGSEGV in mm_fault_error()

Maciej Żenczykowski <maze@google.com>
    ipv6: fix ndisc_is_useropt() handling for PIO

Shahar Shitrit <shshitrit@nvidia.com>
    net/mlx5e: Add a check for the return value from mlx5_port_set_eth_ptys

Moshe Shemesh <moshe@nvidia.com>
    net/mlx5: Fix missing lock on sync reset reload

Mark Bloch <mbloch@nvidia.com>
    net/mlx5: Lag, don't use the hardcoded value of the first port

Kuniyuki Iwashima <kuniyu@amazon.com>
    netfilter: iptables: Fix potential null-ptr-deref in ip6table_nat_table_init().

Kuniyuki Iwashima <kuniyu@amazon.com>
    netfilter: iptables: Fix null-ptr-deref in iptable_nat_table_init().

Takashi Iwai <tiwai@suse.de>
    ALSA: hda: Conditionally use snooping for AMD HDMI

Dan Carpenter <dan.carpenter@linaro.org>
    net: mvpp2: Don't re-use loop iterator

Suraj Kandpal <suraj.kandpal@intel.com>
    drm/i915/hdcp: Fix HDCP2_STREAM_STATUS macro

Alexandra Winter <wintera@linux.ibm.com>
    net/iucv: fix use after free in iucv_sock_close()

Maciej Fijalkowski <maciej.fijalkowski@intel.com>
    ice: add missing WRITE_ONCE when clearing ice_rx_ring::xdp_prog

Maciej Fijalkowski <maciej.fijalkowski@intel.com>
    ice: replace synchronize_rcu with synchronize_net

Maciej Fijalkowski <maciej.fijalkowski@intel.com>
    ice: don't busy wait for Rx queue disable in ice_qp_dis()

Michal Kubiak <michal.kubiak@intel.com>
    ice: respect netif readiness in AF_XDP ZC related ndo's

Kuniyuki Iwashima <kuniyu@amazon.com>
    rtnetlink: Don't ignore IFLA_TARGET_NETNSID when ifname is specified in rtnl_dellink().

Andy Chiu <andy.chiu@sifive.com>
    net: axienet: start napi before enabling Rx/Tx

Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
    Bluetooth: hci_sync: Fix suspending with wrong filter policy

songxiebing <songxiebing@kylinos.cn>
    ALSA: hda: conexant: Fix headset auto detect fail in the polling mode

Takashi Iwai <tiwai@suse.de>
    ALSA: hda: conexant: Reduce CONFIG_PM dependencies

Eric Dumazet <edumazet@google.com>
    sched: act_ct: take care of padding in struct zones_ht_key

Ian Forbes <ian.forbes@broadcom.com>
    drm/vmwgfx: Trigger a modeset when the screen moves

Ian Forbes <ian.forbes@broadcom.com>
    drm/vmwgfx: Fix overlay when using Screen Targets

Danilo Krummrich <dakr@kernel.org>
    drm/nouveau: prime: fix refcount underflow

Basavaraj Natikar <Basavaraj.Natikar@amd.com>
    HID: amd_sfh: Move sensor discovery before HID device initialization

Basavaraj Natikar <Basavaraj.Natikar@amd.com>
    HID: amd_sfh: Split sensor and HID initialization

Basavaraj Natikar <Basavaraj.Natikar@amd.com>
    HID: amd_sfh: Remove duplicate cleanup

Jiaxun Yang <jiaxun.yang@flygoat.com>
    MIPS: dts: loongson: Fix ls2k1000-rtc interrupt

Jiaxun Yang <jiaxun.yang@flygoat.com>
    MIPS: dts: loongson: Fix liointc IRQ polarity

Jiaxun Yang <jiaxun.yang@flygoat.com>
    MIPS: Loongson64: DTS: Fix PCIe port nodes for ls7a

Binbin Zhou <zhoubinbin@loongson.cn>
    MIPS: Loongson64: DTS: Add RTC support to Loongson-2K1000

Imre Deak <imre.deak@intel.com>
    drm/i915/dp: Don't switch the LTTPR mode on an active link

Thomas Zimmermann <tzimmermann@suse.de>
    drm/udl: Remove DRM_CONNECTOR_POLL_HPD

Thomas Zimmermann <tzimmermann@suse.de>
    drm/udl: Move connector to modesetting code

Thomas Zimmermann <tzimmermann@suse.de>
    drm/udl: Various improvements to the connector

Thomas Zimmermann <tzimmermann@suse.de>
    drm/udl: Use USB timeout constant when reading EDID

Thomas Zimmermann <tzimmermann@suse.de>
    drm/udl: Test pixel limit in mode-config's mode-valid function

Thomas Zimmermann <tzimmermann@suse.de>
    drm/udl: Rename struct udl_drm_connector to struct udl_connector

Herve Codina <herve.codina@bootlin.com>
    irqdomain: Fixed unbalanced fwnode get and put

Jaegeuk Kim <jaegeuk@kernel.org>
    f2fs: assign CURSEG_ALL_DATA_ATGC if blkaddr is valid

Zhiguo Niu <zhiguo.niu@unisoc.com>
    f2fs: fix to avoid use SSR allocate when do defragment

Li Zhijian <lizhijian@fujitsu.com>
    mm/page_alloc: fix pcp->count race between drain_pages_zone() vs __rmqueue_pcplist()

Lucas Stach <l.stach@pengutronix.de>
    mm: page_alloc: control latency caused by zone PCP draining

Huang Ying <ying.huang@intel.com>
    mm: restrict the pcp batch scale factor to avoid too long latency

Thomas Weißschuh <linux@weissschuh.net>
    leds: triggers: Flush pending brightness before activating trigger

Hans de Goede <hdegoede@redhat.com>
    leds: trigger: Call synchronize_rcu() before calling trig->activate()

Heiner Kallweit <hkallweit1@gmail.com>
    leds: trigger: Store brightness set by led_trigger_event()

Heiner Kallweit <hkallweit1@gmail.com>
    leds: trigger: Remove unused function led_trigger_rename_static()

Javier Carrasco <javier.carrasco.cruz@gmail.com>
    cpufreq: qcom-nvmem: fix memory leaks in probe error paths

Stephan Gerhold <stephan.gerhold@kernkonzept.com>
    cpufreq: qcom-nvmem: Simplify driver data allocation

Yangtao Li <frank.li@vivo.com>
    cpufreq: qcom-nvmem: Convert to platform remove callback returning void

Zhang Yi <yi.zhang@huawei.com>
    ext4: check the extent status again before inserting delalloc block

Zhang Yi <yi.zhang@huawei.com>
    ext4: factor out a common helper to query extent map

Zhang Yi <yi.zhang@huawei.com>
    ext4: convert to exclusive lock while inserting delalloc extents

Zhang Yi <yi.zhang@huawei.com>
    ext4: refactor ext4_da_map_blocks()

Baokun Li <libaokun1@huawei.com>
    ext4: make ext4_es_insert_extent() return void

Thomas Weißschuh <linux@weissschuh.net>
    sysctl: always initialize i_uid/i_gid

Thomas Weißschuh <linux@weissschuh.net>
    sysctl: treewide: drop unused argument ctl_table_root::set_ownership(table)

Alexey Gladkov <legion@kernel.org>
    sysctl: allow to change limits for posix messages queues

Alexey Gladkov <legion@kernel.org>
    sysctl: allow change system v ipc sysctls inside ipc namespace

Krishna Kurapati <quic_kriskura@quicinc.com>
    arm64: dts: qcom: ipq8074: Disable SS instance in Parkmode for USB

Krishna Kurapati <quic_kriskura@quicinc.com>
    arm64: dts: qcom: msm8998: Disable SS instance in Parkmode for USB

Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    arm64: dts: qcom: msm8998: switch USB QMP PHY to new style of bindings


-------------

Diffstat:

 Makefile                                           |   4 +-
 arch/arm64/boot/dts/qcom/ipq8074.dtsi              |   2 +
 arch/arm64/boot/dts/qcom/msm8998.dtsi              |  36 +++---
 arch/arm64/include/asm/jump_label.h                |   1 +
 arch/arm64/kernel/jump_label.c                     |  11 +-
 arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi |  84 +++++++++----
 arch/riscv/mm/fault.c                              |  17 +--
 drivers/cpufreq/qcom-cpufreq-nvmem.c               |  56 ++++-----
 .../gpu/drm/i915/display/intel_dp_link_training.c  |  54 +++++++-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c      |   6 +-
 drivers/gpu/drm/i915/display/intel_hdcp_regs.h     |   2 +-
 drivers/gpu/drm/nouveau/nouveau_prime.c            |   3 +-
 drivers/gpu/drm/udl/Makefile                       |   2 +-
 drivers/gpu/drm/udl/udl_connector.c                | 139 ---------------------
 drivers/gpu/drm/udl/udl_connector.h                |  15 ---
 drivers/gpu/drm/udl/udl_drv.h                      |  11 ++
 drivers/gpu/drm/udl/udl_modeset.c                  | 135 ++++++++++++++++++++
 drivers/gpu/drm/vmwgfx/vmwgfx_fence.c              |  17 ++-
 drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c            |   2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c               |  29 ++++-
 drivers/hid/amd-sfh-hid/amd_sfh_client.c           |  55 ++++----
 drivers/hid/wacom_wac.c                            |   3 +-
 drivers/leds/led-triggers.c                        |  32 ++---
 drivers/leds/trigger/ledtrig-timer.c               |   5 -
 drivers/net/ethernet/intel/ice/ice_txrx.c          |   2 +-
 drivers/net/ethernet/intel/ice/ice_xsk.c           |  19 +--
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c    |   6 +-
 .../net/ethernet/mellanox/mlx5/core/en_ethtool.c   |   7 +-
 drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c |   5 +-
 drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c  |   2 +-
 drivers/net/ethernet/realtek/r8169_main.c          |   8 +-
 drivers/net/ethernet/xilinx/xilinx_axienet_main.c  |   2 +-
 drivers/net/usb/sr9700.c                           |  11 +-
 drivers/platform/chrome/cros_ec_proto.c            |   2 +
 fs/btrfs/block-group.c                             |  13 +-
 fs/btrfs/extent-tree.c                             |   3 +-
 fs/btrfs/free-space-cache.c                        |   4 +-
 fs/btrfs/space-info.c                              |   2 +-
 fs/btrfs/space-info.h                              |   1 +
 fs/ext4/extents.c                                  |   5 +-
 fs/ext4/extents_status.c                           |  14 +--
 fs/ext4/extents_status.h                           |   6 +-
 fs/ext4/inode.c                                    | 115 +++++++++--------
 fs/f2fs/segment.c                                  |   4 +-
 fs/file.c                                          |   1 +
 fs/proc/proc_sysctl.c                              |   8 +-
 include/linux/leds.h                               |  30 +++--
 include/linux/sysctl.h                             |   1 -
 include/trace/events/btrfs.h                       |   8 ++
 include/trace/events/mptcp.h                       |   2 +-
 init/Kconfig                                       |   1 +
 ipc/ipc_sysctl.c                                   |  36 +++++-
 ipc/mq_sysctl.c                                    |  35 ++++++
 kernel/irq/irqdomain.c                             |   7 +-
 mm/Kconfig                                         |  11 ++
 mm/page_alloc.c                                    |  19 ++-
 net/bluetooth/hci_sync.c                           |  21 ++++
 net/core/rtnetlink.c                               |   2 +-
 net/ipv4/netfilter/iptable_nat.c                   |  18 +--
 net/ipv6/ndisc.c                                   |  34 ++---
 net/ipv6/netfilter/ip6table_nat.c                  |  14 ++-
 net/iucv/af_iucv.c                                 |   4 +-
 net/mptcp/options.c                                |   2 +-
 net/mptcp/pm_netlink.c                             |  28 +++--
 net/mptcp/protocol.c                               |  18 +--
 net/mptcp/protocol.h                               |   1 +
 net/mptcp/subflow.c                                |  17 ++-
 net/netfilter/ipset/ip_set_list_set.c              |   3 +
 net/sched/act_ct.c                                 |   4 +-
 net/sysctl_net.c                                   |   1 -
 sound/firewire/amdtp-stream.c                      |  38 +++---
 sound/firewire/amdtp-stream.h                      |   1 +
 sound/pci/hda/hda_controller.h                     |   2 +-
 sound/pci/hda/hda_intel.c                          |  10 +-
 sound/pci/hda/patch_conexant.c                     |  58 ++-------
 sound/pci/hda/patch_realtek.c                      |   1 +
 sound/usb/stream.c                                 |   4 +-
 tools/testing/selftests/net/mptcp/mptcp_connect.c  |   8 +-
 78 files changed, 813 insertions(+), 587 deletions(-)


Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Guenter Roeck 1 year, 5 months ago
Hi,

On 8/8/24 02:11, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
> 
...
> Naohiro Aota <naohiro.aota@wdc.com>
>      btrfs: zoned: fix zone_unusable accounting on making block group read-write again
> 

This patch results in a variety of problems with the parisc64 qemu emulation.
Some examples from various test runs:

[   10.527204] alg: akcipher: test 1 failed for rsa-generic, err=-22
[   10.529743] alg: self-tests for rsa using rsa-generic failed (rc=-22)
[   10.529905] ------------[ cut here ]------------
[   10.530276] alg: self-tests for rsa using rsa-generic failed (rc=-22)
[   10.530732] WARNING: CPU: 0 PID: 50 at crypto/testmgr.c:5907 alg_test+0x618/0x688

[    7.420056] ==================================================================
[    7.420507] BUG: KFENCE: invalid read in walk_stackframe.isra.0+0xb4/0x138
[    7.420507]
[    7.420827] Invalid read at 0x0000000042f07000:
[    7.421037]  walk_stackframe.isra.0+0xb4/0x138
[    7.421204]  arch_stack_walk+0x38/0x50
[    7.421338]  stack_trace_save_regs+0x58/0x70
[    7.421498]  kfence_report_error+0x14c/0x730
[    7.421649]  kfence_handle_page_fault+0x2c8/0x2d0
[    7.421996]  handle_interruption+0x9b0/0xb58
[    7.422168]  intr_check_sig+0x0/0x3c

[    8.891194] =============================================================================
[    8.891558] BUG sgpool-32 (Tainted: G    B   W        N): Wrong object count. Counter is 3 but counted were 18

[    0.403174] =============================================================================
[    0.403568] BUG audit_buffer (Not tainted): Wrong object count. Counter is 1 but counted were 34

[    0.505914] =============================================================================
[    0.506258] BUG skbuff_head_cache (Tainted: G    B             ): Freechain corrupt

[    2.831636] =============================================================================
[    2.832144] BUG skbuff_head_cache (Tainted: G    B             ): Left Redzone overwritten

Reverting it fixes the problem.

Bisect log is attached for reference.


I tried to repeat the test with v6.1.105-rc1, but that fails to compile for parisc64.

/home/groeck/src/linux-stable/include/linux/slab.h:228: warning: "ARCH_KMALLOC_MINALIGN" redefined
   228 | #define ARCH_KMALLOC_MINALIGN ARCH_DMA_MINALIGN

This is due to commit 96423e23e05b ("parisc: fix a possible DMA corruption").
After reverting that patch I don't see the above problems anymore in v6.1.105-rc1,
so it looks like the btrfs patches in v6.1.105-rc1 may have fixed it (or maybe
there is another hidden bug in the parisc64 qemu emulation).

Guenter

---
# bad: [36790ef5e00b69ccb92817f95ba1928eea24eebb] Linux 6.1.104
# good: [48d525b0e4634c487cf46a41c1e2824e9ee258ce] Linux 6.1.103
git bisect start 'HEAD' 'v6.1.103'
# good: [d06daf0ad645d9225a3ff6958dd82e1f3988fa64] sched: act_ct: take care of padding in struct zones_ht_key
git bisect good d06daf0ad645d9225a3ff6958dd82e1f3988fa64
# good: [ed15fdf30736a255c0e4f5d0263e12cf6636fade] rust: SHADOW_CALL_STACK is incompatible with Rust
git bisect good ed15fdf30736a255c0e4f5d0263e12cf6636fade
# bad: [5670466033d14329aaa87e726a481a6c56892eff] drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()
git bisect bad 5670466033d14329aaa87e726a481a6c56892eff
# bad: [47ab33e1d6a796a82f9b7a70ed95c9649e92d7d2] mptcp: sched: check both directions for backup
git bisect bad 47ab33e1d6a796a82f9b7a70ed95c9649e92d7d2
# good: [8bb9cf2edf490e65678f2d57634ac763a778aeb6] HID: wacom: Modify pen IDs
git bisect good 8bb9cf2edf490e65678f2d57634ac763a778aeb6
# bad: [5db999fff545b924b24c9afd368ef5c17279b176] protect the fetch of ->fd[fd] in do_dup2() from mispredictions
git bisect bad 5db999fff545b924b24c9afd368ef5c17279b176
# bad: [36dac679722e5aa68c9efa822a38a5ea0c107342] btrfs: zoned: fix zone_unusable accounting on making block group read-
write again
git bisect bad 36dac679722e5aa68c9efa822a38a5ea0c107342
# first bad commit: [36dac679722e5aa68c9efa822a38a5ea0c107342] btrfs: zoned: fix zone_unusable accounting on making bloc
k group read-write again
Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Guenter Roeck 1 year, 5 months ago
On 8/12/24 14:49, Guenter Roeck wrote:
> Hi,
> 
> On 8/8/24 02:11, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 6.1.104 release.
>> There are 86 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>>     https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
>> or in the git tree and branch at:
>>     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
>> and the diffstat can be found below.
>>
> ...
>> Naohiro Aota <naohiro.aota@wdc.com>
>>      btrfs: zoned: fix zone_unusable accounting on making block group read-write again
>>
> 
> This patch results in a variety of problems with the parisc64 qemu emulation.
> Some examples from various test runs:
> 
> [   10.527204] alg: akcipher: test 1 failed for rsa-generic, err=-22
> [   10.529743] alg: self-tests for rsa using rsa-generic failed (rc=-22)
> [   10.529905] ------------[ cut here ]------------
> [   10.530276] alg: self-tests for rsa using rsa-generic failed (rc=-22)
> [   10.530732] WARNING: CPU: 0 PID: 50 at crypto/testmgr.c:5907 alg_test+0x618/0x688
> 
> [    7.420056] ==================================================================
> [    7.420507] BUG: KFENCE: invalid read in walk_stackframe.isra.0+0xb4/0x138
> [    7.420507]
> [    7.420827] Invalid read at 0x0000000042f07000:
> [    7.421037]  walk_stackframe.isra.0+0xb4/0x138
> [    7.421204]  arch_stack_walk+0x38/0x50
> [    7.421338]  stack_trace_save_regs+0x58/0x70
> [    7.421498]  kfence_report_error+0x14c/0x730
> [    7.421649]  kfence_handle_page_fault+0x2c8/0x2d0
> [    7.421996]  handle_interruption+0x9b0/0xb58
> [    7.422168]  intr_check_sig+0x0/0x3c
> 
> [    8.891194] =============================================================================
> [    8.891558] BUG sgpool-32 (Tainted: G    B   W        N): Wrong object count. Counter is 3 but counted were 18
> 
> [    0.403174] =============================================================================
> [    0.403568] BUG audit_buffer (Not tainted): Wrong object count. Counter is 1 but counted were 34
> 
> [    0.505914] =============================================================================
> [    0.506258] BUG skbuff_head_cache (Tainted: G    B             ): Freechain corrupt
> 
> [    2.831636] =============================================================================
> [    2.832144] BUG skbuff_head_cache (Tainted: G    B             ): Left Redzone overwritten
> 
> Reverting it fixes the problem.
> 
> Bisect log is attached for reference.
> 
> 
> I tried to repeat the test with v6.1.105-rc1, but that fails to compile for parisc64.
> 
> /home/groeck/src/linux-stable/include/linux/slab.h:228: warning: "ARCH_KMALLOC_MINALIGN" redefined
>    228 | #define ARCH_KMALLOC_MINALIGN ARCH_DMA_MINALIGN
> 
> This is due to commit 96423e23e05b ("parisc: fix a possible DMA corruption").
> After reverting that patch I don't see the above problems anymore in v6.1.105-rc1,
> so it looks like the btrfs patches in v6.1.105-rc1 may have fixed it (or maybe
> there is another hidden bug in the parisc64 qemu emulation).
> 

Oh, never mind. I did a reverse bisect on v6.1.105-rc1 (after fixing the build failure there),
and it points to an unrelated commit. Looks like another qemu emulation bug. Sorry for the noise.

Guenter

Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Florian Fainelli 1 year, 6 months ago
On 8/8/24 02:11, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h

On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on 
BMIPS_GENERIC:

Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian
Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Shreeya Patel 1 year, 6 months ago
 ---- On Thu, 08 Aug 2024 14:41:49 +0530  Greg Kroah-Hartman  wrote --- 
 > This is the start of the stable review cycle for the 6.1.104 release.
 > There are 86 patches in this series, all will be posted as a response
 > to this one.  If anyone has any issues with these being applied, please
 > let me know.
 > 
 > Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
 > Anything received after that time might be too late.
 > 
 > The whole patch series can be found in one patch at:
 >     https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
 > or in the git tree and branch at:
 >     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
 > and the diffstat can be found below.
 > 
 > thanks,
 > 
Date: 2024-08-07

## Build failures:

No **new** build failures seen for the stable-rc/linux-6.1.y commit head \o/

## Boot failures:

No **new** boot failures seen for the stable-rc/linux-6.1.y commit head \o/

Tested-by: kernelci.org bot <bot@kernelci.org>
Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Jon Hunter 1 year, 6 months ago
On Thu, 08 Aug 2024 11:11:49 +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h

All tests passing for Tegra ...

Test results for stable-v6.1:
    10 builds:	10 pass, 0 fail
    26 boots:	26 pass, 0 fail
    116 tests:	116 pass, 0 fail

Linux version:	6.1.104-rc2-g54b8e3a13b43
Boards tested:	tegra124-jetson-tk1, tegra186-p2771-0000,
                tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
                tegra20-ventana, tegra210-p2371-2180,
                tegra210-p3450-0000, tegra30-cardhu-a04

Tested-by: Jon Hunter <jonathanh@nvidia.com>

Jon
Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Peter Schneider 1 year, 6 months ago
Am 08.08.2024 um 11:11 schrieb Greg Kroah-Hartman:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.

Builds, boots and works on my 2-socket Ivy Bridge Xeon E5-2697 v2 server. No dmesg 
oddities or regressions found.

Tested-by: Peter Schneider <pschneider1968@googlemail.com>


Beste Grüße,
Peter Schneider

-- 
Climb the mountain not to plant your flag, but to embrace the challenge,
enjoy the air and behold the view. Climb it so you can see the world,
not so the world can see you.                    -- David McCullough Jr.

OpenPGP:  0xA3828BD796CCE11A8CADE8866E3A92C92C3FF244
Download: https://www.peters-netzplatz.de/download/pschneider1968_pub.asc
https://keys.mailvelope.com/pks/lookup?op=get&search=pschneider1968@googlemail.com
https://keys.mailvelope.com/pks/lookup?op=get&search=pschneider1968@gmail.com
Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Anders Roxell 1 year, 6 months ago
On Thu, 8 Aug 2024 at 11:11, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Results from Linaro's test farm.
No regressions on arm64, arm, x86_64, and i386.

Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>

## Build
* kernel: 6.1.104-rc2
* git: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
* git commit: 54b8e3a13b43747af658936db1fa59a365d52997
* git describe: v6.1.103-87-g54b8e3a13b43
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.103-87-g54b8e3a13b43

## Test Regressions (compared to v6.1.102-441-gdbbffaaee188)

## Metric Regressions (compared to v6.1.102-441-gdbbffaaee188)

## Test Fixes (compared to v6.1.102-441-gdbbffaaee188)

## Metric Fixes (compared to v6.1.102-441-gdbbffaaee188)

## Test result summary
total: 219072, pass: 188702, fail: 2594, skip: 27408, xfail: 368

## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 135 total, 135 passed, 0 failed
* arm64: 38 total, 38 passed, 0 failed
* i386: 28 total, 28 passed, 0 failed
* mips: 26 total, 25 passed, 1 failed
* parisc: 4 total, 3 passed, 1 failed
* powerpc: 36 total, 35 passed, 1 failed
* riscv: 11 total, 11 passed, 0 failed
* s390: 14 total, 12 passed, 2 failed
* sh: 10 total, 10 passed, 0 failed
* sparc: 7 total, 7 passed, 0 failed
* x86_64: 33 total, 33 passed, 0 failed

## Test suites summary
* boot
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-efivarfs
* kselftest-exec
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-filesystems-epoll
* kselftest-firmware
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-kcmp
* kselftest-kvm
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-mincore
* kselftest-mqueue
* kselftest-net
* kselftest-net-mptcp
* kselftest-openat2
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-tc-testing
* kselftest-timers
* kselftest-timesync-off
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user_events
* kselftest-vDSO
* kselftest-watchdog
* kselftest-x86
* kunit
* kvm-unit-tests
* libgpiod
* libhugetlbfs
* log-parser-boot
* log-parser-test
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-hugetlb
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-smoke
* ltp-smoketest
* ltp-syscalls
* ltp-tracing
* perf
* rcutorture

--
Linaro LKFT
https://lkft.linaro.org
Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Pavel Machek 1 year, 6 months ago
Hi!

> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.

CIP testing did not find any problems here:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-6.1.y

Tested-by: Pavel Machek (CIP) <pavel@denx.de>

Best regards,
                                                                Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Ron Economos 1 year, 6 months ago
On 8/8/24 2:11 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
I'm seeing a build failure.

sound/pci/hda/patch_conexant.c:273:10: error: ‘const struct 
hda_codec_ops’ has no member named ‘suspend’
   273 |         .suspend = cx_auto_suspend,
       |          ^~~~~~~
sound/pci/hda/patch_conexant.c:273:20: error: initialization of ‘void 
(*)(struct hda_codec *, hda_nid_t,  unsigned int)’ {aka ‘void (*)(struct 
hda_codec *, short unsigned int,  unsigned int)’} from incompatible 
pointer type ‘int (*)(struct hda_codec *)’ 
[-Werror=incompatible-pointer-types]
   273 |         .suspend = cx_auto_suspend,
       |                    ^~~~~~~~~~~~~~~
sound/pci/hda/patch_conexant.c:273:20: note: (near initialization for 
‘cx_auto_patch_ops.set_power_state’)
sound/pci/hda/patch_conexant.c:274:10: error: ‘const struct 
hda_codec_ops’ has no member named ‘check_power_status’; did you mean 
‘set_power_state’?
   274 |         .check_power_status = snd_hda_gen_check_power_status,
       |          ^~~~~~~~~~~~~~~~~~
       |          set_power_state
sound/pci/hda/patch_conexant.c:274:31: error: 
‘snd_hda_gen_check_power_status’ undeclared here (not in a function); 
did you mean ‘snd_hda_check_power_state’?
   274 |         .check_power_status = snd_hda_gen_check_power_status,
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       |                               snd_hda_check_power_state

This is triggered because my config does not include CONFIG_PM. But the 
error is caused by upstream patch 
9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce 
CONFIG_PM dependencies" being missing. This patch removes the #ifdef 
CONFIG_PM in the hda_codec_ops structure. So if CONFIG_PM is not set, 
some structure members are missing and the the build fails.

Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Ron Economos 1 year, 6 months ago
On 8/8/24 4:55 AM, Ron Economos wrote:
> On 8/8/24 2:11 AM, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 6.1.104 release.
>> There are 86 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>>     https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz 
>>
>> or in the git tree and branch at:
>>     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git 
>> linux-6.1.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>>
> I'm seeing a build failure.
>
> sound/pci/hda/patch_conexant.c:273:10: error: ‘const struct 
> hda_codec_ops’ has no member named ‘suspend’
>   273 |         .suspend = cx_auto_suspend,
>       |          ^~~~~~~
> sound/pci/hda/patch_conexant.c:273:20: error: initialization of ‘void 
> (*)(struct hda_codec *, hda_nid_t,  unsigned int)’ {aka ‘void 
> (*)(struct hda_codec *, short unsigned int,  unsigned int)’} from 
> incompatible pointer type ‘int (*)(struct hda_codec *)’ 
> [-Werror=incompatible-pointer-types]
>   273 |         .suspend = cx_auto_suspend,
>       |                    ^~~~~~~~~~~~~~~
> sound/pci/hda/patch_conexant.c:273:20: note: (near initialization for 
> ‘cx_auto_patch_ops.set_power_state’)
> sound/pci/hda/patch_conexant.c:274:10: error: ‘const struct 
> hda_codec_ops’ has no member named ‘check_power_status’; did you mean 
> ‘set_power_state’?
>   274 |         .check_power_status = snd_hda_gen_check_power_status,
>       |          ^~~~~~~~~~~~~~~~~~
>       |          set_power_state
> sound/pci/hda/patch_conexant.c:274:31: error: 
> ‘snd_hda_gen_check_power_status’ undeclared here (not in a function); 
> did you mean ‘snd_hda_check_power_state’?
>   274 |         .check_power_status = snd_hda_gen_check_power_status,
>       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                               snd_hda_check_power_state
>
> This is triggered because my config does not include CONFIG_PM. But 
> the error is caused by upstream patch 
> 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce 
> CONFIG_PM dependencies" being missing. This patch removes the #ifdef 
> CONFIG_PM in the hda_codec_ops structure. So if CONFIG_PM is not set, 
> some structure members are missing and the the build fails.
>
>
Same failure occurs in 6.6.45-rc1 if CONFIG_PM is not set.

Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Ron Economos 1 year, 6 months ago
On 8/8/24 7:43 AM, Ron Economos wrote:
> On 8/8/24 4:55 AM, Ron Economos wrote:
>> On 8/8/24 2:11 AM, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 6.1.104 release.
>>> There are 86 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>>     https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz 
>>>
>>> or in the git tree and branch at:
>>>     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git 
>>> linux-6.1.y
>>> and the diffstat can be found below.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>> I'm seeing a build failure.
>>
>> sound/pci/hda/patch_conexant.c:273:10: error: ‘const struct 
>> hda_codec_ops’ has no member named ‘suspend’
>>   273 |         .suspend = cx_auto_suspend,
>>       |          ^~~~~~~
>> sound/pci/hda/patch_conexant.c:273:20: error: initialization of ‘void 
>> (*)(struct hda_codec *, hda_nid_t,  unsigned int)’ {aka ‘void 
>> (*)(struct hda_codec *, short unsigned int,  unsigned int)’} from 
>> incompatible pointer type ‘int (*)(struct hda_codec *)’ 
>> [-Werror=incompatible-pointer-types]
>>   273 |         .suspend = cx_auto_suspend,
>>       |                    ^~~~~~~~~~~~~~~
>> sound/pci/hda/patch_conexant.c:273:20: note: (near initialization for 
>> ‘cx_auto_patch_ops.set_power_state’)
>> sound/pci/hda/patch_conexant.c:274:10: error: ‘const struct 
>> hda_codec_ops’ has no member named ‘check_power_status’; did you mean 
>> ‘set_power_state’?
>>   274 |         .check_power_status = snd_hda_gen_check_power_status,
>>       |          ^~~~~~~~~~~~~~~~~~
>>       |          set_power_state
>> sound/pci/hda/patch_conexant.c:274:31: error: 
>> ‘snd_hda_gen_check_power_status’ undeclared here (not in a function); 
>> did you mean ‘snd_hda_check_power_state’?
>>   274 |         .check_power_status = snd_hda_gen_check_power_status,
>>       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>       |                               snd_hda_check_power_state
>>
>> This is triggered because my config does not include CONFIG_PM. But 
>> the error is caused by upstream patch 
>> 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce 
>> CONFIG_PM dependencies" being missing. This patch removes the #ifdef 
>> CONFIG_PM in the hda_codec_ops structure. So if CONFIG_PM is not set, 
>> some structure members are missing and the the build fails.
>>
>>
> Same failure occurs in 6.6.45-rc1 if CONFIG_PM is not set.
>
>
Note: Both upstream 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: 
codec: Reduce CONFIG_PM dependencies" and 
6c8fd3499423fc3ebb735f32d4a52bc5825f6301 "ALSA: hda: generic: Reduce 
CONFIG_PM dependencies" are required to fix the build if CONFIG_PM is 
not set.

Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Greg Kroah-Hartman 1 year, 6 months ago
On Thu, Aug 08, 2024 at 09:45:57AM -0700, Ron Economos wrote:
> On 8/8/24 7:43 AM, Ron Economos wrote:
> > On 8/8/24 4:55 AM, Ron Economos wrote:
> > > On 8/8/24 2:11 AM, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 6.1.104 release.
> > > > There are 86 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> > > > Anything received after that time might be too late.
> > > > 
> > > > The whole patch series can be found in one patch at:
> > > >     https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.104-rc2.gz
> > > > 
> > > > or in the git tree and branch at:
> > > >     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> > > > linux-6.1.y
> > > > and the diffstat can be found below.
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > > 
> > > I'm seeing a build failure.
> > > 
> > > sound/pci/hda/patch_conexant.c:273:10: error: ‘const struct
> > > hda_codec_ops’ has no member named ‘suspend’
> > >   273 |         .suspend = cx_auto_suspend,
> > >       |          ^~~~~~~
> > > sound/pci/hda/patch_conexant.c:273:20: error: initialization of
> > > ‘void (*)(struct hda_codec *, hda_nid_t,  unsigned int)’ {aka ‘void
> > > (*)(struct hda_codec *, short unsigned int,  unsigned int)’} from
> > > incompatible pointer type ‘int (*)(struct hda_codec *)’
> > > [-Werror=incompatible-pointer-types]
> > >   273 |         .suspend = cx_auto_suspend,
> > >       |                    ^~~~~~~~~~~~~~~
> > > sound/pci/hda/patch_conexant.c:273:20: note: (near initialization
> > > for ‘cx_auto_patch_ops.set_power_state’)
> > > sound/pci/hda/patch_conexant.c:274:10: error: ‘const struct
> > > hda_codec_ops’ has no member named ‘check_power_status’; did you
> > > mean ‘set_power_state’?
> > >   274 |         .check_power_status = snd_hda_gen_check_power_status,
> > >       |          ^~~~~~~~~~~~~~~~~~
> > >       |          set_power_state
> > > sound/pci/hda/patch_conexant.c:274:31: error:
> > > ‘snd_hda_gen_check_power_status’ undeclared here (not in a
> > > function); did you mean ‘snd_hda_check_power_state’?
> > >   274 |         .check_power_status = snd_hda_gen_check_power_status,
> > >       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >       |                               snd_hda_check_power_state
> > > 
> > > This is triggered because my config does not include CONFIG_PM. But
> > > the error is caused by upstream patch
> > > 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda: codec: Reduce
> > > CONFIG_PM dependencies" being missing. This patch removes the #ifdef
> > > CONFIG_PM in the hda_codec_ops structure. So if CONFIG_PM is not
> > > set, some structure members are missing and the the build fails.
> > > 
> > > 
> > Same failure occurs in 6.6.45-rc1 if CONFIG_PM is not set.
> > 
> > 
> Note: Both upstream 9e993b3d722fb452e274e1f8694d8940db183323 "ALSA: hda:
> codec: Reduce CONFIG_PM dependencies" and
> 6c8fd3499423fc3ebb735f32d4a52bc5825f6301 "ALSA: hda: generic: Reduce
> CONFIG_PM dependencies" are required to fix the build if CONFIG_PM is not
> set.

thanks, I have fixed this all now up.

greg k-h
Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Miguel Ojeda 1 year, 6 months ago
On Thu, 08 Aug 2024 11:11:49 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> Anything received after that time might be too late.

Boot-tested under QEMU for Rust x86_64:

Tested-by: Miguel Ojeda <ojeda@kernel.org>

Thanks!

Cheers,
Miguel
Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Salvatore Bonaccorso 1 year, 6 months ago
Hi Greg,

On Thu, Aug 08, 2024 at 11:11:49AM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.1.104 release.
> There are 86 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> Anything received after that time might be too late.

Sorry for bothering you again with it (see previous comment on
6.1.103, respectively 6.1.104-rc1): bpftool still would fail to
compile:

gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS -c -MMD prog.c -o prog.o
prog.c: In function ‘load_with_options’:
prog.c:1710:23: warning: implicit declaration of function ‘create_and_mount_bpffs_dir’ [-Wimplicit-function-declaration]
 1710 |                 err = create_and_mount_bpffs_dir(pinmaps);
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~
gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS  btf.o btf_dumper.o cfg.o cgroup.o common.o feature.o gen.o iter.o json_writer.o link.o main.o map.o map_perf_ring.o net.o netlink_dumper.o perf.o pids.o prog.o struct_ops.o tracelog.o xlated_dumper.o disasm.o /home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/libbpf.a -lelf -lz -lcap -o bpftool
/bin/ld: prog.o: in function `load_with_options':
prog.c:(.text+0x2f98): undefined reference to `create_and_mount_bpffs_dir'
/bin/ld: prog.c:(.text+0x2ff2): undefined reference to `create_and_mount_bpffs_dir'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:216: bpftool] Error 1
make: *** [Makefile:113: bpftool] Error 2

Reverting 65dd9cbafec2f6f7908cebcab0386f750fc352af fixes the issue. In
fact 65dd9cbafec2f6f7908cebcab0386f750fc352af is the only commit
adding call to create_and_mount_bpffs_dir:

$ git grep create_and_mount_bpffs_dir
tools/bpf/bpftool/prog.c:               err = create_and_mount_bpffs_dir(pinmaps);

Regards,
Salvatore
Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Salvatore Bonaccorso 1 year, 6 months ago
Hi Greg,

[adding as well people involved in the original commit and the
backporting for 6.1.y branch]

On Thu, Aug 08, 2024 at 12:33:22PM +0200, Salvatore Bonaccorso wrote:
> Hi Greg,
> 
> On Thu, Aug 08, 2024 at 11:11:49AM +0200, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.1.104 release.
> > There are 86 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> > Anything received after that time might be too late.
> 
> Sorry for bothering you again with it (see previous comment on
> 6.1.103, respectively 6.1.104-rc1): bpftool still would fail to
> compile:
> 
> gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS -c -MMD prog.c -o prog.o
> prog.c: In function ‘load_with_options’:
> prog.c:1710:23: warning: implicit declaration of function ‘create_and_mount_bpffs_dir’ [-Wimplicit-function-declaration]
>  1710 |                 err = create_and_mount_bpffs_dir(pinmaps);
>       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~
> gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS  btf.o btf_dumper.o cfg.o cgroup.o common.o feature.o gen.o iter.o json_writer.o link.o main.o map.o map_perf_ring.o net.o netlink_dumper.o perf.o pids.o prog.o struct_ops.o tracelog.o xlated_dumper.o disasm.o /home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/libbpf.a -lelf -lz -lcap -o bpftool
> /bin/ld: prog.o: in function `load_with_options':
> prog.c:(.text+0x2f98): undefined reference to `create_and_mount_bpffs_dir'
> /bin/ld: prog.c:(.text+0x2ff2): undefined reference to `create_and_mount_bpffs_dir'
> collect2: error: ld returned 1 exit status
> make[1]: *** [Makefile:216: bpftool] Error 1
> make: *** [Makefile:113: bpftool] Error 2
> 
> Reverting 65dd9cbafec2f6f7908cebcab0386f750fc352af fixes the issue. In
> fact 65dd9cbafec2f6f7908cebcab0386f750fc352af is the only commit
> adding call to create_and_mount_bpffs_dir:
> 
> $ git grep create_and_mount_bpffs_dir
> tools/bpf/bpftool/prog.c:               err = create_and_mount_bpffs_dir(pinmaps);

Just one additional note, at least 478a535ae54a ("bpftool: Mount bpffs
on provided dir instead of parent dir") would be a reqisite where the
code was refactored introducing create_and_mount_bpffs_dir() (but
won't apply cleanly to 6.1.y). But are more requisites needed?

Should it be safest to just revert the breaking commit for the bpftool
build?

Regards,
Salvatore
Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Quentin Monnet 1 year, 6 months ago
2024-08-10 07:02 UTC+0200 ~ Salvatore Bonaccorso <carnil@debian.org>
> Hi Greg,
> 
> [adding as well people involved in the original commit and the
> backporting for 6.1.y branch]
> 
> On Thu, Aug 08, 2024 at 12:33:22PM +0200, Salvatore Bonaccorso wrote:
>> Hi Greg,
>>
>> On Thu, Aug 08, 2024 at 11:11:49AM +0200, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 6.1.104 release.
>>> There are 86 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
>>> Anything received after that time might be too late.
>>
>> Sorry for bothering you again with it (see previous comment on
>> 6.1.103, respectively 6.1.104-rc1): bpftool still would fail to
>> compile:
>>
>> gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS -c -MMD prog.c -o prog.o
>> prog.c: In function ‘load_with_options’:
>> prog.c:1710:23: warning: implicit declaration of function ‘create_and_mount_bpffs_dir’ [-Wimplicit-function-declaration]
>>  1710 |                 err = create_and_mount_bpffs_dir(pinmaps);
>>       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS  btf.o btf_dumper.o cfg.o cgroup.o common.o feature.o gen.o iter.o json_writer.o link.o main.o map.o map_perf_ring.o net.o netlink_dumper.o perf.o pids.o prog.o struct_ops.o tracelog.o xlated_dumper.o disasm.o /home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/libbpf.a -lelf -lz -lcap -o bpftool
>> /bin/ld: prog.o: in function `load_with_options':
>> prog.c:(.text+0x2f98): undefined reference to `create_and_mount_bpffs_dir'
>> /bin/ld: prog.c:(.text+0x2ff2): undefined reference to `create_and_mount_bpffs_dir'
>> collect2: error: ld returned 1 exit status
>> make[1]: *** [Makefile:216: bpftool] Error 1
>> make: *** [Makefile:113: bpftool] Error 2
>>
>> Reverting 65dd9cbafec2f6f7908cebcab0386f750fc352af fixes the issue. In
>> fact 65dd9cbafec2f6f7908cebcab0386f750fc352af is the only commit
>> adding call to create_and_mount_bpffs_dir:
>>
>> $ git grep create_and_mount_bpffs_dir
>> tools/bpf/bpftool/prog.c:               err = create_and_mount_bpffs_dir(pinmaps);
> 
> Just one additional note, at least 478a535ae54a ("bpftool: Mount bpffs
> on provided dir instead of parent dir") would be a reqisite where the
> code was refactored introducing create_and_mount_bpffs_dir() (but
> won't apply cleanly to 6.1.y). But are more requisites needed?
> 
> Should it be safest to just revert the breaking commit for the bpftool
> build?
> 
> Regards,
> Salvatore
> 

Hi,

You should be able to fix the build by first cherry-picking commit
2a36c26fe3b8 ("bpftool: Support bpffs mountpoint as pin path for prog
loadall"), and then commit 478a535ae54a ("bpftool: Mount bpffs on
provided dir instead of parent dir") as you figured. Both commits have a
minor conflict on tools/bpf/bpftool/struct_ops.c, which should be
addressed by discarding the relevant hunk (for both commit).

Alternatively, it's also fine to revert the breaking commit. It's a
quality of life improvement without which users may have to manually
mount the bpffs at the location they want to pin their maps when loading
multiple BPF programs with "bpftool prog loadall", in the unlikely event
they're not using /sys/kernel/bpf, prior to running the bpftool command.
It's not in use during the kernel build process or for the BPF
selftests, so not necessary on stable branches.

I hope this helps,
Quentin
Re: [PATCH 6.1 00/86] 6.1.104-rc2 review
Posted by Greg Kroah-Hartman 1 year, 6 months ago
On Sat, Aug 10, 2024 at 10:36:20PM +0100, Quentin Monnet wrote:
> 2024-08-10 07:02 UTC+0200 ~ Salvatore Bonaccorso <carnil@debian.org>
> > Hi Greg,
> > 
> > [adding as well people involved in the original commit and the
> > backporting for 6.1.y branch]
> > 
> > On Thu, Aug 08, 2024 at 12:33:22PM +0200, Salvatore Bonaccorso wrote:
> >> Hi Greg,
> >>
> >> On Thu, Aug 08, 2024 at 11:11:49AM +0200, Greg Kroah-Hartman wrote:
> >>> This is the start of the stable review cycle for the 6.1.104 release.
> >>> There are 86 patches in this series, all will be posted as a response
> >>> to this one.  If anyone has any issues with these being applied, please
> >>> let me know.
> >>>
> >>> Responses should be made by Sat, 10 Aug 2024 09:11:02 +0000.
> >>> Anything received after that time might be too late.
> >>
> >> Sorry for bothering you again with it (see previous comment on
> >> 6.1.103, respectively 6.1.104-rc1): bpftool still would fail to
> >> compile:
> >>
> >> gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS -c -MMD prog.c -o prog.o
> >> prog.c: In function ‘load_with_options’:
> >> prog.c:1710:23: warning: implicit declaration of function ‘create_and_mount_bpffs_dir’ [-Wimplicit-function-declaration]
> >>  1710 |                 err = create_and_mount_bpffs_dir(pinmaps);
> >>       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~
> >> gcc -O2 -W -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wbad-function-cast -Wdeclaration-after-statement -Wformat-security -Wformat-y2k -Winit-self -Wmissing-declarations -Wmissing-prototypes -Wno-system-headers -Wold-style-definition -Wpacked -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wundef -Wwrite-strings -Wformat -Wno-type-limits -Wstrict-aliasing=3 -Wshadow -DPACKAGE='"bpftool"' -D__EXPORTED_HEADERS__ -I. -I/home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/include -I/home/build/linux-stable-rc/kernel/bpf/ -I/home/build/linux-stable-rc/tools/include -I/home/build/linux-stable-rc/tools/include/uapi -DUSE_LIBCAP -DBPFTOOL_WITHOUT_SKELETONS  btf.o btf_dumper.o cfg.o cgroup.o common.o feature.o gen.o iter.o json_writer.o link.o main.o map.o map_perf_ring.o net.o netlink_dumper.o perf.o pids.o prog.o struct_ops.o tracelog.o xlated_dumper.o disasm.o /home/build/linux-stable-rc/tools/bpf/bpftool/libbpf/libbpf.a -lelf -lz -lcap -o bpftool
> >> /bin/ld: prog.o: in function `load_with_options':
> >> prog.c:(.text+0x2f98): undefined reference to `create_and_mount_bpffs_dir'
> >> /bin/ld: prog.c:(.text+0x2ff2): undefined reference to `create_and_mount_bpffs_dir'
> >> collect2: error: ld returned 1 exit status
> >> make[1]: *** [Makefile:216: bpftool] Error 1
> >> make: *** [Makefile:113: bpftool] Error 2
> >>
> >> Reverting 65dd9cbafec2f6f7908cebcab0386f750fc352af fixes the issue. In
> >> fact 65dd9cbafec2f6f7908cebcab0386f750fc352af is the only commit
> >> adding call to create_and_mount_bpffs_dir:
> >>
> >> $ git grep create_and_mount_bpffs_dir
> >> tools/bpf/bpftool/prog.c:               err = create_and_mount_bpffs_dir(pinmaps);
> > 
> > Just one additional note, at least 478a535ae54a ("bpftool: Mount bpffs
> > on provided dir instead of parent dir") would be a reqisite where the
> > code was refactored introducing create_and_mount_bpffs_dir() (but
> > won't apply cleanly to 6.1.y). But are more requisites needed?
> > 
> > Should it be safest to just revert the breaking commit for the bpftool
> > build?
> > 
> > Regards,
> > Salvatore
> > 
> 
> Hi,
> 
> You should be able to fix the build by first cherry-picking commit
> 2a36c26fe3b8 ("bpftool: Support bpffs mountpoint as pin path for prog
> loadall"),

That commit does not apply cleanly :(

I'll just go revert the original here, that makes it simpler overall.

thanks,

greg k-h