[PATCH] scsi: snic: Avoid creating two slab caches with the same name

Pedro Falcato posted 1 patch 1 year, 4 months ago
drivers/scsi/snic/snic_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] scsi: snic: Avoid creating two slab caches with the same name
Posted by Pedro Falcato 1 year, 4 months ago
In the spirit of [1], fix the copy-paste typo and use unique names for
both caches.

[1]: https://lore.kernel.org/all/20240807090746.2146479-1-pedro.falcato@gmail.com/
Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
---
 drivers/scsi/snic/snic_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/snic/snic_main.c b/drivers/scsi/snic/snic_main.c
index cc824dcfe7d..abc78320c66 100644
--- a/drivers/scsi/snic/snic_main.c
+++ b/drivers/scsi/snic/snic_main.c
@@ -873,7 +873,7 @@ snic_global_data_init(void)
 	snic_glob->req_cache[SNIC_REQ_CACHE_MAX_SGL] = cachep;
 
 	len = sizeof(struct snic_host_req);
-	cachep = kmem_cache_create("snic_req_maxsgl", len, SNIC_SG_DESC_ALIGN,
+	cachep = kmem_cache_create("snic_req_tm", len, SNIC_SG_DESC_ALIGN,
 				   SLAB_HWCACHE_ALIGN, NULL);
 	if (!cachep) {
 		SNIC_ERR("Failed to create snic tm req slab\n");
-- 
2.46.0
Re: [PATCH] scsi: snic: Avoid creating two slab caches with the same name
Posted by Martin K. Petersen 1 year, 4 months ago
On Wed, 07 Aug 2024 10:57:09 +0100, Pedro Falcato wrote:

> In the spirit of [1], fix the copy-paste typo and use unique names for
> both caches.
> 
> [1]: https://lore.kernel.org/all/20240807090746.2146479-1-pedro.falcato@gmail.com/
> 
> 

Applied to 6.12/scsi-queue, thanks!

[1/1] scsi: snic: Avoid creating two slab caches with the same name
      https://git.kernel.org/mkp/scsi/c/ff30732014f5

-- 
Martin K. Petersen	Oracle Linux Engineering
Re: [PATCH] scsi: snic: Avoid creating two slab caches with the same name
Posted by Martin K. Petersen 1 year, 4 months ago
Pedro,

> In the spirit of [1], fix the copy-paste typo and use unique names for
> both caches.

Applied to 6.12/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering