Documentation/filesystems/bcachefs/CodingStyle.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Signed-off-by: Xiaxi Shen <shenxiaxi26@gmail.com>
---
Documentation/filesystems/bcachefs/CodingStyle.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/filesystems/bcachefs/CodingStyle.rst b/Documentation/filesystems/bcachefs/CodingStyle.rst
index 0c45829a4899..01de555e21d8 100644
--- a/Documentation/filesystems/bcachefs/CodingStyle.rst
+++ b/Documentation/filesystems/bcachefs/CodingStyle.rst
@@ -175,7 +175,7 @@ errors in our thinking by running our code and seeing what happens. If your
time is being wasted because your tools are bad or too slow - don't accept it,
fix it.
-Put effort into your documentation, commmit messages, and code comments - but
+Put effort into your documentation, commit messages, and code comments - but
don't go overboard. A good commit message is wonderful - but if the information
was important enough to go in a commit message, ask yourself if it would be
even better as a code comment.
--
2.34.1
On 8/7/24 01:10, Xiaxi Shen wrote: Missing commit message -- > Signed-off-by: Xiaxi Shen <shenxiaxi26@gmail.com> > --- > Documentation/filesystems/bcachefs/CodingStyle.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/filesystems/bcachefs/CodingStyle.rst b/Documentation/filesystems/bcachefs/CodingStyle.rst > index 0c45829a4899..01de555e21d8 100644 > --- a/Documentation/filesystems/bcachefs/CodingStyle.rst > +++ b/Documentation/filesystems/bcachefs/CodingStyle.rst > @@ -175,7 +175,7 @@ errors in our thinking by running our code and seeing what happens. If your > time is being wasted because your tools are bad or too slow - don't accept it, > fix it. > > -Put effort into your documentation, commmit messages, and code comments - but > +Put effort into your documentation, commit messages, and code comments - but > don't go overboard. A good commit message is wonderful - but if the information > was important enough to go in a commit message, ask yourself if it would be > even better as a code comment. thanks, -- Shuah
On Wed, Aug 07, 2024 at 09:42:12AM GMT, Shuah Khan wrote: > On 8/7/24 01:10, Xiaxi Shen wrote: > > Missing commit message -- I wasn't going to commit this, because I don't like taking patches that do nothing more than fix spelling, but since it in fact does not need a commit message for something so trivial I am applying it.
On 8/7/24 10:06, Kent Overstreet wrote: > On Wed, Aug 07, 2024 at 09:42:12AM GMT, Shuah Khan wrote: >> On 8/7/24 01:10, Xiaxi Shen wrote: >> >> Missing commit message -- > > I wasn't going to commit this, because I don't like taking patches that > do nothing more than fix spelling, but since it in fact does not need a > commit message for something so trivial I am applying it. Sure. Your preference. I don't accept patches without commit message even if it is trivial. thanks, -- Shuah
© 2016 - 2025 Red Hat, Inc.