[PATCH 7/8] mm: Introduce promo_wmark_pages()

Kirill A. Shutemov posted 8 patches 1 year, 4 months ago
There is a newer version of this series
[PATCH 7/8] mm: Introduce promo_wmark_pages()
Posted by Kirill A. Shutemov 1 year, 4 months ago
Add promo_wmark_pages() helper to complement other zone watermark
accessors.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
 include/linux/mmzone.h | 1 +
 kernel/sched/fair.c    | 2 +-
 mm/vmscan.c            | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 41458892bc8a..eb4ec70f6d53 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -671,6 +671,7 @@ enum zone_watermarks {
 #define min_wmark_pages(z) (z->_watermark[WMARK_MIN] + z->watermark_boost)
 #define low_wmark_pages(z) (z->_watermark[WMARK_LOW] + z->watermark_boost)
 #define high_wmark_pages(z) (z->_watermark[WMARK_HIGH] + z->watermark_boost)
+#define promo_wmark_pages(z) (z->_watermark[WMARK_PROMO] + z->watermark_boost)
 #define wmark_pages(z, i) (z->_watermark[i] + z->watermark_boost)
 
 /*
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 9057584ec06d..6b2a032ba0c6 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1742,7 +1742,7 @@ static bool pgdat_free_space_enough(struct pglist_data *pgdat)
 			continue;
 
 		if (zone_watermark_ok(zone, 0,
-				      wmark_pages(zone, WMARK_PROMO) + enough_wmark,
+				      promo_wmark_pages(zone) + enough_wmark,
 				      ZONE_MOVABLE, 0))
 			return true;
 	}
diff --git a/mm/vmscan.c b/mm/vmscan.c
index cfa839284b92..ad6473eaec28 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -6664,7 +6664,7 @@ static bool pgdat_balanced(pg_data_t *pgdat, int order, int highest_zoneidx)
 			continue;
 
 		if (sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING)
-			mark = wmark_pages(zone, WMARK_PROMO);
+			mark = promo_wmark_pages(zone);
 		else
 			mark = high_wmark_pages(zone);
 		if (zone_watermark_ok_safe(zone, order, mark, highest_zoneidx))
-- 
2.43.0
Re: [PATCH 7/8] mm: Introduce promo_wmark_pages()
Posted by Johannes Weiner 1 year, 4 months ago
Hello Kirill,

On Mon, Aug 05, 2024 at 05:59:39PM +0300, Kirill A. Shutemov wrote:
> Add promo_wmark_pages() helper to complement other zone watermark
> accessors.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

Andrew picked up a change that does this a few days ago:

https://lore.kernel.org/all/20240801232548.36604-2-kaiyang2@cs.cmu.edu/T/#u
Re: [PATCH 7/8] mm: Introduce promo_wmark_pages()
Posted by Kirill A. Shutemov 1 year, 4 months ago
On Mon, Aug 05, 2024 at 01:04:42PM -0400, Johannes Weiner wrote:
> Hello Kirill,
> 
> On Mon, Aug 05, 2024 at 05:59:39PM +0300, Kirill A. Shutemov wrote:
> > Add promo_wmark_pages() helper to complement other zone watermark
> > accessors.
> > 
> > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> 
> Andrew picked up a change that does this a few days ago:
> 
> https://lore.kernel.org/all/20240801232548.36604-2-kaiyang2@cs.cmu.edu/T/#u

Ah. Great. I'll drop the patch.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov