[PATCH 00/13] tty: random fixes and cleanups

Jiri Slaby (SUSE) posted 13 patches 1 year, 4 months ago
There is a newer version of this series
drivers/net/hamradio/6pack.c         |  60 ++++--------
drivers/net/mctp/mctp-serial.c       |  23 ++---
drivers/tty/mxser.c                  |   5 -
drivers/tty/serial/8250/8250_dwlib.c |   2 +-
drivers/tty/serial/8250/8250_exar.c  |   2 +-
drivers/tty/serial/8250/8250_pci.c   |   2 +-
drivers/tty/serial/8250/8250_port.c  |   4 +-
drivers/tty/serial/serial_core.c     | 140 ++++++++++++---------------
drivers/tty/tty_io.c                 |  11 +--
include/linux/serial_8250.h          |   2 +-
10 files changed, 103 insertions(+), 148 deletions(-)
[PATCH 00/13] tty: random fixes and cleanups
Posted by Jiri Slaby (SUSE) 1 year, 4 months ago
Hi,

this is a series of locally accumulated patches over past months.

The series:
* makes mctp and 6pack use u8s,
* cleans up 6pack a bit,
* fixes two coverity reports,
* uses guard() to make some of the tty function easier to follow.

Cc: Andreas Koensgen <ajk@comnets.uni-bremen.de>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: linux-hams@vger.kernel.org
Cc: Matt Johnston <matt@codeconstruct.com.au>
Cc: netdev@vger.kernel.org
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Peter Hurley <peter@hurleysoftware.com>


Jiri Slaby (SUSE) (13):
  tty: simplify tty_dev_name_to_number() using guard(mutex)
  serial: protect uart_port_dtr_rts() in uart_shutdown() too
  serial: don't use uninitialized value in uart_poll_init()
  serial: remove quot_frac from serial8250_do_set_divisor()
  serial: use guards for simple mutex locks
  mxser: remove stale comment
  mxser: remove doubled sets of close times
  mctp: serial: propagage new tty types
  6pack: remove sixpack::rbuff
  6pack: drop sixpack::mtu
  6pack: drop sixpack::buffsize
  6pack: remove global strings
  6pack: propagage new tty types

 drivers/net/hamradio/6pack.c         |  60 ++++--------
 drivers/net/mctp/mctp-serial.c       |  23 ++---
 drivers/tty/mxser.c                  |   5 -
 drivers/tty/serial/8250/8250_dwlib.c |   2 +-
 drivers/tty/serial/8250/8250_exar.c  |   2 +-
 drivers/tty/serial/8250/8250_pci.c   |   2 +-
 drivers/tty/serial/8250/8250_port.c  |   4 +-
 drivers/tty/serial/serial_core.c     | 140 ++++++++++++---------------
 drivers/tty/tty_io.c                 |  11 +--
 include/linux/serial_8250.h          |   2 +-
 10 files changed, 103 insertions(+), 148 deletions(-)

-- 
2.46.0

Re: [PATCH 00/13] tty: random fixes and cleanups
Posted by Greg KH 1 year, 4 months ago
On Mon, Aug 05, 2024 at 12:20:33PM +0200, Jiri Slaby (SUSE) wrote:
> Hi,
> 
> this is a series of locally accumulated patches over past months.
> 
> The series:
> * makes mctp and 6pack use u8s,
> * cleans up 6pack a bit,
> * fixes two coverity reports,
> * uses guard() to make some of the tty function easier to follow.

This series breaks the build for me:

drivers/tty/serial/serial_core.c: In function ‘uart_suspend_port’:
drivers/tty/serial/serial_core.c:2400:17: error: label ‘unlock’ used but not defined
 2400 |                 goto unlock;
      |                 ^~~~
make[5]: *** [scripts/Makefile.build:244: drivers/tty/serial/serial_core.o] Error 1
make[5]: *** Waiting for unfinished jobs....