1. Patchew
  2. linux
  3. View series

[PATCH net-next] net: veth: Disable netpoll support

Breno Leitao posted 1 patch 1 year, 4 months ago 
drivers/net/veth.c | 1 +
1 file changed, 1 insertion(+)
[PATCH net-next] net: veth: Disable netpoll support
Posted by Breno Leitao 1 year, 4 months ago 
The current implementation of netpoll in veth devices leads to
suboptimal behavior, as it triggers warnings due to the invocation of
__netif_rx() within a softirq context. This is not compliant with
expected practices, as __netif_rx() has the following statement:

	lockdep_assert_once(hardirq_count() | softirq_count());

Given that veth devices typically do not benefit from the
functionalities provided by netpoll, Disable netpoll for veth
interfaces.

Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/veth.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index 426e68a95067..34499b91a8bd 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -1696,6 +1696,7 @@ static void veth_setup(struct net_device *dev)
 	dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
 	dev->priv_flags |= IFF_NO_QUEUE;
 	dev->priv_flags |= IFF_PHONY_HEADROOM;
+	dev->priv_flags |= IFF_DISABLE_NETPOLL;
 
 	dev->netdev_ops = &veth_netdev_ops;
 	dev->xdp_metadata_ops = &veth_xdp_metadata_ops;
-- 
2.43.0
Re: [PATCH net-next] net: veth: Disable netpoll support
Posted by Fabian Grünbichler 2 weeks, 1 day ago 
On August 5, 2024 11:40 am, Breno Leitao wrote:
> The current implementation of netpoll in veth devices leads to
> suboptimal behavior, as it triggers warnings due to the invocation of
> __netif_rx() within a softirq context. This is not compliant with
> expected practices, as __netif_rx() has the following statement:
> 
> 	lockdep_assert_once(hardirq_count() | softirq_count());
> 
> Given that veth devices typically do not benefit from the
> functionalities provided by netpoll, Disable netpoll for veth
> interfaces.

this patch seems to have broken combining netconsole and bridges with
veth ports:

https://bugzilla.proxmox.com/show_bug.cgi?id=6873

any chance this is solvable?

> 
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  drivers/net/veth.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/veth.c b/drivers/net/veth.c
> index 426e68a95067..34499b91a8bd 100644
> --- a/drivers/net/veth.c
> +++ b/drivers/net/veth.c
> @@ -1696,6 +1696,7 @@ static void veth_setup(struct net_device *dev)
>  	dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
>  	dev->priv_flags |= IFF_NO_QUEUE;
>  	dev->priv_flags |= IFF_PHONY_HEADROOM;
> +	dev->priv_flags |= IFF_DISABLE_NETPOLL;
>  
>  	dev->netdev_ops = &veth_netdev_ops;
>  	dev->xdp_metadata_ops = &veth_xdp_metadata_ops;
> -- 
> 2.43.0
> 
> 
> 
>
Re: [PATCH net-next] net: veth: Disable netpoll support
Posted by Jakub Kicinski 2 weeks ago 
On Thu, 04 Dec 2025 10:20:06 +0100 Fabian Grünbichler wrote:
> On August 5, 2024 11:40 am, Breno Leitao wrote:
> > The current implementation of netpoll in veth devices leads to
> > suboptimal behavior, as it triggers warnings due to the invocation of
> > __netif_rx() within a softirq context. This is not compliant with
> > expected practices, as __netif_rx() has the following statement:
> > 
> > 	lockdep_assert_once(hardirq_count() | softirq_count());
> > 
> > Given that veth devices typically do not benefit from the
> > functionalities provided by netpoll, Disable netpoll for veth
> > interfaces.  
> 
> this patch seems to have broken combining netconsole and bridges with
> veth ports:
> 
> https://bugzilla.proxmox.com/show_bug.cgi?id=6873
> 
> any chance this is solvable?

What's the reason to set up netcons over veth?
Note that unlike normal IP traffic netcons just blindly pipes out fully
baked skbs, it doesn't use the IP stack. So unlike normal IP traffic
I think you can still point it at the physical netdev, even if that
physical netdev is under a bridge.
Re: [PATCH net-next] net: veth: Disable netpoll support
Posted by Fabian Grünbichler 2 weeks ago 
On December 5, 2025 2:34 am, Jakub Kicinski wrote:
> On Thu, 04 Dec 2025 10:20:06 +0100 Fabian Grünbichler wrote:
>> On August 5, 2024 11:40 am, Breno Leitao wrote:
>> > The current implementation of netpoll in veth devices leads to
>> > suboptimal behavior, as it triggers warnings due to the invocation of
>> > __netif_rx() within a softirq context. This is not compliant with
>> > expected practices, as __netif_rx() has the following statement:
>> > 
>> > 	lockdep_assert_once(hardirq_count() | softirq_count());
>> > 
>> > Given that veth devices typically do not benefit from the
>> > functionalities provided by netpoll, Disable netpoll for veth
>> > interfaces.  
>> 
>> this patch seems to have broken combining netconsole and bridges with
>> veth ports:
>> 
>> https://bugzilla.proxmox.com/show_bug.cgi?id=6873
>> 
>> any chance this is solvable?
> 
> What's the reason to set up netcons over veth?

I don't think there is a particular reason to do so, the veth devices
just get "caught in the crossfire", so to speak - if the netconsole
setup includes the bridge that the veth device is plugged into.

> Note that unlike normal IP traffic netcons just blindly pipes out fully
> baked skbs, it doesn't use the IP stack. So unlike normal IP traffic
> I think you can still point it at the physical netdev, even if that
> physical netdev is under a bridge.

yes, pointing it at a physical bridge port works!

I mainly wanted to make you aware of this regression, since it seems it
was not on the radar when the original patch was written and applied. if
fixing it is too much of a hassle/has too many other unwanted side
effects, I do think (hope? ;)) people can live with this restriction. I
definitely agree that restricting netconsole to the actual links where
the traffic is supposed to go out is the sensible choice in any case.
Re: [PATCH net-next] net: veth: Disable netpoll support
Posted by Breno Leitao 2 weeks, 1 day ago 
hello Fabian,

On Thu, Dec 04, 2025 at 10:20:06AM +0100, Fabian Grünbichler wrote:
> On August 5, 2024 11:40 am, Breno Leitao wrote:
> > The current implementation of netpoll in veth devices leads to
> > suboptimal behavior, as it triggers warnings due to the invocation of
> > __netif_rx() within a softirq context. This is not compliant with
> > expected practices, as __netif_rx() has the following statement:
> > 
> > 	lockdep_assert_once(hardirq_count() | softirq_count());
> > 
> > Given that veth devices typically do not benefit from the
> > functionalities provided by netpoll, Disable netpoll for veth
> > interfaces.
> 
> this patch seems to have broken combining netconsole and bridges with
> veth ports:

Sorry about it, but, veth ends up calling __netif_rx() from a process
context, which kicks the lockdep above.

__netif_rx() should be only called from soft or hard IRQ, which is not
how netpoll operates. A printk message can be printed for any context.

> https://bugzilla.proxmox.com/show_bug.cgi?id=6873
> 
> any chance this is solvable?

I don't see a clear way to solve it from a netpoll point of view,
honestly.

From a veth perspective, I am wonderig if veth_forward_skb() can call
netif_rx(), which seems to be safe in any context. Something as:

	diff --git a/drivers/net/veth.c b/drivers/net/veth.c
	index cc502bf022d5..cf6443e5d7bc 100644
	--- a/drivers/net/veth.c
	+++ b/drivers/net/veth.c
	@@ -318,7 +318,7 @@ static int veth_forward_skb(struct net_device *dev, struct sk_buff *skb,
	{
		return __dev_forward_skb(dev, skb) ?: xdp ?
			veth_xdp_rx(rq, skb) :
	-               __netif_rx(skb);
	+               netif_rx(skb);
	}

	/* return true if the specified skb has chances of GRO aggregation
	@@ -1734,7 +1734,6 @@ static void veth_setup(struct net_device *dev)
		dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
		dev->priv_flags |= IFF_NO_QUEUE;
		dev->priv_flags |= IFF_PHONY_HEADROOM;
	-       dev->priv_flags |= IFF_DISABLE_NETPOLL;
		dev->lltx = true;

		dev->netdev_ops = &veth_netdev_ops;

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.