[PATCH v3 3/3] arm64: defconfig: Enable interconnect for SM4450

Tengfei Fan posted 3 patches 1 year, 6 months ago
There is a newer version of this series
[PATCH v3 3/3] arm64: defconfig: Enable interconnect for SM4450
Posted by Tengfei Fan 1 year, 6 months ago
Add the SM4450 interconnect driver as built-in.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 831aa314bc9c..d6f50d31568e 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1623,6 +1623,7 @@ CONFIG_INTERCONNECT_QCOM_SC8180X=y
 CONFIG_INTERCONNECT_QCOM_SC8280XP=y
 CONFIG_INTERCONNECT_QCOM_SDM845=y
 CONFIG_INTERCONNECT_QCOM_SDX75=y
+CONFIG_INTERCONNECT_QCOM_SM4450=y
 CONFIG_INTERCONNECT_QCOM_SM6115=y
 CONFIG_INTERCONNECT_QCOM_SM8150=y
 CONFIG_INTERCONNECT_QCOM_SM8250=y

-- 
2.25.1
Re: [PATCH v3 3/3] arm64: defconfig: Enable interconnect for SM4450
Posted by Krzysztof Kozlowski 1 year, 6 months ago
On 01/08/2024 10:54, Tengfei Fan wrote:
> Add the SM4450 interconnect driver as built-in.

This we see from the diff. Tell us instead: why?

That's a standard requirement for every defconfig change. Damn, for
every change. Don't say what the diff is saying, unless it is
non-trivial. Say why you are doing things.

Best regards,
Krzysztof
Re: [PATCH v3 3/3] arm64: defconfig: Enable interconnect for SM4450
Posted by Tengfei Fan 1 year, 6 months ago

On 8/2/2024 3:20 PM, Krzysztof Kozlowski wrote:
> On 01/08/2024 10:54, Tengfei Fan wrote:
>> Add the SM4450 interconnect driver as built-in.
> 
> This we see from the diff. Tell us instead: why?
> 
> That's a standard requirement for every defconfig change. Damn, for
> every change. Don't say what the diff is saying, unless it is
> non-trivial. Say why you are doing things.
> 
> Best regards,
> Krzysztof
> 

In the next version of the patch series, I will describe in the comment 
message why this config needs to be enabled.

-- 
Thx and BRs,
Tengfei Fan