iio: adc: aspeed: Use of_property_present()

[PATCH] iio: adc: aspeed: Use of_property_present()

Posted by Rob Herring (Arm) 1 year, 6 months ago

Use of_property_present() to test for property presence rather than
of_find_property(). This is part of a larger effort to remove callers
of of_find_property() and similar functions. of_find_property() leaks
the DT struct property and data pointers which is a problem for
dynamically allocated nodes which may be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 drivers/iio/adc/aspeed_adc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c
index 090416c0d622..064cddaf6399 100644
--- a/drivers/iio/adc/aspeed_adc.c
+++ b/drivers/iio/adc/aspeed_adc.c
@@ -555,8 +555,7 @@ static int aspeed_adc_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	if (of_find_property(data->dev->of_node, "aspeed,battery-sensing",
-			     NULL)) {
+	if (of_property_present(data->dev->of_node, "aspeed,battery-sensing")) {
 		if (data->model_data->bat_sense_sup) {
 			data->battery_sensing = 1;
 			if (readl(data->base + ASPEED_REG_ENGINE_CONTROL) &
-- 
2.43.0

Re: [PATCH] iio: adc: aspeed: Use of_property_present()

Posted by Andrew Jeffery 1 year, 6 months ago

On Wed, 2024-07-31 at 13:12 -0600, Rob Herring (Arm) wrote:
> Use of_property_present() to test for property presence rather than
> of_find_property(). This is part of a larger effort to remove callers
> of of_find_property() and similar functions. of_find_property() leaks
> the DT struct property and data pointers which is a problem for
> dynamically allocated nodes which may be freed.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Acked-by: Andrew Jeffery <andrew@codeconstruct.com.au>

Re: [PATCH] iio: adc: aspeed: Use of_property_present()

Posted by Jonathan Cameron 1 year, 6 months ago

On Thu, 01 Aug 2024 11:13:50 +0930
Andrew Jeffery <andrew@codeconstruct.com.au> wrote:

> On Wed, 2024-07-31 at 13:12 -0600, Rob Herring (Arm) wrote:
> > Use of_property_present() to test for property presence rather than
> > of_find_property(). This is part of a larger effort to remove callers
> > of of_find_property() and similar functions. of_find_property() leaks
> > the DT struct property and data pointers which is a problem for
> > dynamically allocated nodes which may be freed.
> > 
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>  
> 
> Acked-by: Andrew Jeffery <andrew@codeconstruct.com.au>
> 

Applied.