drivers/staging/vme_user/vme_bridge.h | 4 ++++ 1 file changed, 4 insertions(+)
Adhere to Linux kernel coding style
Reported by checkpatch:
CHECK: mutex definition without comment
Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
---
drivers/staging/vme_user/vme_bridge.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_user/vme_bridge.h
index 9bdc41bb6602..0b1f05944f0d 100644
--- a/drivers/staging/vme_user/vme_bridge.h
+++ b/drivers/staging/vme_user/vme_bridge.h
@@ -28,6 +28,7 @@ struct vme_master_resource {
struct vme_slave_resource {
struct list_head list;
struct vme_bridge *parent;
+ /* Locking for VME slave resources */
struct mutex mtx;
int locked;
int number;
@@ -55,12 +56,14 @@ struct vme_dma_list {
struct list_head list;
struct vme_dma_resource *parent;
struct list_head entries;
+ /* Mutex to protect access to DMA list's entries */
struct mutex mtx;
};
struct vme_dma_resource {
struct list_head list;
struct vme_bridge *parent;
+ /* Mutex to protect DMA controller resources and ensure thread-safe operations */
struct mutex mtx;
int locked;
int number;
@@ -72,6 +75,7 @@ struct vme_dma_resource {
struct vme_lm_resource {
struct list_head list;
struct vme_bridge *parent;
+ /* Mutex to protect LM Monitor resources and ensure thread-safe operations */
struct mutex mtx;
int locked;
int number;
--
2.39.2
On Wed, Jul 31, 2024 at 01:06:05PM +0530, Riyan Dhiman wrote:
> Adhere to Linux kernel coding style
>
> Reported by checkpatch:
>
> CHECK: mutex definition without comment
>
> Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
> ---
> drivers/staging/vme_user/vme_bridge.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_user/vme_bridge.h
> index 9bdc41bb6602..0b1f05944f0d 100644
> --- a/drivers/staging/vme_user/vme_bridge.h
> +++ b/drivers/staging/vme_user/vme_bridge.h
> @@ -28,6 +28,7 @@ struct vme_master_resource {
> struct vme_slave_resource {
> struct list_head list;
> struct vme_bridge *parent;
> + /* Locking for VME slave resources */
Are you sure about all of these? Please document them individually and
put the proof of that in the changelog text.
thanks,
greg k-h
© 2016 - 2025 Red Hat, Inc.