[PATCH] accel: drm_accel: remove incorrect comments

bajing posted 1 patch 1 year, 4 months ago
drivers/accel/drm_accel.c | 2 --
1 file changed, 2 deletions(-)
[PATCH] accel: drm_accel: remove incorrect comments
Posted by bajing 1 year, 4 months ago
accel_minor_replace is of type void, so remove the explanation of the return value in the comments.

Signed-off-by: bajing <bajing@cmss.chinamobile.com>
---
 drivers/accel/drm_accel.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/accel/drm_accel.c b/drivers/accel/drm_accel.c
index 16c3edb8c46e..09fb64444cc6 100644
--- a/drivers/accel/drm_accel.c
+++ b/drivers/accel/drm_accel.c
@@ -161,8 +161,6 @@ void accel_minor_remove(int index)
  * This function access the accel minors idr structure and replaces the pointer
  * that is associated with an existing id. Because the minor pointer can be
  * NULL, we need to explicitly pass the index.
- *
- * Return: 0 for success, negative value for error
  */
 void accel_minor_replace(struct drm_minor *minor, int index)
 {
-- 
2.39.3
Re: [PATCH] accel: drm_accel: remove incorrect comments
Posted by Jeffrey Hugo 1 year, 4 months ago
On 7/31/2024 12:42 AM, bajing wrote:
> accel_minor_replace is of type void, so remove the explanation of the return value in the comments.
> 
> Signed-off-by: bajing <bajing@cmss.chinamobile.com>
> ---
>   drivers/accel/drm_accel.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/accel/drm_accel.c b/drivers/accel/drm_accel.c
> index 16c3edb8c46e..09fb64444cc6 100644
> --- a/drivers/accel/drm_accel.c
> +++ b/drivers/accel/drm_accel.c
> @@ -161,8 +161,6 @@ void accel_minor_remove(int index)
>    * This function access the accel minors idr structure and replaces the pointer
>    * that is associated with an existing id. Because the minor pointer can be
>    * NULL, we need to explicitly pass the index.
> - *
> - * Return: 0 for success, negative value for error
>    */
>   void accel_minor_replace(struct drm_minor *minor, int index)
>   {

Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Re: [PATCH] accel: drm_accel: remove incorrect comments
Posted by Carl Vanderlip 1 year, 4 months ago
On 7/30/2024 11:42 PM, bajing wrote:
 > accel_minor_replace is of type void, so remove the explanation of the 
return value in the comments.
 >
 > Signed-off-by: bajing <bajing@cmss.chinamobile.com>

Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com>