usb: misc: eud: switch to fallback compatible for device matching

[PATCH] usb: misc: eud: switch to fallback compatible for device matching

Posted by Krzysztof Kozlowski 1 year, 6 months ago

The bindings require two compatibles to be used: qcom,sc7280-eud
followed by fallback qcom,eud.  The convention is to use fallback
compatible in OF device ID tables, unless some device-specific quirks
are needed.

This will also simplify matching any new devices - they will use
existing OF device ID entry, instead of adding a new one.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/usb/misc/qcom_eud.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/misc/qcom_eud.c b/drivers/usb/misc/qcom_eud.c
index 26e9b8749d8a..19906301a4eb 100644
--- a/drivers/usb/misc/qcom_eud.c
+++ b/drivers/usb/misc/qcom_eud.c
@@ -232,7 +232,7 @@ static void eud_remove(struct platform_device *pdev)
 }
 
 static const struct of_device_id eud_dt_match[] = {
-	{ .compatible = "qcom,sc7280-eud" },
+	{ .compatible = "qcom,eud" },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, eud_dt_match);
-- 
2.43.0

Re: [PATCH] usb: misc: eud: switch to fallback compatible for device matching

Posted by Dmitry Baryshkov 1 year, 6 months ago

On Wed, Jul 31, 2024 at 07:44:38AM GMT, Krzysztof Kozlowski wrote:
> The bindings require two compatibles to be used: qcom,sc7280-eud
> followed by fallback qcom,eud.  The convention is to use fallback
> compatible in OF device ID tables, unless some device-specific quirks
> are needed.
> 
> This will also simplify matching any new devices - they will use
> existing OF device ID entry, instead of adding a new one.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/usb/misc/qcom_eud.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


-- 
With best wishes
Dmitry