staging: rtl8192e: remove duplicate macros from rtllib.h

[PATCH] staging: rtl8192e: remove duplicate macros from rtllib.h

Posted by Michael Straube 1 year, 6 months ago

These macros just duplicate macros from include/linux/ieee80211.h.
We can safely remove them from rtllib.h.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
compile-tested only

 drivers/staging/rtl8192e/rtllib.h | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 022851b7f1a9..e87313a30741 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -414,17 +414,6 @@ enum _REG_PREAMBLE_MODE {
 #define WLAN_GET_SEQ_FRAG(seq) ((seq) & RTLLIB_SCTL_FRAG)
 #define WLAN_GET_SEQ_SEQ(seq)  (((seq) & RTLLIB_SCTL_SEQ) >> 4)
 
-/* Authentication algorithms */
-#define WLAN_AUTH_OPEN 0
-#define WLAN_AUTH_SHARED_KEY 1
-#define WLAN_AUTH_LEAP 128
-
-#define WLAN_CAPABILITY_ESS (1<<0)
-#define WLAN_CAPABILITY_IBSS (1<<1)
-#define WLAN_CAPABILITY_PRIVACY (1<<4)
-#define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
-#define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
-
 #define RTLLIB_STATMASK_SIGNAL (1<<0)
 #define RTLLIB_STATMASK_RSSI (1<<1)
 #define RTLLIB_STATMASK_NOISE (1<<2)
-- 
2.45.2

Re: [PATCH] staging: rtl8192e: remove duplicate macros from rtllib.h

Posted by Philipp Hortmann 1 year, 6 months ago

On 7/30/24 10:29, Michael Straube wrote:
> These macros just duplicate macros from include/linux/ieee80211.h.
> We can safely remove them from rtllib.h.
> 
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
> compile-tested only
> 
>   drivers/staging/rtl8192e/rtllib.h | 11 -----------
>   1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 022851b7f1a9..e87313a30741 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -414,17 +414,6 @@ enum _REG_PREAMBLE_MODE {
>   #define WLAN_GET_SEQ_FRAG(seq) ((seq) & RTLLIB_SCTL_FRAG)
>   #define WLAN_GET_SEQ_SEQ(seq)  (((seq) & RTLLIB_SCTL_SEQ) >> 4)
>   
> -/* Authentication algorithms */
> -#define WLAN_AUTH_OPEN 0
> -#define WLAN_AUTH_SHARED_KEY 1
> -#define WLAN_AUTH_LEAP 128
> -
> -#define WLAN_CAPABILITY_ESS (1<<0)
> -#define WLAN_CAPABILITY_IBSS (1<<1)
> -#define WLAN_CAPABILITY_PRIVACY (1<<4)
> -#define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
> -#define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
> -
>   #define RTLLIB_STATMASK_SIGNAL (1<<0)
>   #define RTLLIB_STATMASK_RSSI (1<<1)
>   #define RTLLIB_STATMASK_NOISE (1<<2)


Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>