staging: fbtft: Remove trailing semicolon in macro.

[PATCH] staging: fbtft: Remove trailing semicolon in macro.

Posted by Sakirnth Nagarasa 1 year, 4 months ago

Fix checkpath warning: "WARNING: macros should not use a trailing semicolon
in fbtft.h:356.

Signed-off-by: Sakirnth Nagarasa <sakirnth@gmail.com>

---

Hello, this is my first patch to the kernel.
---
 drivers/staging/fbtft/fbtft.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index f86ed9d47..45dfc92b8 100644
--- a/drivers/staging/fbtft/fbtft.h
+++ b/drivers/staging/fbtft/fbtft.h
@@ -365,7 +365,7 @@ MODULE_DEVICE_TABLE(spi, spi_ids);						\
 										\
 FBTFT_SPI_DRIVER(_name, _comp_vend "," _comp_dev, _display, spi_ids)		\
 										\
-module_spi_driver(fbtft_driver_spi_driver);
+module_spi_driver(fbtft_driver_spi_driver)
 
 /* Debug macros */
 
-- 
2.20.1

Re: [PATCH] staging: fbtft: Remove trailing semicolon in macro.

Posted by Greg KH 1 year, 4 months ago

On Tue, Jul 30, 2024 at 07:14:55AM +0000, Sakirnth Nagarasa wrote:
> Fix checkpath warning: "WARNING: macros should not use a trailing semicolon
> in fbtft.h:356.
> 
> Signed-off-by: Sakirnth Nagarasa <sakirnth@gmail.com>
> 
> ---
> 
> Hello, this is my first patch to the kernel.
> ---
>  drivers/staging/fbtft/fbtft.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
> index f86ed9d47..45dfc92b8 100644
> --- a/drivers/staging/fbtft/fbtft.h
> +++ b/drivers/staging/fbtft/fbtft.h
> @@ -365,7 +365,7 @@ MODULE_DEVICE_TABLE(spi, spi_ids);						\
>  										\
>  FBTFT_SPI_DRIVER(_name, _comp_vend "," _comp_dev, _display, spi_ids)		\
>  										\
> -module_spi_driver(fbtft_driver_spi_driver);
> +module_spi_driver(fbtft_driver_spi_driver)

checkpatch is wrong here, the ';' is correct.

thanks,

greg k-h