[PATCH v2] staging: rtl8723bs: style fix open brace on new line

Sai Sree Kartheek Adivi posted 1 patch 1 year, 4 months ago
drivers/staging/rtl8723bs/include/osdep_service.h | 2 --
1 file changed, 2 deletions(-)
[PATCH v2] staging: rtl8723bs: style fix open brace on new line
Posted by Sai Sree Kartheek Adivi 1 year, 4 months ago
It fixes the following checkpatch.pl error
"ERROR: that open brace { should be on the previous line" and avoids the
warning "WARNING: braces {} are not necessary for single statement blocks".

Signed-off-by: Sai Sree Kartheek Adivi <sskartheekadivi@gmail.com>
---
Updated the commit message.
This is my first contribution. Hope I did everything right!

 drivers/staging/rtl8723bs/include/osdep_service.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
index cf96b5f7a..5629123cd 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service.h
@@ -81,9 +81,7 @@ static inline void thread_enter(char *name)
 static inline void flush_signals_thread(void)
 {
 	if (signal_pending(current))
-	{
 		flush_signals(current);
-	}
 }
 
 #define rtw_warn_on(condition) WARN_ON(condition)
-- 
2.20.1
Re: [PATCH v2] staging: rtl8723bs: style fix open brace on new line
Posted by Dan Carpenter 1 year, 4 months ago
On Tue, Jul 30, 2024 at 06:59:01AM +0000, Sai Sree Kartheek Adivi wrote:
> It fixes the following checkpatch.pl error
> "ERROR: that open brace { should be on the previous line" and avoids the
> warning "WARNING: braces {} are not necessary for single statement blocks".
> 
> Signed-off-by: Sai Sree Kartheek Adivi <sskartheekadivi@gmail.com>
> ---
> Updated the commit message.
> This is my first contribution. Hope I did everything right!
> 

The only thing you didn't do was explain what changed between v1 and v2.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Please send a v3 patch.

regards,
dan carpenter