[v1] staging: rtl8723bs: Fix spacing issues

[PATCH] staging: rtl8723bs: Fix spacing issues

Posted by Benjamin Somers 1 year, 4 months ago

This patch fixes spacing issues reported by checkpatch on lines 39-40

Signed-off-by: Benjamin Somers <benjamin.somers@resel.fr>

---
This is my first patch to the kernel
---
---
 drivers/staging/rtl8723bs/include/osdep_service_linux.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/osdep_service_linux.h b/drivers/staging/rtl8723bs/include/osdep_service_linux.h
index 188ed7e26..e470abfc2 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service_linux.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service_linux.h
@@ -36,8 +36,8 @@
 	#include <linux/list.h>
 	#include <linux/vmalloc.h>
 
-/* 	#include <linux/ieee80211.h> */
-        #include <net/ieee80211_radiotap.h>
+	/* #include <linux/ieee80211.h> */
+	#include <net/ieee80211_radiotap.h>
 	#include <net/cfg80211.h>
 
 	struct	__queue	{
-- 
2.20.1

Re: [PATCH] staging: rtl8723bs: Fix spacing issues

Posted by Greg KH 1 year, 4 months ago

On Tue, Jul 30, 2024 at 06:47:45AM +0000, Benjamin Somers wrote:
> This patch fixes spacing issues reported by checkpatch on lines 39-40
> 
> Signed-off-by: Benjamin Somers <benjamin.somers@resel.fr>
> 
> ---
> This is my first patch to the kernel
> ---
> ---
>  drivers/staging/rtl8723bs/include/osdep_service_linux.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/osdep_service_linux.h b/drivers/staging/rtl8723bs/include/osdep_service_linux.h
> index 188ed7e26..e470abfc2 100644
> --- a/drivers/staging/rtl8723bs/include/osdep_service_linux.h
> +++ b/drivers/staging/rtl8723bs/include/osdep_service_linux.h
> @@ -36,8 +36,8 @@
>  	#include <linux/list.h>
>  	#include <linux/vmalloc.h>
>  
> -/* 	#include <linux/ieee80211.h> */
> -        #include <net/ieee80211_radiotap.h>
> +	/* #include <linux/ieee80211.h> */
> +	#include <net/ieee80211_radiotap.h>

Why not just remove the commented out line entirely?

And this is indented way too much, something went wrong :(

thanks,

greg k-h