drivers/gpu/drm/vboxvideo/vbox_main.c | 4 ++++ drivers/pci/devres.c | 1 + drivers/pci/pci.h | 2 -- include/linux/pci.h | 1 + 4 files changed, 6 insertions(+), 2 deletions(-)
Hi everyone, Now that we've got the simplified PCI devres API available we can slowly start using it in drivers and step by step phase the more problematic API out. vboxvideo currently does not have a region request, so it is a suitable first user. P. Philipp Stanner (2): PCI: Make pcim_request_region() a public function drm/vboxvideo: Add PCI region request drivers/gpu/drm/vboxvideo/vbox_main.c | 4 ++++ drivers/pci/devres.c | 1 + drivers/pci/pci.h | 2 -- include/linux/pci.h | 1 + 4 files changed, 6 insertions(+), 2 deletions(-) -- 2.45.2
On Mon, Jul 29, 2024 at 11:36:24AM +0200, Philipp Stanner wrote: > Hi everyone, > > Now that we've got the simplified PCI devres API available we can slowly > start using it in drivers and step by step phase the more problematic > API out. > > vboxvideo currently does not have a region request, so it is a suitable > first user. > > P. > > Philipp Stanner (2): > PCI: Make pcim_request_region() a public function > drm/vboxvideo: Add PCI region request > > drivers/gpu/drm/vboxvideo/vbox_main.c | 4 ++++ > drivers/pci/devres.c | 1 + > drivers/pci/pci.h | 2 -- > include/linux/pci.h | 1 + > 4 files changed, 6 insertions(+), 2 deletions(-) Applied with Hans' ack to pci/devres for v6.12, thanks!
Hi, On 7/29/24 11:36 AM, Philipp Stanner wrote: > Hi everyone, > > Now that we've got the simplified PCI devres API available we can slowly > start using it in drivers and step by step phase the more problematic > API out. > > vboxvideo currently does not have a region request, so it is a suitable > first user. I have given both patches a test-run on top of 6.11-rc1 in a VirtualBox VM using the vboxsvga virtual vga card: Tested-by: Hans de Goede <hdegoede@redhat.com> Also both patches look good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> for the series. Regards, Hans
On Mon, Jul 29, 2024 at 11:36:24AM +0200, Philipp Stanner wrote: > Hi everyone, > > Now that we've got the simplified PCI devres API available we can slowly > start using it in drivers and step by step phase the more problematic > API out. > > vboxvideo currently does not have a region request, so it is a suitable > first user. > > P. > > Philipp Stanner (2): > PCI: Make pcim_request_region() a public function > drm/vboxvideo: Add PCI region request > > drivers/gpu/drm/vboxvideo/vbox_main.c | 4 ++++ > drivers/pci/devres.c | 1 + > drivers/pci/pci.h | 2 -- > include/linux/pci.h | 1 + > 4 files changed, 6 insertions(+), 2 deletions(-) Given an ack from the vboxvideo maintainers, I can apply both of these via the PCI tree so there's no race during the merge window.
Hi Bjorn, On 7/31/24 9:36 PM, Bjorn Helgaas wrote: > On Mon, Jul 29, 2024 at 11:36:24AM +0200, Philipp Stanner wrote: >> Hi everyone, >> >> Now that we've got the simplified PCI devres API available we can slowly >> start using it in drivers and step by step phase the more problematic >> API out. >> >> vboxvideo currently does not have a region request, so it is a suitable >> first user. >> >> P. >> >> Philipp Stanner (2): >> PCI: Make pcim_request_region() a public function >> drm/vboxvideo: Add PCI region request >> >> drivers/gpu/drm/vboxvideo/vbox_main.c | 4 ++++ >> drivers/pci/devres.c | 1 + >> drivers/pci/pci.h | 2 -- >> include/linux/pci.h | 1 + >> 4 files changed, 6 insertions(+), 2 deletions(-) > > Given an ack from the vboxvideo maintainers, I can apply both of these > via the PCI tree so there's no race during the merge window. I'm the vboxvideo maintainer, merging both through the PCI tree sounds good to me: Acked-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans
© 2016 - 2025 Red Hat, Inc.