mm/cma: Change the addition of totalcma_pages in the cma_init_reserved_mem

[PATCH] mm/cma: Change the addition of totalcma_pages in the cma_init_reserved_mem

Posted by Hao Ge 1 year, 6 months ago

From: Hao Ge <gehao@kylinos.cn>

Replace the unnecessary division calculation with cma->count
when update the value of totalcma_pages.

Signed-off-by: Hao Ge <gehao@kylinos.cn>
---
 mm/cma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/cma.c b/mm/cma.c
index 3e9724716bad..95d6950e177b 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -202,7 +202,7 @@ int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size,
 	cma->order_per_bit = order_per_bit;
 	*res_cma = cma;
 	cma_area_count++;
-	totalcma_pages += (size / PAGE_SIZE);
+	totalcma_pages += cma->count;
 
 	return 0;
 }
-- 
2.25.1

Re: [PATCH] mm/cma: Change the addition of totalcma_pages in the cma_init_reserved_mem

Posted by David Hildenbrand 1 year, 6 months ago

On 29.07.24 10:04, Hao Ge wrote:
> From: Hao Ge <gehao@kylinos.cn>
> 
> Replace the unnecessary division calculation with cma->count
> when update the value of totalcma_pages.
> 
> Signed-off-by: Hao Ge <gehao@kylinos.cn>
> ---
>   mm/cma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/cma.c b/mm/cma.c
> index 3e9724716bad..95d6950e177b 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -202,7 +202,7 @@ int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size,
>   	cma->order_per_bit = order_per_bit;
>   	*res_cma = cma;
>   	cma_area_count++;
> -	totalcma_pages += (size / PAGE_SIZE);
> +	totalcma_pages += cma->count;
>   
>   	return 0;
>   }

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb