vfio/pci: Remove unused struct 'vfio_pci_mmap_vma'

[PATCH] vfio/pci: Remove unused struct 'vfio_pci_mmap_vma'

Posted by linux@treblig.org 1 year, 6 months ago

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'vfio_pci_mmap_vma' has been unused since
commit aac6db75a9fc ("vfio/pci: Use unmap_mapping_range()")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/vfio/pci/vfio_pci_core.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c
index ba0ce0075b2f..2127b82d301a 100644
--- a/drivers/vfio/pci/vfio_pci_core.c
+++ b/drivers/vfio/pci/vfio_pci_core.c
@@ -57,11 +57,6 @@ struct vfio_pci_vf_token {
 	int			users;
 };
 
-struct vfio_pci_mmap_vma {
-	struct vm_area_struct	*vma;
-	struct list_head	vma_next;
-};
-
 static inline bool vfio_vga_disabled(void)
 {
 #ifdef CONFIG_VFIO_PCI_VGA
-- 
2.45.2

Re: [PATCH] vfio/pci: Remove unused struct 'vfio_pci_mmap_vma'

Posted by Alex Williamson 1 year, 5 months ago

On Sat, 27 Jul 2024 17:03:06 +0100
linux@treblig.org wrote:

> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'vfio_pci_mmap_vma' has been unused since
> commit aac6db75a9fc ("vfio/pci: Use unmap_mapping_range()")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/vfio/pci/vfio_pci_core.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c
> index ba0ce0075b2f..2127b82d301a 100644
> --- a/drivers/vfio/pci/vfio_pci_core.c
> +++ b/drivers/vfio/pci/vfio_pci_core.c
> @@ -57,11 +57,6 @@ struct vfio_pci_vf_token {
>  	int			users;
>  };
>  
> -struct vfio_pci_mmap_vma {
> -	struct vm_area_struct	*vma;
> -	struct list_head	vma_next;
> -};
> -
>  static inline bool vfio_vga_disabled(void)
>  {
>  #ifdef CONFIG_VFIO_PCI_VGA

Applied to vfio next branch for v6.12.  Thanks!

Alex

RE: [PATCH] vfio/pci: Remove unused struct 'vfio_pci_mmap_vma'

Posted by Tian, Kevin 1 year, 6 months ago

> From: linux@treblig.org <linux@treblig.org>
> Sent: Sunday, July 28, 2024 12:03 AM
> 
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'vfio_pci_mmap_vma' has been unused since
> commit aac6db75a9fc ("vfio/pci: Use unmap_mapping_range()")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>

Re: [PATCH] vfio/pci: Remove unused struct 'vfio_pci_mmap_vma'

Posted by Jason Gunthorpe 1 year, 6 months ago

On Sat, Jul 27, 2024 at 05:03:06PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'vfio_pci_mmap_vma' has been unused since
> commit aac6db75a9fc ("vfio/pci: Use unmap_mapping_range()")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/vfio/pci/vfio_pci_core.c | 5 -----
>  1 file changed, 5 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason