1. Patchew
  2. linux
  3. View series

[PATCH] Fixed: fs: file_table_c: Missing blank line warnings and struct declaration improved

mohitpawar@mitaoe.ac.in posted 1 patch 1 month, 1 week ago 
fs/file_table.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
[PATCH] Fixed: fs: file_table_c: Missing blank line warnings and struct declaration improved
Posted by mohitpawar@mitaoe.ac.in 1 month, 1 week ago 
From: Mohit0404 <mohitpawar@mitaoe.ac.in>

Fixed-
	WARNING: Missing a blank line after declarations
	WARNING: Missing a blank line after declarations
	Declaration format: improved struct file declaration format

Signed-off-by: Mohit0404 <mohitpawar@mitaoe.ac.in>
---
 fs/file_table.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/fs/file_table.c b/fs/file_table.c
index ca7843dde56d..306d57623447 100644
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -136,6 +136,7 @@ static int __init init_fs_stat_sysctls(void)
 	register_sysctl_init("fs", fs_stat_sysctls);
 	if (IS_ENABLED(CONFIG_BINFMT_MISC)) {
 		struct ctl_table_header *hdr;
+
 		hdr = register_sysctl_mount_point("fs/binfmt_misc");
 		kmemleak_not_leak(hdr);
 	}
@@ -383,7 +384,10 @@ EXPORT_SYMBOL_GPL(alloc_file_pseudo_noaccount);
 struct file *alloc_file_clone(struct file *base, int flags,
 				const struct file_operations *fops)
 {
-	struct file *f = alloc_file(&base->f_path, flags, fops);
+	struct file *f;
+
+	f = alloc_file(&base->f_path, flags, fops);
+
 	if (!IS_ERR(f)) {
 		path_get(&f->f_path);
 		f->f_mapping = base->f_mapping;
-- 
2.34.1
Re: [PATCH] Fixed: fs: file_table_c: Missing blank line warnings and struct declaration improved
Posted by Jan Kara 1 month, 1 week ago 
On Sat 27-07-24 12:51:34, mohitpawar@mitaoe.ac.in wrote:
> From: Mohit0404 <mohitpawar@mitaoe.ac.in>
> 
> Fixed-
> 	WARNING: Missing a blank line after declarations
> 	WARNING: Missing a blank line after declarations
> 	Declaration format: improved struct file declaration format
> 
> Signed-off-by: Mohit0404 <mohitpawar@mitaoe.ac.in>
> ---
>  fs/file_table.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/file_table.c b/fs/file_table.c
> index ca7843dde56d..306d57623447 100644
> --- a/fs/file_table.c
> +++ b/fs/file_table.c
> @@ -136,6 +136,7 @@ static int __init init_fs_stat_sysctls(void)
>  	register_sysctl_init("fs", fs_stat_sysctls);
>  	if (IS_ENABLED(CONFIG_BINFMT_MISC)) {
>  		struct ctl_table_header *hdr;
> +
>  		hdr = register_sysctl_mount_point("fs/binfmt_misc");
>  		kmemleak_not_leak(hdr);
>  	}
> @@ -383,7 +384,10 @@ EXPORT_SYMBOL_GPL(alloc_file_pseudo_noaccount);
>  struct file *alloc_file_clone(struct file *base, int flags,
>  				const struct file_operations *fops)
>  {
> -	struct file *f = alloc_file(&base->f_path, flags, fops);
> +	struct file *f;
> +
> +	f = alloc_file(&base->f_path, flags, fops);
> +

When you separated the function call from the declaration of 'f' this empty
line is superfluous. Maybe Christian can fix it up in his tree (or maybe he
already did). Otherwise the patch looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza


-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR
Re: [PATCH] Fixed: fs: file_table_c: Missing blank line warnings and struct declaration improved
Posted by Christian Brauner 1 month, 1 week ago 
On Mon, Jul 29, 2024 at 01:49:59PM GMT, Jan Kara wrote:
> On Sat 27-07-24 12:51:34, mohitpawar@mitaoe.ac.in wrote:
> > From: Mohit0404 <mohitpawar@mitaoe.ac.in>
> > 
> > Fixed-
> > 	WARNING: Missing a blank line after declarations
> > 	WARNING: Missing a blank line after declarations
> > 	Declaration format: improved struct file declaration format
> > 
> > Signed-off-by: Mohit0404 <mohitpawar@mitaoe.ac.in>
> > ---
> >  fs/file_table.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/file_table.c b/fs/file_table.c
> > index ca7843dde56d..306d57623447 100644
> > --- a/fs/file_table.c
> > +++ b/fs/file_table.c
> > @@ -136,6 +136,7 @@ static int __init init_fs_stat_sysctls(void)
> >  	register_sysctl_init("fs", fs_stat_sysctls);
> >  	if (IS_ENABLED(CONFIG_BINFMT_MISC)) {
> >  		struct ctl_table_header *hdr;
> > +
> >  		hdr = register_sysctl_mount_point("fs/binfmt_misc");
> >  		kmemleak_not_leak(hdr);
> >  	}
> > @@ -383,7 +384,10 @@ EXPORT_SYMBOL_GPL(alloc_file_pseudo_noaccount);
> >  struct file *alloc_file_clone(struct file *base, int flags,
> >  				const struct file_operations *fops)
> >  {
> > -	struct file *f = alloc_file(&base->f_path, flags, fops);
> > +	struct file *f;
> > +
> > +	f = alloc_file(&base->f_path, flags, fops);
> > +
> 
> When you separated the function call from the declaration of 'f' this empty
> line is superfluous. Maybe Christian can fix it up in his tree (or maybe he
> already did). Otherwise the patch looks good. Feel free to add:

I already did. :)
Re: [PATCH] Fixed: fs: file_table_c: Missing blank line warnings and struct declaration improved
Posted by Christian Brauner 1 month, 1 week ago 
On Sat, 27 Jul 2024 12:51:34 +0530, mohitpawar@mitaoe.ac.in wrote:
> Fixed-
> 	WARNING: Missing a blank line after declarations
> 	WARNING: Missing a blank line after declarations
> 	Declaration format: improved struct file declaration format
> 
> 

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/1] Fixed: fs: file_table_c: Missing blank line warnings and struct declaration improved
      https://git.kernel.org/vfs/vfs/c/0268eb6ea276

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.