Hi

As discussed here [1], there are a few places in ext4 and jbd2 code where it
is assumed that a tid of '0' is not valid.  Which isn't true.

This small patchset tries to fix (hopefully!) all these places.  Jan Kara
had already identified the functions that needed to be fixed.  I believe
that the only other issue is the handling of sbi->s_fc_ineligible_tid.

Each patch in this series fixes a single function; the last one also fixes
the sbi->s_fc_ineligible_tid handling.

Changes since v1:
- [PATCH 1/4] set 'has_transaction' variable on each loop iteration
- [PATCH 3/4] dropped local variable 'is_last'; renamed 'is_first' to
  'first_set' (including corresponding semantic adjustment)
- [PATCH 4/4] removed extra braces in statement

[1] https://lore.kernel.org/all/20240716095201.o7kkrhfdy2bps3rw@quack3/

*** BLURB HERE ***

Luis Henriques (SUSE) (4):
  ext4: fix incorrect tid assumption in ext4_wait_for_tail_page_commit()
  ext4: fix incorrect tid assumption in __jbd2_log_wait_for_space()
  ext4: fix incorrect tid assumption in
    jbd2_journal_shrink_checkpoint_list()
  ext4: fix incorrect tid assumption in ext4_fc_mark_ineligible()

 fs/ext4/fast_commit.c | 15 +++++++++++----
 fs/ext4/inode.c       | 11 +++++++----
 fs/jbd2/checkpoint.c  | 14 ++++++++++----
 3 files changed, 28 insertions(+), 12 deletions(-)

On Wed, 24 Jul 2024 17:11:14 +0100, Luis Henriques (SUSE) wrote:
> As discussed here [1], there are a few places in ext4 and jbd2 code where it
> is assumed that a tid of '0' is not valid.  Which isn't true.
> 
> This small patchset tries to fix (hopefully!) all these places.  Jan Kara
> had already identified the functions that needed to be fixed.  I believe
> that the only other issue is the handling of sbi->s_fc_ineligible_tid.
> 
> [...]

Applied, thanks!

[1/4] ext4: fix incorrect tid assumption in ext4_wait_for_tail_page_commit()
      commit: dd589b0f1445e1ea1085b98edca6e4d5dedb98d0
[2/4] ext4: fix incorrect tid assumption in __jbd2_log_wait_for_space()
      commit: 972090651ee15e51abfb2160e986fa050cfc7a40
[3/4] ext4: fix incorrect tid assumption in jbd2_journal_shrink_checkpoint_list()
      commit: 7a6443e1dad70281f99f0bd394d7fd342481a632
[4/4] ext4: fix incorrect tid assumption in ext4_fc_mark_ineligible()
      commit: ebc4b2c1ac92fc0f8bf3f5a9c285a871d5084a6b

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>