[v2] sched/deadline: fixes and improvements

[PATCH v2 0/2] sched/deadline: fixes and improvements

Posted by Wander Lairson Costa 1 year, 4 months ago

Hello,

This patch series addresses specific issues and improvements within
the scheduler's deadline (DL) class. The patches aim to fix warnings,
remove redundant checks, and consolidate timer cancellation logic for
better consistency and code quality.

Patch 1: Fix warning in migrate_enable for boosted tasks

Fix a warning caused by unnecessary calls to setup_new_dl_entity for
boosted tasks during CPU migate_enable calls.

Patch 2: sched/deadline: Consolidate Timer Cancellation

Consolidate timer cancellation logic into dedicated functions,
ensuring consistent behavior and reducing code duplication.

Changelog
---------

v2:
* Drop patch to remove the redundant WARN_ON call.
* Change the "Fixes" tag in the patch 1.
* Change function names in the patch 2.

Wander Lairson Costa (2):
  sched/deadline: Fix warning in migrate_enable for boosted tasks
  sched/deadline: Consolidate Timer Cancellation

 kernel/sched/deadline.c | 45 ++++++++++++++++++++++++++---------------
 1 file changed, 29 insertions(+), 16 deletions(-)

-- 
2.45.2

Re: [PATCH v2 0/2] sched/deadline: fixes and improvements

Posted by Wander Lairson Costa 1 year, 2 months ago

On Wed, Jul 24, 2024 at 11:23 AM Wander Lairson Costa <wander@redhat.com> wrote:
>
> Hello,
>
> This patch series addresses specific issues and improvements within
> the scheduler's deadline (DL) class. The patches aim to fix warnings,
> remove redundant checks, and consolidate timer cancellation logic for
> better consistency and code quality.
>
> Patch 1: Fix warning in migrate_enable for boosted tasks
>
> Fix a warning caused by unnecessary calls to setup_new_dl_entity for
> boosted tasks during CPU migate_enable calls.
>
> Patch 2: sched/deadline: Consolidate Timer Cancellation
>
> Consolidate timer cancellation logic into dedicated functions,
> ensuring consistent behavior and reducing code duplication.
>
> Changelog
> ---------
>
> v2:
> * Drop patch to remove the redundant WARN_ON call.
> * Change the "Fixes" tag in the patch 1.
> * Change function names in the patch 2.
>
> Wander Lairson Costa (2):
>   sched/deadline: Fix warning in migrate_enable for boosted tasks
>   sched/deadline: Consolidate Timer Cancellation
>
>  kernel/sched/deadline.c | 45 ++++++++++++++++++++++++++---------------
>  1 file changed, 29 insertions(+), 16 deletions(-)
>
> --
> 2.45.2
>

Notice there was a PR from sched a few days ago, but this patchset was
not part of it. Do you know if this will be added later in this
window?

Re: [PATCH v2 0/2] sched/deadline: fixes and improvements

Posted by Phil Auld 1 year, 2 months ago

On Mon, Sep 23, 2024 at 01:45:13PM -0300 Wander Lairson Costa wrote:
> On Wed, Jul 24, 2024 at 11:23 AM Wander Lairson Costa <wander@redhat.com> wrote:
> >
> > Hello,
> >
> > This patch series addresses specific issues and improvements within
> > the scheduler's deadline (DL) class. The patches aim to fix warnings,
> > remove redundant checks, and consolidate timer cancellation logic for
> > better consistency and code quality.
> >
> > Patch 1: Fix warning in migrate_enable for boosted tasks
> >
> > Fix a warning caused by unnecessary calls to setup_new_dl_entity for
> > boosted tasks during CPU migate_enable calls.
> >
> > Patch 2: sched/deadline: Consolidate Timer Cancellation
> >
> > Consolidate timer cancellation logic into dedicated functions,
> > ensuring consistent behavior and reducing code duplication.
> >
> > Changelog
> > ---------
> >
> > v2:
> > * Drop patch to remove the redundant WARN_ON call.
> > * Change the "Fixes" tag in the patch 1.
> > * Change function names in the patch 2.
> >
> > Wander Lairson Costa (2):
> >   sched/deadline: Fix warning in migrate_enable for boosted tasks
> >   sched/deadline: Consolidate Timer Cancellation
> >
> >  kernel/sched/deadline.c | 45 ++++++++++++++++++++++++++---------------
> >  1 file changed, 29 insertions(+), 16 deletions(-)
> >
> > --
> > 2.45.2
> >
> 
> Notice there was a PR from sched a few days ago, but this patchset was
> not part of it. Do you know if this will be added later in this
> window?
>

Unless Peter takes this in sched/urgent then it will likely be in v6.13
assuming it gets picked up.  Ping Peter?


Cheers,
Phil



--

Re: [PATCH v2 0/2] sched/deadline: fixes and improvements

Posted by Juri Lelli 1 year, 4 months ago

Hi Wander,

On 24/07/24 11:22, Wander Lairson Costa wrote:
> Hello,
> 
> This patch series addresses specific issues and improvements within
> the scheduler's deadline (DL) class. The patches aim to fix warnings,
> remove redundant checks, and consolidate timer cancellation logic for
> better consistency and code quality.
> 
> Patch 1: Fix warning in migrate_enable for boosted tasks
> 
> Fix a warning caused by unnecessary calls to setup_new_dl_entity for
> boosted tasks during CPU migate_enable calls.
> 
> Patch 2: sched/deadline: Consolidate Timer Cancellation
> 
> Consolidate timer cancellation logic into dedicated functions,
> ensuring consistent behavior and reducing code duplication.
> 
> Changelog
> ---------
> 
> v2:
> * Drop patch to remove the redundant WARN_ON call.
> * Change the "Fixes" tag in the patch 1.
> * Change function names in the patch 2.
> 
> Wander Lairson Costa (2):
>   sched/deadline: Fix warning in migrate_enable for boosted tasks
>   sched/deadline: Consolidate Timer Cancellation
> 
>  kernel/sched/deadline.c | 45 ++++++++++++++++++++++++++---------------
>  1 file changed, 29 insertions(+), 16 deletions(-)

Looks good to me now.

Acked-by: Juri Lelli <juri.lelli@redhat.com>

Thanks!
Juri

Re: [PATCH v2 0/2] sched/deadline: fixes and improvements

Posted by Peter Zijlstra 1 year, 4 months ago

On Thu, Jul 25, 2024 at 09:29:26AM +0200, Juri Lelli wrote:
> Hi Wander,
> 
> On 24/07/24 11:22, Wander Lairson Costa wrote:
> > Hello,
> > 
> > This patch series addresses specific issues and improvements within
> > the scheduler's deadline (DL) class. The patches aim to fix warnings,
> > remove redundant checks, and consolidate timer cancellation logic for
> > better consistency and code quality.
> > 
> > Patch 1: Fix warning in migrate_enable for boosted tasks
> > 
> > Fix a warning caused by unnecessary calls to setup_new_dl_entity for
> > boosted tasks during CPU migate_enable calls.
> > 
> > Patch 2: sched/deadline: Consolidate Timer Cancellation
> > 
> > Consolidate timer cancellation logic into dedicated functions,
> > ensuring consistent behavior and reducing code duplication.
> > 
> > Changelog
> > ---------
> > 
> > v2:
> > * Drop patch to remove the redundant WARN_ON call.
> > * Change the "Fixes" tag in the patch 1.
> > * Change function names in the patch 2.
> > 
> > Wander Lairson Costa (2):
> >   sched/deadline: Fix warning in migrate_enable for boosted tasks
> >   sched/deadline: Consolidate Timer Cancellation
> > 
> >  kernel/sched/deadline.c | 45 ++++++++++++++++++++++++++---------------
> >  1 file changed, 29 insertions(+), 16 deletions(-)
> 
> Looks good to me now.
> 
> Acked-by: Juri Lelli <juri.lelli@redhat.com>

I stuck this in queue/sched/core, but there was some trivial rejects on
the second patch, which I stomped on. It builds, but please double check
I didn't mess it up.

Re: [PATCH v2 0/2] sched/deadline: fixes and improvements

Posted by Wander Lairson Costa 1 year, 4 months ago

On Wed, Aug 7, 2024 at 7:59 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Thu, Jul 25, 2024 at 09:29:26AM +0200, Juri Lelli wrote:
> > Hi Wander,
> >
> > On 24/07/24 11:22, Wander Lairson Costa wrote:
> > > Hello,
> > >
> > > This patch series addresses specific issues and improvements within
> > > the scheduler's deadline (DL) class. The patches aim to fix warnings,
> > > remove redundant checks, and consolidate timer cancellation logic for
> > > better consistency and code quality.
> > >
> > > Patch 1: Fix warning in migrate_enable for boosted tasks
> > >
> > > Fix a warning caused by unnecessary calls to setup_new_dl_entity for
> > > boosted tasks during CPU migate_enable calls.
> > >
> > > Patch 2: sched/deadline: Consolidate Timer Cancellation
> > >
> > > Consolidate timer cancellation logic into dedicated functions,
> > > ensuring consistent behavior and reducing code duplication.
> > >
> > > Changelog
> > > ---------
> > >
> > > v2:
> > > * Drop patch to remove the redundant WARN_ON call.
> > > * Change the "Fixes" tag in the patch 1.
> > > * Change function names in the patch 2.
> > >
> > > Wander Lairson Costa (2):
> > >   sched/deadline: Fix warning in migrate_enable for boosted tasks
> > >   sched/deadline: Consolidate Timer Cancellation
> > >
> > >  kernel/sched/deadline.c | 45 ++++++++++++++++++++++++++---------------
> > >  1 file changed, 29 insertions(+), 16 deletions(-)
> >
> > Looks good to me now.
> >
> > Acked-by: Juri Lelli <juri.lelli@redhat.com>
>
> I stuck this in queue/sched/core, but there was some trivial rejects on
> the second patch, which I stomped on. It builds, but please double check
> I didn't mess it up.
>

I gave it a look and everything seems fine.