Capitalize Farenheit

[PATCH] Capitalize Farenheit

Posted by David Hunter 1 month, 2 weeks ago

Not capitalizing "fahrenheit" is an extremely minor spelling mistake.
This commit fixes that.

Signed-off-by: David Hunter <david.hunter.linux@gmail.com>
---
 Documentation/watchdog/watchdog-api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/watchdog/watchdog-api.rst b/Documentation/watchdog/watchdog-api.rst
index 800dcd7586f2..78e228c272cf 100644
--- a/Documentation/watchdog/watchdog-api.rst
+++ b/Documentation/watchdog/watchdog-api.rst
@@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only
 support the GETBOOTSTATUS call.
 
 Some drivers can measure the temperature using the GETTEMP ioctl.  The
-returned value is the temperature in degrees fahrenheit::
+returned value is the temperature in degrees Fahrenheit::
 
     int temperature;
     ioctl(fd, WDIOC_GETTEMP, &temperature);
-- 
2.34.1

Re: [PATCH] Capitalize Farenheit

Posted by Guenter Roeck 1 month, 2 weeks ago

On 7/23/24 06:18, David Hunter wrote:
> Not capitalizing "fahrenheit" is an extremely minor spelling mistake.
> This commit fixes that.
> 

Please at least follow guidelines for submitting patches, specifically

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
  instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
  to do frotz", as if you are giving orders to the codebase to change
  its behaviour.
"

Guenter

> Signed-off-by: David Hunter <david.hunter.linux@gmail.com>
> ---
>   Documentation/watchdog/watchdog-api.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/watchdog/watchdog-api.rst b/Documentation/watchdog/watchdog-api.rst
> index 800dcd7586f2..78e228c272cf 100644
> --- a/Documentation/watchdog/watchdog-api.rst
> +++ b/Documentation/watchdog/watchdog-api.rst
> @@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only
>   support the GETBOOTSTATUS call.
>   
>   Some drivers can measure the temperature using the GETTEMP ioctl.  The
> -returned value is the temperature in degrees fahrenheit::
> +returned value is the temperature in degrees Fahrenheit::
>   
>       int temperature;
>       ioctl(fd, WDIOC_GETTEMP, &temperature);

Re: [PATCH] Capitalize Farenheit

Posted by Randy Dunlap 1 month, 2 weeks ago


On 7/23/24 6:57 AM, Guenter Roeck wrote:
> On 7/23/24 06:18, David Hunter wrote:
>> Not capitalizing "fahrenheit" is an extremely minor spelling mistake.
>> This commit fixes that.
>>
> 
> Please at least follow guidelines for submitting patches, specifically
> 
> "Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
>  instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
>  to do frotz", as if you are giving orders to the codebase to change
>  its behaviour.
> "
> 
> Guenter
> 

Also, please spell it correctly in the $Subject.

>> Signed-off-by: David Hunter <david.hunter.linux@gmail.com>
>> ---
>>   Documentation/watchdog/watchdog-api.rst | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/watchdog/watchdog-api.rst b/Documentation/watchdog/watchdog-api.rst
>> index 800dcd7586f2..78e228c272cf 100644
>> --- a/Documentation/watchdog/watchdog-api.rst
>> +++ b/Documentation/watchdog/watchdog-api.rst
>> @@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only
>>   support the GETBOOTSTATUS call.
>>     Some drivers can measure the temperature using the GETTEMP ioctl.  The
>> -returned value is the temperature in degrees fahrenheit::
>> +returned value is the temperature in degrees Fahrenheit::
>>         int temperature;
>>       ioctl(fd, WDIOC_GETTEMP, &temperature);
> 
> 

-- 
~Randy

[PATCH v3] Documentation: Capitalize Fahrenheit in watchdog-api.rst

Posted by David Hunter 1 month ago

Capitalize "fahrenheit," a spelling mistake.

Signed-off-by: David Hunter <david.hunter.linux@gmail.com>
---
V2 -> V3:
 - Fixed misspelling of "Capitalize" in commit message. 
 - Put Tags and Kernel Subsystem in subject
 - Put changelog after commit message

V1 -> V2: 
 - Fixed imperative mood 
 - Fixed misspelling of "Fahrenheit" in Subject

V2: https://lore.kernel.org/lkml/7b7ca7e0-6bd2-45ab-bd9b-40331a8e6fdd@roeck-us.net/

V1: https://lore.kernel.org/lkml/20240723131849.264939-1-david.hunter.linux@gmail.com/

 Documentation/watchdog/watchdog-api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/Documentation/watchdog/watchdog-api.rst b/Documentation/watchdog/watchdog-api.rst
index 800dcd7586f2..78e228c272cf 100644
--- a/Documentation/watchdog/watchdog-api.rst
+++ b/Documentation/watchdog/watchdog-api.rst
@@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only
 support the GETBOOTSTATUS call.
 
 Some drivers can measure the temperature using the GETTEMP ioctl.  The
-returned value is the temperature in degrees fahrenheit::
+returned value is the temperature in degrees Fahrenheit::
 
     int temperature;
     ioctl(fd, WDIOC_GETTEMP, &temperature);
-- 
2.34.1

Re: [PATCH v3] Documentation: Capitalize Fahrenheit in watchdog-api.rst

Posted by Jonathan Corbet 3 weeks, 1 day ago

David Hunter <david.hunter.linux@gmail.com> writes:

> Capitalize "fahrenheit," a spelling mistake.
>
> Signed-off-by: David Hunter <david.hunter.linux@gmail.com>
> ---
> V2 -> V3:
>  - Fixed misspelling of "Capitalize" in commit message. 
>  - Put Tags and Kernel Subsystem in subject
>  - Put changelog after commit message
>
> V1 -> V2: 
>  - Fixed imperative mood 
>  - Fixed misspelling of "Fahrenheit" in Subject
>
> V2: https://lore.kernel.org/lkml/7b7ca7e0-6bd2-45ab-bd9b-40331a8e6fdd@roeck-us.net/
>
> V1: https://lore.kernel.org/lkml/20240723131849.264939-1-david.hunter.linux@gmail.com/
>
>  Documentation/watchdog/watchdog-api.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> ---
> diff --git a/Documentation/watchdog/watchdog-api.rst b/Documentation/watchdog/watchdog-api.rst
> index 800dcd7586f2..78e228c272cf 100644
> --- a/Documentation/watchdog/watchdog-api.rst
> +++ b/Documentation/watchdog/watchdog-api.rst
> @@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only
>  support the GETBOOTSTATUS call.
>  
>  Some drivers can measure the temperature using the GETTEMP ioctl.  The
> -returned value is the temperature in degrees fahrenheit::
> +returned value is the temperature in degrees Fahrenheit::

Applied, thanks.

jon

Re: [PATCH v3] Documentation: Capitalize Fahrenheit in watchdog-api.rst

Posted by Guenter Roeck 1 month ago

On 8/7/24 11:53, David Hunter wrote:
> Capitalize "fahrenheit," a spelling mistake.
> 
> Signed-off-by: David Hunter <david.hunter.linux@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> V2 -> V3:
>   - Fixed misspelling of "Capitalize" in commit message.
>   - Put Tags and Kernel Subsystem in subject
>   - Put changelog after commit message
> 
> V1 -> V2:
>   - Fixed imperative mood
>   - Fixed misspelling of "Fahrenheit" in Subject
> 
> V2: https://lore.kernel.org/lkml/7b7ca7e0-6bd2-45ab-bd9b-40331a8e6fdd@roeck-us.net/
> 
> V1: https://lore.kernel.org/lkml/20240723131849.264939-1-david.hunter.linux@gmail.com/
> 
>   Documentation/watchdog/watchdog-api.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> ---
> diff --git a/Documentation/watchdog/watchdog-api.rst b/Documentation/watchdog/watchdog-api.rst
> index 800dcd7586f2..78e228c272cf 100644
> --- a/Documentation/watchdog/watchdog-api.rst
> +++ b/Documentation/watchdog/watchdog-api.rst
> @@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only
>   support the GETBOOTSTATUS call.
>   
>   Some drivers can measure the temperature using the GETTEMP ioctl.  The
> -returned value is the temperature in degrees fahrenheit::
> +returned value is the temperature in degrees Fahrenheit::
>   
>       int temperature;
>       ioctl(fd, WDIOC_GETTEMP, &temperature);