[PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys

Raymond Hackley posted 1 patch 1 month, 2 weeks ago
arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi | 2 ++
1 file changed, 2 insertions(+)
[PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys
Posted by Raymond Hackley 1 month, 2 weeks ago
The phone needs the touchkeys to be enabled so the sense lines of the
touch controller are mapped properly. Otherwise the touchscreen is not
mapped to the display properly.

Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
---
 arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi
index 81b3e0760154..7a7e99b015d9 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi
@@ -262,6 +262,8 @@ touchscreen: touchscreen@20 {
 
 		pinctrl-0 = <&tsp_int_default>;
 		pinctrl-names = "default";
+
+		linux,keycodes = <KEY_APPSELECT KEY_BACK>;
 	};
 };
 
-- 
2.39.2
Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys
Posted by Konrad Dybcio 1 month, 2 weeks ago
On 23.07.2024 3:12 PM, Raymond Hackley wrote:
> The phone needs the touchkeys to be enabled so the sense lines of the
> touch controller are mapped properly. Otherwise the touchscreen is not
> mapped to the display properly.
> 
> Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> ---

Fixes?

Konrad
Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys
Posted by Raymond Hackley 1 month, 2 weeks ago
> Fixes?
>
> Konrad

Hi Konrad,

the issue is not reported or discussed on lkml, so there is no thread to fix?

Regards,
Raymond
Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys
Posted by Konrad Dybcio 1 month, 2 weeks ago
On 23.07.2024 3:39 PM, Raymond Hackley wrote:
>> Fixes?
>>
>> Konrad
> 
> Hi Konrad,
> 
> the issue is not reported or discussed on lkml, so there is no thread to fix?

See the "In case your patch fixes a bug.." paragraph in:

https://docs.kernel.org/process/submitting-patches.html
> 
> Regards,
> Raymond
>
Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys
Posted by Raymond Hackley 1 month, 2 weeks ago
> See the "In case your patch fixes a bug.." paragraph in:
>
> https://docs.kernel.org/process/submitting-patches.html

Hi Konrad,

the point is not to fix a bug, but to add touchkeys support instead.
I will reword the patch when it's confusing.

Regards,
Raymond