[v2] cache: StarFive: Require a 64-bit system

[PATCH v2] cache: StarFive: Require a 64-bit system

Posted by Palmer Dabbelt 1 year, 6 months ago

From: Palmer Dabbelt <palmer@rivosinc.com>

This has a bunch of {read,write}q() calls, so it won't work on 32-bit
systems.  I don't think there's any 32-bit StarFive systems, so for now
just require 64-bit.

Fixes: cabff60ca77d ("cache: Add StarFive StarLink cache management")
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
---
Changes since v1 <20240719163841.19018-1-palmer@rivosinc.com>:

* Drop the STARLINK_CACHE_ADDRESS_RANGE_MASK chunk, it's meaningless
  without 32-bit support (as Emil pointed out on IRC).
---
 drivers/cache/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/cache/Kconfig b/drivers/cache/Kconfig
index 94abd8f632a7..db51386c663a 100644
--- a/drivers/cache/Kconfig
+++ b/drivers/cache/Kconfig
@@ -18,6 +18,7 @@ config STARFIVE_STARLINK_CACHE
 	bool "StarFive StarLink Cache controller"
 	depends on RISCV
 	depends on ARCH_STARFIVE
+	depends on 64BIT
 	select RISCV_DMA_NONCOHERENT
 	select RISCV_NONSTANDARD_CACHE_OPS
 	help
-- 
2.45.2

Re: [PATCH v2] cache: StarFive: Require a 64-bit system

Posted by Emil Renner Berthing 1 year, 6 months ago

On Mon, 22 Jul 2024 at 17:47, Palmer Dabbelt <palmer@rivosinc.com> wrote:
>
> From: Palmer Dabbelt <palmer@rivosinc.com>
>
> This has a bunch of {read,write}q() calls, so it won't work on 32-bit
> systems.  I don't think there's any 32-bit StarFive systems, so for now
> just require 64-bit.
>
> Fixes: cabff60ca77d ("cache: Add StarFive StarLink cache management")
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>

Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>

> ---
> Changes since v1 <20240719163841.19018-1-palmer@rivosinc.com>:
>
> * Drop the STARLINK_CACHE_ADDRESS_RANGE_MASK chunk, it's meaningless
>   without 32-bit support (as Emil pointed out on IRC).
> ---
>  drivers/cache/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cache/Kconfig b/drivers/cache/Kconfig
> index 94abd8f632a7..db51386c663a 100644
> --- a/drivers/cache/Kconfig
> +++ b/drivers/cache/Kconfig
> @@ -18,6 +18,7 @@ config STARFIVE_STARLINK_CACHE
>         bool "StarFive StarLink Cache controller"
>         depends on RISCV
>         depends on ARCH_STARFIVE
> +       depends on 64BIT
>         select RISCV_DMA_NONCOHERENT
>         select RISCV_NONSTANDARD_CACHE_OPS
>         help
> --
> 2.45.2
>