[PATCH] clk: T-Head: Disable on 32-bit Targets

Palmer Dabbelt posted 1 patch 1 year, 4 months ago
drivers/clk/thead/Kconfig | 1 +
1 file changed, 1 insertion(+)
[PATCH] clk: T-Head: Disable on 32-bit Targets
Posted by Palmer Dabbelt 1 year, 4 months ago
From: Palmer Dabbelt <palmer@rivosinc.com>

This fails to build on 32-bit targets because of a missing __udivdi3.
IIRC the right way to fix that is to avoid the division, but I just want
a tree that builds and the only real T-Head platforms are 64-bit right
now.

Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
---
 drivers/clk/thead/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/thead/Kconfig b/drivers/clk/thead/Kconfig
index 1710d50bf9d4..95e0d9eb965e 100644
--- a/drivers/clk/thead/Kconfig
+++ b/drivers/clk/thead/Kconfig
@@ -3,6 +3,7 @@
 config CLK_THEAD_TH1520_AP
 	bool "T-HEAD TH1520 AP clock support"
 	depends on ARCH_THEAD || COMPILE_TEST
+	depends on 64BIT
 	default ARCH_THEAD
 	select REGMAP_MMIO
 	help
-- 
2.45.2
Re: [PATCH] clk: T-Head: Disable on 32-bit Targets
Posted by Stephen Boyd 1 year, 4 months ago
Quoting Palmer Dabbelt (2024-07-19 08:10:27)
> From: Palmer Dabbelt <palmer@rivosinc.com>
> 
> This fails to build on 32-bit targets because of a missing __udivdi3.
> IIRC the right way to fix that is to avoid the division, but I just want
> a tree that builds and the only real T-Head platforms are 64-bit right
> now.
> 
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---

Applied to clk-next
Re: [PATCH] clk: T-Head: Disable on 32-bit Targets
Posted by Drew Fustini 1 year, 4 months ago
On Fri, Jul 19, 2024 at 08:10:27AM -0700, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmer@rivosinc.com>
> 
> This fails to build on 32-bit targets because of a missing __udivdi3.
> IIRC the right way to fix that is to avoid the division, but I just want
> a tree that builds and the only real T-Head platforms are 64-bit right
> now.
> 
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---
>  drivers/clk/thead/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/thead/Kconfig b/drivers/clk/thead/Kconfig
> index 1710d50bf9d4..95e0d9eb965e 100644
> --- a/drivers/clk/thead/Kconfig
> +++ b/drivers/clk/thead/Kconfig
> @@ -3,6 +3,7 @@
>  config CLK_THEAD_TH1520_AP
>  	bool "T-HEAD TH1520 AP clock support"
>  	depends on ARCH_THEAD || COMPILE_TEST
> +	depends on 64BIT
>  	default ARCH_THEAD
>  	select REGMAP_MMIO
>  	help
> -- 
> 2.45.2
> 

Acked-by: Drew Fustini <drew@pdp7.com>

Sorry about that. This patch makes sense as the TH1520 SoC is 64-bit
and I see no valid use case to run a 32-bit kernel on it.

Drew